)]}'
{
  "commit": "e3c8fe1c2ad75964d980a0d1c7bb521560e18ecd",
  "tree": "6e549122a2a325288e0a49c65dc8b386f867ad8a",
  "parents": [
    "78543a0a89391bde1dbca8ea95fe6130a51940b8"
  ],
  "author": {
    "name": "Tyler Mandry",
    "email": "tmandry@fuchsia.infra.roller.google.com",
    "time": "Thu Nov 07 03:39:27 2024 +0000"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed Nov 06 19:41:09 2024 -0800"
  },
  "message": "[roll] Roll fuchsia [fuchsia-async] Remove WeakScopeRef, Join::detach()\n\nAs the documentation explains, the type is unnecessary because it can\u0027t\nbe used to create cycles that didn\u0027t already exist. A ScopeRef can be\nheld by a user\u0027s task code, but each Task already holds a ScopeRef, so\nit would just be redundant.\n\nWeakScopeRef does prevent cycles in the internal ownership graph.\n\nTesting this also exposed a flaw in the Join API. The intention was to\nallow cancelling or detaching after polling the Join future, but Join is\nnot Unpin, so those methods must accept `Pin\u003c\u0026mut Self\u003e` to be useful.\nAdmittedly this is a clunky API to use. I fixed cancel() but removed\ndetach() since implementing it would require putting the inner scope\nin an Option and for the rare cases that would ever need it, mem::drop()\nis a way out.\n\nOriginal-Bug: 339724492\nOriginal-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1152733\nOriginal-Revision: fe0477726529afe531f46ad709390d1bc7f035b7\nGitOrigin-RevId: d0bb73591d0ab2a669bfd60bc9d3e57f99a1964f\nChange-Id: I6825192a0a6bc199ef9bc58fa8d5090a8c6bfd11\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "45ee2188760547567efc79f2fb0155bb27022065",
      "old_mode": 33188,
      "old_path": "stem",
      "new_id": "96f7188c62b598f3a59c6c819fbe21b1e639d43e",
      "new_mode": 33188,
      "new_path": "stem"
    }
  ]
}
