| commit | deb8c67e483f8580888fbe36656315b8b2a9f707 | [log] [tgz] |
|---|---|---|
| author | Jay Zhuang <jayzhuang@fuchsia.infra.roller.google.com> | Thu Jan 23 17:29:28 2025 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Jan 23 17:31:38 2025 -0800 |
| tree | 03e3f5abde2edf2f3e0e19f471cece809c26532e | |
| parent | 9de666844515bfba06d4638155c1770f05c045ab [diff] |
[roll] Roll fuchsia [network][gub] Use bin target for check includes Because renamed_binary doesn't go through variant_target, the removed edges on library target cause non-variant versions of libraries to be included in variant-enabled (e.g. asan) builds. You can validate this by running the following command with and without this change: > fx gn path out/default '//:default' '//sdk/fidl/fuchsia.io:fuchsia.io_rust' This change switches to use data dep on binary target for metadata collection instead, which goes through variant_target. Non-gub binaries have been included in the build graph anyways, so this change should not make the build slower. In fact, it might make the variant builds faster since the unnecessary non-variant targets are pruned from the graph. Motivation for this change: The removed dep edges cause inclusion of different versions of the same Rust library in variant build (e.g asan and non-asan), making Rust compilation to fail when dylibs are introduced. This wasn't happening before because rlibs don't go through variant_target, but dylibs (which are shared_objects) do. Meanwhile it also includes unnecessary targets in variant builds, so it should be a good clean up anyways. Checking locally, the total number of targets to build for bringup.x64-asan goes down from 57,525 to 57,098 with this change. [0] https://cs.opensource.google/fuchsia/fuchsia/+/main:bundles/assembly/platform_aibs.gni;l=169;drc=b84a0ef05169edcb2b8db7f7d3dd212e123e195d Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1190572 Original-Revision: 242c75e23f91698243eea9ad6f36717f3fc99604 GitOrigin-RevId: 4b1927913d095a101871e641b332ef04c2386ffd Change-Id: I7d886b69d5a64843aa43fdef40cef1f250f9fcc1
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance in one of the communication channels documented at get involved.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.