commit db225b19e22d1e1cd6d49ee8080cdef6a454474e
author Yegor Pomortsev <ypomortsev@fuchsia.infra.roller.google.com> Fri Aug 19 19:19:36 2022 +0000
committer Copybara-Service <copybara-worker@google.com> Fri Aug 19 12:21:24 2022 -0700
tree 7d02135fdccf159705a22d05e05fdec23795b669
parent 3a84d66949d4d1bfde25ca090dfed648ffcfc753

[roll] Roll fuchsia Reland "[modular] Add present_mods_as_stories"

This is a reland of commit 27a532869642f0a7dae525be530973ca0c8837ac

Fixes two flakes:

* SessionmgrIntegrationTest.
  PresentViewBeforePresentationProtocolConnected (fxbug.dev/107008)

  This test failed because the StoryShell protocol was disconnected
  before the view was presented. The protocol would always disconnect
  at some point because the test session shell did not implement
  StoryShellFactory.

  Fixed by setting present_mods_as_stories so that no story shell
  is required and the view is always presented via GraphicalPresenter

* SessionShellTest.StartAndStopStoryWithExtraInfoMod (fxbug.dev/107009)

  This change constructs StoryProvider later than before, after the
  presentation protocol is chosen. This affects the story states seen
  by StoryProviderWatcher: if the story is created by launching the mod
  before StoryProvider is constructed, the watcher won't see an initial
  STOPPED state.

  Fixed by checking only the last story states to allow the missing
  initial story state.

Original change's description:
> [modular] Add present_mods_as_stories
>
> When the `present_mods_as_stories` config option is set and the
> session shell exposes GraphicalPresenter, sessionmgr will present
> mod views as if they are stories instead of sending the mod view
> to the story shell.
>
> This removes the need to start a story shell component when
> using GraphicalPresenter, and allows passing the mod view's ViewRef
> to the session shell through GraphicalPresenter.
>
> Original-Fixed: 68037
> Original-Bug: 60620
> Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/708018

Multiply: sessionmgr-integration-test, session-shell-test
Test: fx test sessionmgr-integration-test -vo -- --gtest_filter="SessionmgrIntegrationTest.PresentViewBeforePresentationProtocolConnected" --gtest_repeat=1000 --gtest_break_on_failure
Test: fx test session-shell-test -vo --test-filter "SessionShellTest.StartAndStopStoryWithExtraInfoMod" --count 1000 --fail
Original-Fixed: 107008
Original-Fixed: 107009
Original-Bug: 60620
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/712865
Original-Revision: 910da3cafa346e1a195e7f22be1c73f4011137b5
GitOrigin-RevId: 400ed5c44f023d84ea433b641fb9e2690fc367bd
Change-Id: I9ffb26af18098f1f39c58139bd24d800756d5f9f