| commit | d3a57dbd615fa245caebf195bf0cae5d63f379ef | [log] [tgz] |
|---|---|---|
| author | Miguel Flores Ruiz de Eguino <miguelfrde@fuchsia.infra.roller.google.com> | Tue Jan 03 21:17:28 2023 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jan 03 13:18:08 2023 -0800 |
| tree | 32605daee2de360b2f9333e14b0baece1942025c | |
| parent | d6615419fd72e6c7133e1d9a0d79bd0b9be5a000 [diff] |
[roll] Roll fuchsia [component_manager] Remove PEER_CLOSED log spam when serving Realm There was a bug that was leading to the following log present *a lot* in syslog when running some tests: ``` [12039.824][klog][klog][I] [component_manager] WARN: Couldn't send Realm response method_name=destroy_child error=A server encountered an IO error writing a FIDL response to a channel: PEER_CLOSED [12039.825][klog][klog][I] [component_manager] WARN: serve failed error=A server encountered an IO error writing a FIDL response to a channel: PEER_CLOSED ``` The callback in try_for_each resulted in the request error being propagated and hence logged twice (the second log being misleading since serve didn't fail, the request failed due to the responder.send resulting in PEER_CLOSED). It should also be fine for a client to disconnect while the server is handling a request. So `responder.send()` resulting in a closed error shouldn't be something we log. Note that with this implementation `stream.try_next().await?` never results in a PEER_CLOSED either since the FIDL bindings Stream implementation for RequestStreams converts PEER_CLOSED into Poll::Ready(None). Tested: verified the log spam is gone Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/784562 Original-Revision: 27e1d6b509f1fdae558db0fa45147dd6554c4a47 GitOrigin-RevId: 2c27ad05edbe485070d0d12e93dd5a47e0a2a6e1 Change-Id: I90e0d8ad81d87f4ad74ec96b0e6405cf89934a12
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.