| commit | d07fcca60d2429baca243b73f00f675826484b88 | [log] [tgz] |
|---|---|---|
| author | Miguel Flores Ruiz de Eguino <miguelfrde@fuchsia.infra.roller.google.com> | Sat Oct 19 01:53:44 2024 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Oct 18 18:54:53 2024 -0700 |
| tree | 6ad66edfbb1ec312d29e093a674b378ff59c4997 | |
| parent | 195976295e4f2f97c433d990f3832ee0d059746a [diff] |
[roll] Roll fuchsia [fidl][diagnostics] Remove fuchsia.diagnostics.stream Few motivations: 1) Internal library ending up in prebuilt SDK packages. 2) Adds overhead to the Rust logger. 3) Pretty much only really needed for our validator tests today, so we can define the FIDL there. This also results in some big performance improvements when decoding in both x64 and arm64. There's a few regressions in x64 encoding benchmarks, but the majority show no significant difference. I'll look into this minor regression in a follow-up as the improvements are a lot more significant and most of the encoder benchmarks show no significant difference. Result from patch#14: ARM64: ``` Test case Improve/regress? Factor change Mean before Mean after --------------------------------------------------------------------------------- ---------------- ------------- ------------------ ------------------ fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Text/1024 improved 0.423-0.439 758 +/- 13 ns 326.85 +/- 0.37 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Text/128 improved 0.377-0.378 576.77 +/- 0.41 ns 217.52 +/- 0.21 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Text/256 improved 0.380-0.392 601.9 +/- 8.7 ns 232.19 +/- 0.37 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Text/32000 improved 0.506-0.513 7636 +/- 39 ns 3890.8 +/- 7.4 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Text/512 improved 0.401-0.414 657.9 +/- 9.6 ns 267.86 +/- 0.37 ns fuchsia.diagnostics_log_rust.decoding: Decoder/ReadEvent/AllArguments improved 0.479-0.537 6008 +/- 288 ns 3045 +/- 28 ns fuchsia.diagnostics_log_rust.decoding: Decoder/ReadEvent/MessageAsString improved 0.543-0.571 2896 +/- 55 ns 1612 +/- 10 ns fuchsia.diagnostics_log_rust.decoding: Decoder/ReadEvent/MessageWithSomeArguments improved 0.521-0.549 4192 +/- 29 ns 2241 +/- 43 ns fuchsia.diagnostics_log_rust.decoding: Decoder/ReadEvent/NoArguments improved 0.541-0.565 2908 +/- 46 ns 1608 +/- 11 ns ``` X64: ``` fuchsia.diagnostics_log_rust.core: Publisher/Log/NoArguments regressed 1.002-1.047 1688.6 +/- 9.3 ns 1730 +/- 28 ns fuchsia.diagnostics_log_rust.core: Publisher/Tracing/AllArguments regressed 1.038-1.095 2249 +/- 29 ns 2399 +/- 34 ns fuchsia.diagnostics_log_rust.core: Publisher/Tracing/MessageWithSomeArguments regressed 1.030-1.090 1657 +/- 24 ns 1755 +/- 24 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Boolean improved 0.526-0.563 132.3 +/- 3.4 ns 71.98 +/- 0.66 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Floating improved 0.522-0.640 166 +/- 14 ns 95.9 +/- 1.9 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/SignedInt improved 0.531-0.600 170.1 +/- 6.1 ns 96.0 +/- 2.4 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Text/1024 improved 0.351-0.438 290 +/- 30 ns 113.11 +/- 0.86 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Text/128 improved 0.354-0.392 237.5 +/- 8.9 ns 88.4 +/- 1.1 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Text/16 improved 0.348-0.385 233.2 +/- 8.6 ns 85.3 +/- 1.1 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Text/256 improved 0.331-0.404 252 +/- 21 ns 91.8 +/- 1.6 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Text/32000 improved 0.565-0.589 2291 +/- 17 ns 1322 +/- 19 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/Text/512 improved 0.351-0.391 264.0 +/- 8.0 ns 97.8 +/- 2.3 ns fuchsia.diagnostics_log_rust.decoding: Decoder/Argument/UnsignedInt improved 0.525-0.629 169.2 +/- 7.5 ns 97.2 +/- 4.5 ns fuchsia.diagnostics_log_rust.decoding: Decoder/ReadEvent/AllArguments improved 0.494-0.573 2655 +/- 168 ns 1410 +/- 15 ns fuchsia.diagnostics_log_rust.decoding: Decoder/ReadEvent/MessageAsString improved 0.582-0.618 1257 +/- 21 ns 754 +/- 10 ns fuchsia.diagnostics_log_rust.decoding: Decoder/ReadEvent/MessageWithSomeArguments improved 0.524-0.575 1842 +/- 50 ns 1011 +/- 19 ns fuchsia.diagnostics_log_rust.decoding: Decoder/ReadEvent/NoArguments improved 0.571-0.639 1278 +/- 52 ns 771 +/- 12 ns fuchsia.diagnostics_log_rust.encoding: Encoder/Argument/Text/16 regressed 1.027-1.187 73.8 +/- 2.9 ns 81.5 +/- 2.7 ns fuchsia.diagnostics_log_rust.encoding: Encoder/Argument/Text/256 regressed 1.131-1.268 82.6 +/- 1.3 ns 99.0 +/- 4.1 ns fuchsia.diagnostics_log_rust.encoding: Encoder/Argument/Text/512 regressed 1.055-1.189 100.2 +/- 2.8 ns 112.2 +/- 3.6 ns fuchsia.diagnostics_log_rust.encoding: Encoder/WriteEvent/MessageAsString regressed 1.046-1.113 394.7 +/- 3.9 ns 426.0 +/- 9.1 ns fuchsia.diagnostics_log_rust.encoding: Encoder/WriteEvent/MessageWithSomeArguments regressed 1.142-1.201 527.1 +/- 7.6 ns 617.3 +/- 6.8 ns fuchsia.diagnostics_log_rust.encoding: Encoder/WriteEvent/NoArguments regressed 1.046-1.117 393.5 +/- 7.4 ns 425.3 +/- 6.0 ns ``` Original-Fixed: 364293789 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1140252 Original-Revision: 537c042ae62f2eb54c48665acb3f1aeb503771ac GitOrigin-RevId: d8ab895c2e520eaead27bf935e7aaf2c8f6f50bb Change-Id: Ib47ec5f7246298b5b8c40b79df510c95cfa8b93e
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance in one of the communication channels documented at get involved.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.