| commit | cd761e4fc7da0eb52e60174e654eaf77bdd285d9 | [log] [tgz] |
|---|---|---|
| author | Mark Seaborn <mseaborn@fuchsia.infra.roller.google.com> | Wed Jun 05 18:59:27 2024 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Jun 05 12:01:03 2024 -0700 |
| tree | 9df13380082350dbffb4c0c96a128279c8e5b6eb | |
| parent | e326afdf89f495ef3de052c768978f7bd25ff478 [diff] |
[roll] Roll fuchsia [fsverity] Stop verity benchmarks from being run twice The fix here is simple but it's worth explaining the background. Since they were added, the verity benchmarks were being run twice, because of the gotcha described here: https://fuchsia.dev/fuchsia-src/development/performance/faq (under "Why does my performance test get run twice in Infra builds?") Initially the second run was on QEMU, but later the second run was on a real hardware device. The change https://fuchsia-review.googlesource.com/c/fuchsia/+/1009460 ("[terminal] Switch to Fxblob") switched the second run to be on real hardware instead of QEMU, but neither arrangement was correct because we don't want the test to be run a second time at all. I noticed this by accident a few weeks ago. I noticed that queries of the culprit finder's performance results database were returning multiple results per build for the metrics produced by this test. It used to be that if a performance test were accidentally run as a Fuchsia-side-only test a second time, its results would not get copied into the Infra test shard's output, and so would not be published into the culprit finder's results database. So the gotcha above would not cause the problem of getting duplicate results. However, that was apparently changed by this CL from November 2023: https://fuchsia-review.googlesource.com/c/fuchsia/+/936577 "[testrunner] Collect test outputs from target-side tests." Landing this CL is a dependency of enabling the following consistency check, which should catch and prevent this problem in the future: https://fuchsia-review.googlesource.com/c/infra/recipes/+/1058660 Original-Bug: 343997506 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1058721 Original-Revision: baa5a462636b90464480392184e951dd449378f6 GitOrigin-RevId: 0e4e55463fc5cec02fb67555a68c3f1f47e30628 Change-Id: I57679036bd24f0a85fc8dc77c62662ecbcdd598e
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.