)]}'
{
  "commit": "c7cf2df69d9e2e0c55c137d5f05854bdccb2e3c9",
  "tree": "a0f166572628263248201cce842a7eddb6152c11",
  "parents": [
    "b008417124a603e2892fa014c6ca5957cf2b2e6d"
  ],
  "author": {
    "name": "John Grossman",
    "email": "johngro@fuchsia.infra.roller.google.com",
    "time": "Wed Mar 01 00:52:47 2023 +0000"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Tue Feb 28 16:54:36 2023 -0800"
  },
  "message": "[roll] Roll fuchsia [kernel][wait] Fix a bad assert.\n\nFix a DEBUG_ASSERT present in WaitQueueCollection::Validate which was\nsimply in the wrong place.  Validate was supposed to do any reasonable\nlevel of consistency checking and validating of the collection, based\non the currently build-configured level of extra debug checks.  Right\nnow, those checks would be O(n) at a minimum, therefore there is a\nTODO left in the validate method to implement such checks, but to do\nso only if the debug level is set to be sufficiently high (something\nlike, kSchedulerExtraInvariantValidation was enabled, or perhaps\nWAIT_QUEUE_VALIDATION was turned on.\n\nThe trouble is, there was also a DEBUG_ASSERT which was present in the\nValidate method which asserted that the queue collection was empty.\n\nValidate was being called directly from the queue collection\ndestructor, where this assert would be an appropriate assert to\nenforce.  When WAIT_QUEUE_VALIDATION was turned on for the build,\nhowever, the Validate method was getting called in more places,\nincluding places where the queue was still active (not destructing)\n\nIt is improper to assert that the collection is empty when it is\nactually active an in-use, however we don\u0027t notice unless the kernel\ndebug level has been turned up enough.  Level 3 seems to be sufficient\nto trigger the problem, something that Rasha noticed (sorry about that\nRasha), but something which no CI/CQ builder ever seems to recognize.\n\nSo, for now, just move the ASSERT.  Make sure that the destructor for\nthe collection asserts that the collection is empty, but don\u0027t ASSERT\nthat in the Validate method.\n\nOriginal-Fixed: 122701\nOriginal-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/811621\nOriginal-Revision: 8829fa73d68f037d2fc3fa3426ffb109a68831db\nGitOrigin-RevId: 097aef44ce90d9941e0b56078e4ae7dc8d34f403\nChange-Id: I5e51c57982a88d990360ab88bd67f8d129ecfa06\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d2a72e5fd2e9d659bdcf1d59d6bd58a420b6d0e8",
      "old_mode": 33188,
      "old_path": "stem",
      "new_id": "3b9c37b62036dc4598a1252ac9d055fb5b90e9ff",
      "new_mode": 33188,
      "new_path": "stem"
    }
  ]
}