commit | c1486c25db3b43952a8a3be7e7eb4af7ba75cf49 | [log] [tgz] |
---|---|---|
author | Oliver Newman <olivernewman@fuchsia.infra.roller.google.com> | Wed Oct 20 01:42:11 2021 +0000 |
committer | Copybara-Service <copybara-worker@google.com> | Tue Oct 19 18:43:17 2021 -0700 |
tree | 49ac67ca227eb633343ca02930165dd2e73490ce | |
parent | a8649d6afcddbc093f2f899403ea45e8a951dc78 [diff] |
[roll] Roll fuchsia [bootserver] Retry downloading images on CRC failures We've been seeing a fair amount of checksum failures when downloading images lately, and it seems to be transient (doesn't happen consistently for a given blob) and not necessarily associated with the Go GCS client, as other teams have seen similar failures with other GCS clients. The official GCS docs say it's okay to retry a download in case of a CRC failure, so this is probably fine to have anyway: https://cloud.google.com/storage/docs/hashes-etags#validation Unfortunately the storage library doesn't export the bad CRC error: https://github.com/googleapis/google-cloud-go/blob/07c804b08b9f2bbe181ffcee1b9b41005463b057/storage/reader.go#L415 So we must resort to a substring check to see if a download error is caused by a CRC failure. Also apply retries to corruption errors from the `flate` library, which are suspected to have a similar root cause. Original-Bug: 70972 Original-Bug: 84619 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/595882 Original-Revision: 33c23fc009c289fe97fb303a2b68bdb969e02b9c GitOrigin-RevId: 97aaf757eede7b4b310f41fab6168feedebee227 Change-Id: I3613080858fd9c4978e5c5ce2f16c64dda6b7ebf
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia
on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party
.