| commit | c0b25e2f324bfa9109e8032ba96ed22e9e1cc8e3 | [log] [tgz] |
|---|---|---|
| author | Rundong Du <rundongdu@fuchsia.infra.roller.google.com> | Fri Jan 29 18:19:36 2021 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Jan 29 10:20:27 2021 -0800 |
| tree | fee644222542f5dcd8b2f32f7c0c3062c9570a99 | |
| parent | ac0b9491301c31462f1c87cd1a35f15e8e0eef5e [diff] |
[roll] Roll fuchsia [zxdb][analytics] Report on a separate thread
Summary of changes:
- Change the signature of analytics::google_analytics::Client::AddEvent
Previously, AddEvent returns a fit::promise and let the caller
schedule the promise. Now it returns nothing (void), which means the
google analytics client need to handle the promise by itself. This is
done by incorporating AnalyticsExecutor in GoogleAnalyticsClient,
which makes analytics reporting done on a separate thread.
Main affected files:
- //src/lib/analytics/cpp/google_analytics/client.{h,cc}
- //src/lib/analytics/cpp/core_dev_tools/google_analytics_client*
- //src/lib/analytics/cpp/core_dev_tools/analytics.h
- Move some sharable analytics logic into
//src/lib/analytics/cpp/core_dev_tools/analytics.h
This is to make it easier to implement analytics for other tools.
Other main affected files:
- //src/developer/debug/zxdb/console/analytics.{h,cc}
- Incorporate the above changes to zxdb
- //src/developer/debug/zxdb/console/console_main.cc
- Change --show-analytics to --analytics-show
- //src/developer/debug/zxdb/console/command_line_options.{h,cc}
MULTIPLY: host_x64/zxdb_tests: 30
Original-Fixed: 65915
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/466167
Original-Revision: 1f4a51b06f29d53c58a12b8c3dc2b57d14a2b5e7
GitOrigin-RevId: fac73536efe3bab21164d9fadfd75550e4eec5b9
Change-Id: I791c304a5e9d347a7dc0fb525acbe4d94bfb1563
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.