| commit | a325dc6a1d7f4691f6434471cce93c0c5fd27a74 | [log] [tgz] |
|---|---|---|
| author | Adrian Danis <adanis@fuchsia.infra.roller.google.com> | Thu May 08 18:19:34 2025 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu May 08 18:21:43 2025 -0700 |
| tree | 525d3293733cb132128d588498ecbf9f56877a00 | |
| parent | 5414b7730d4b349883379c94db169928f71670b2 [diff] |
[roll] Roll fuchsia [kernel][vm] Prevent NextChild returning root_ Corrects the TreeWalkCursor::NextChild method to avoid spuriously returning the root_ node, specifically in the VmCowPages::Resize operation (this spurious return is benign when performing a RangeChangeUpdate). In a race between dropping the current lock and acquiring the child lock the child could be destroyed, causing it to not have a parent_. In this case we, correctly, call UpdateCurLocked to re-establish cur_, which is still the root_, but then just return despite not having actually moved to a child. This commit corrects this and will retry internally in NextChild if a race causes the node deletion so that the stated contract of NextChild is upheld (that it moves to a child or sibling or returns false). Although not the cause of the specific assertion failure in b/415665459 this was found during that investigation as it causes other, non kernel assertion triggering, errors in the Resize operation. Original-Bug: 415665459 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1271665 Original-Revision: ae576b8174d2b014e9f271b37f8749151d9981b7 GitOrigin-RevId: a071f84fa8b37bfc9a511fda1624b42a78909ed1 Change-Id: Id496755a0d33d4031199f5da48c68f0b67dbf607
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance in one of the communication channels documented at get involved.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.