commit a230041dc8835d8664c972e81396d0664f4825e3
author Rich Kadel <richkadel@fuchsia.infra.roller.google.com> Sat Mar 05 00:01:14 2022 +0000
committer Copybara-Service <copybara-worker@google.com> Fri Mar 04 16:02:32 2022 -0800
tree b0e2bc3802a6bdfb5edef8b8fc46719caebc02c6
parent 1de5e4fdd322eea947d1675f38a8b27bf37e8a3c

[roll] Roll fuchsia Revert "[build][dart] Default to AOT in release mode, and corrected GN template errors"

This reverts commit 8fc0dcf8b9692093826b4e867f87930459f78478.

Reason for revert: There's a SLIGHT chance this caused the tree closure failures in fxbug.dev/95103... I'm not seeing a direct correlation but we can rule this out if not.

Original change's description:
> [build][dart] Default to AOT in release mode, and corrected GN template errors
>
> The root cause behind the following bug is resolved, so the build
> scripts should no longer force JIT for release builds.
>
> Original-Fixed: 64126
>
> Also...
>
> `dart_test_component()` and `flutter_test_component()` accept a
> `build_cfg` variable from the invoker, but the GN syntax was wrong.
> Builds failed when I tried to use it to force an individual test to run
> in AOT mode (by supplying the dart_aot_runner in the test's
> configuration).
>
> Note, this is what I added to my `dart_test_component()` declaration,
> which works, with the changes in this CL:
>
> ```gn
>   # Fuchsia non-system tests do not have permissions for
>   # `ambient_mark_vmo_exec` (per the current `component_manager_policy`),
>   # which is required by the JIT runners, so build the test in AOT
>   # mode, only, and serve the AOT runner from the test component's
>   # environment.
>   if (is_debug && !dart_force_aot) {
>     # Note that `dart_aot_debug_build_cfg` does not work in the default,
>     # non-release Fuchsia build because that config enables asserts, and
>     # the current AOT VM apparently requires `no-asserts`.
>     build_cfg = dart_profile_build_cfg
>   }
> ```
>
> Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/653646

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/654203
Original-Revision: 75bb602860b2b4a5773e13edb2636f457ca6732c
GitOrigin-RevId: 3d45578d951afc9942c4b31125317bf59a4a6324
Change-Id: I8e7f3cfc08fda56f1dda133ac6d79528080c388f