| commit | 99b68a17d5c96ba8960198d211674fefb84b30c7 | [log] [tgz] |
|---|---|---|
| author | Aaron Knobloch <aknobloch@fuchsia.infra.roller.google.com> | Fri Feb 28 15:23:46 2025 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Feb 28 15:25:22 2025 -0800 |
| tree | 2e2d476b3ce8d8f1c2f82b7b4162475cf4e08dc2 | |
| parent | 6ec793e6e3e84ad6955fcae00f96dff3332a44f8 [diff] |
[roll] Roll fuchsia [starnix] Refactor empty children gating for unlink operations This change helps mitigate the lock ordering bug described in b/387576826. In short, the rename operation can potentially move DirEntry nodes around the tree hierarchy. Since lock ordering assumes a strict parent-to-child lock order, moving nodes around the tree can result in false-positives for the mutex tracing graph. The mitigation applied here is to offload the gating of non-empty directories to the filesystem itself. This is arguably where the check should belong in the first place, and has the added benefit of removing the need for the DirEntry algorithm to obtain a lock on the children of the node which we are unlinking. This change adds a unittest to cover the above scenario. I've also renamed "child" in the algorithm to instead be "child_to_unlink," which I hope makes the code more readable. Original-Bug: b/387576826 Test: Locally validated, added a unittest, and CQ. Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1206709 Original-Revision: bcfe56cb6cb16be4f1cb8f28fe0809aa8af80156 GitOrigin-RevId: 216e587760899e1e2a1e932810fc262112a2928c Change-Id: Id95fb11ba4b6020bda51bd54877f41be574e2449
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance in one of the communication channels documented at get involved.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.