)]}'
{
  "commit": "976f404c29de014d75362ba160e56c75447b0940",
  "tree": "f61464e8f6ad2547524b498824def56f757a9019",
  "parents": [
    "804e87326941f90db3252cf81ed43ad77f5cdc86"
  ],
  "author": {
    "name": "Gary Bressler",
    "email": "geb@fuchsia.infra.roller.google.com",
    "time": "Thu Apr 15 00:16:48 2021 +0000"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed Apr 14 17:17:36 2021 -0700"
  },
  "message": "[roll] Roll fuchsia [component_manager] Fix destroy/create race\n\nThis fixes a bug in component manager that can cause a created component\nto be incorrectly deleted if it was created just after another component\nwith the same name was deleted.\n\nTo be precise, the race is as follows:\n1) Client calls DestroyChild.\n2) component_manager schedules a DeleteChild action\n3) DestroyChild returns.\n4) Client calls CreateChild, with the same instance name.\n5) Instance is created.\n6) The DeleteChild action from #2 executes. It starts by scheduling a\n   MarkDeleted action, which incorrectly marks the new instance deleted.\n\nThe solution is for DeleteChild not to call MarkDeleted. Instead, code\nthat handles instance destruction must explicitly call MarkDeleted\nfirst.\n\nThis bug was causing `ffx session restart` to sometimes error with\nCreateComponentFailed (which actually was an error of failing to bind to\nthe session component).\n\nTested: Manually verified the fix works with `session_control`. Added an\nintegration test which should flake if the issue is present. Unit test\nchecks that MarkDeleted is not rescheduled.\n\nMultiply: destruction_integration_test: 200\nOriginal-Fixed: 41967\nOriginal-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/511284\nOriginal-Revision: 7a9ff485698894b49aebadbc6f66f0c14cedc934\nGitOrigin-RevId: da23478f5bf8a21cec85d1a1695a25d72788127a\nChange-Id: I2af1e1e2f8ab3ac657d5113d03936e2e5c835e2b\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "707f04259ca19545dad5f3a83f96b5691fd2acd7",
      "old_mode": 33188,
      "old_path": "stem",
      "new_id": "eadde90f502bc8de7e9fd625305c3e5b609f3ecc",
      "new_mode": 33188,
      "new_path": "stem"
    }
  ]
}
