| commit | 9560ccc701acebeb98757f3e85a2955c6af9b737 | [log] [tgz] |
|---|---|---|
| author | David Worsham <dworsham@fuchsia.infra.roller.google.com> | Sat Aug 28 02:58:52 2021 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Aug 27 20:00:14 2021 -0700 |
| tree | c15a7a4d0a16ff876869f2d48b083084bb159609 | |
| parent | df6096228e3d338efd0d662f373620de0b05d4a4 [diff] |
[roll] Roll fuchsia [flutter] Fix View lifetime & raciness FuchsiaViewsService.createView() should only ever be called once during a platform view's lifetime. Since it was gated on the async "view connected" event it could easily be called multiple times, and in a racy way. Similarly, the FuchsiaViewsService.destroy() should only ever be called once during a platform view's lifetime. connect/disconnect events should be bracketed by the create() and destroy() calls. A connect or disconnect event can only occur once in a view's lifetime. Once a view is disconnected, nothing can be done with it other than relasing the resources with dispose(). This CL fixes these lifetime bugs so a platform view moves through a well-defined lifetime of: create->connected->update->disconnected->destroyed Test: fx test --host fuchsia_scenic_flutter_unittests Original-Bug: b/195794362 Original-Bug: 82998 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/574521 Original-Revision: 5353335d972f891c4eada4b61b30fa6bc4e29e19 GitOrigin-RevId: 580eb08c129779f4263a58be6a391d2946a2840e Change-Id: I8045ba7eca56c3ee93765fffdae589420e3988b4
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.