[roll] Roll fuchsia [fidlc] Use ZX_ASSERT macros instead of C assert

This CL changes all fidlc source to use ZX_ASSERT, ZX_ASSERT_MSG, and
ZX_PANIC from zircon/assert.h instead of the C assert macro. Note that
these macros are explicitly supported on non-Zircon platforms, relying
only on __zx_panic defined in //zircon/system/ulib/zx-panic-libc.

The motivation is that assert() gets compiled out in release mode, but
this is not desirable for most fidlc assertions:

* Performance is generally not a concern. There are much lower hanging
  fruit for improving fidlc performance should we need to.

* The codebase is not hardened enough to warrant these optimizations. We
  not infrequently find bugs from tripped assertions.

* Conditionally compiled code is harder to reason about. It's common to
  accidentally perform a side effect in the expression and then see CQ
  failures in release mode.

* Assertions often mark an unreachable point, but when compiled out we
  need a bogus return, or __builtin_unreachable() which asks the
  compiler for UB. It's usually better to abort even in release mode.

With the ZX macros, assertions are always-on by default but we can
always change some to ZX_DEBUG_ASSERT if we need to for performance.
Another benefit is they are more expressive, e.g. ZX_PANIC is more
direct than asserting false, and messages allow printf interpolations.

This CL also removes prefixes like "compiler bug: " that were in some
assertion messages, since they are redundant (an assertion failure is by
definition a bug in the compiler).

Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/684062
Original-Revision: 8094c39317997adc23b3d4dedf982490e0f7ee06
GitOrigin-RevId: 9866e41eaac5cf3db4e67503a0ee9fb67908593b
Change-Id: Ie15777790328296cb5cea07ae8f084356d4a2853