| commit | 828ac02cc812fd67f269bb8a97044e161d28d2d4 | [log] [tgz] |
|---|---|---|
| author | Sam Balana <sbalana@fuchsia.infra.roller.google.com> | Wed Apr 30 14:48:47 2025 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Apr 30 14:50:33 2025 -0700 |
| tree | 93a6b8f799553b21f8e9f295ba80501e1295423b | |
| parent | 017b6a7619db1c2fd1670deebe1238bdd1e95451 [diff] |
[roll] Roll fuchsia Revert "[fidl][cpp] Move function bodies out of natural & driver headers" This reverts commit 1e6091f5dd7faf9e09c252b37a633f4eacbb633f. Reason for revert: Failing core.x64-asan-cxx_consistency-build_only consistently Original change's description: > [fidl][cpp] Move function bodies out of natural & driver headers > > This moves almost all function bodies out of generated bindings headers > for natural bindings and both flavours of driver transport bindings. > This means that they're only evaluated and compiled once per build > (modulo toolchain, subbuild, etc). Because these headers are very widely > included this has an impact on the build time for many compilation > units. The remaining function bodies mostly just constexpr functions > associated with bits and enum types. > > I compared compile times for one of the slower targets in our C++ build, > src/connectivity/bluetooth/hci/transport/uart/bt_transport_uart.cc and > it reduced the compile time (averaged measured with hyperfine) from an > average of 40.5s to 19.0s, a 53% speedup. > > There were some microbenchmark regressions but they were largely in the > setup and teardown parts steps and in benchmarks that don't represent > what's heavily used in production. > > Original-Bug: 361634289 > > Change-Id: I7085c18fe75c3d14c2ffbd90c3fc7437fefaf9f4 > Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1260904 > Commit-Queue: Ian McKellar <ianloic@google.com> > Reviewed-by: Aaron Wood <aaronwood@google.com> Original-Bug: 361634289 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1264784 Original-Revision: 0ff33a38d4f6d003dfbfdc1ca13a3897e37c0230 GitOrigin-RevId: 6574ac775a8ffa01b2ff705ee88524fcb927c182 Change-Id: Ic924f9cc7c273de5e8d2bacb90bf4c883ba20187
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance in one of the communication channels documented at get involved.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.