| commit | 68e468dae89dea236a7d41f156c53c38da09f37e | [log] [tgz] |
|---|---|---|
| author | Mitchell Kember <mkember@fuchsia.infra.roller.google.com> | Sat Mar 23 01:52:32 2024 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Mar 22 18:56:26 2024 -0700 |
| tree | 10d86d638fb5ab1912adb63c81c63da7bf28373b | |
| parent | 2ce29255b6f3e400d648b60ef8a07801c18c728f [diff] |
[roll] Roll fuchsia [fidlc] Remove reserved members from IR This removes `reserved` table/union/overlay members from the JSON IR. It also removes some other unused member properties such as "offset", "size", "alignment", "max_out_of_line", and "maybe_default_value". Removing `reserved` members simplifies a lot of code, because reserved members were skipped nearly everywhere. This also made it possible to make Type and Name required fields (not pointers) in types.go. The only place that relied on reserved members was coding tables in fidlgen_hlcpp. This was easy to change. A side effect the change is that union coding tables no longer have NULLs for trailing reserved members. This makes no difference; they never should have in the first place. This also means reserved members (and their doc comments, if any) will no longer show up in fidldoc like before. Documenting reserved members was specifically requested before (https://fxbug.dev/42155620), but we are likely going to completely remove `reserved` fields from the FIDL language (https://fxbug.dev/330609159). The "offset", "size", "alignment", and "max_out_of_line" properties belong on typeshape/fieldshape. For some reason they were also on table/union/overlay members directly, unused. That is what I removed. The "maybe_default_value" on table members was unused because we never implemented it. Struct default members are deprecated, and we never intend to support table default members. Test: fx test fidlc-test Test: fx check-goldens fidl Original-Fixed: 42067060 Original-Bug: 330609159, 42155620 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1006659 Original-Revision: 6c82d21beff5351623f45b9cec628a97a4534a81 GitOrigin-RevId: d7372a5c98d7b6768abf8689e1611e06d31bf9d2 Change-Id: I47bc755e9edbd0708f6d0fda572e8747960702d9
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.