| commit | 63ef1331d80b7b6d39d1d2759d10f30f50313a83 | [log] [tgz] |
|---|---|---|
| author | Brandon Castellano <bcastell@fuchsia.infra.roller.google.com> | Mon Feb 05 22:23:30 2024 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Feb 05 14:25:00 2024 -0800 |
| tree | e8db46c284e28651fdd0e417e5c1022dd412bc92 | |
| parent | 15af17232e6e8bb9af6f95ec839b553c48108881 [diff] |
[roll] Roll fuchsia [sdk][vfs] Reduce visibility of existing Node methods Hide as many possible public methods in the existing SDK VFS by making them protected, in preparation for landing the replacement SDK VFS. This allows removing these methods entirely from the new SDK VFS, and greatly simplifies the public interfaces in the SDK VFS as a whole. Most of this functionality will be handled by the in-tree VFS in the replacement library, and should not form a part of the SDK API. Instead callers should use the fuchsia.io protocol or type-specific methods where possible. Most of these methods were not used outside of connection handling, so changes to calling code is relatively minor: - `Node::Lookup()` is now only accessible via `vfs::PseudoDir` as this was the only place it was used (we can make it part of a common interface in the future should it be required by `vfs::LazyDir`) - `ReadAt()`/`WriteAt()` has been removed from the `File` interface as this functionality is already provided through fuchsia.io - Provide borrowed access to the VMO backing a `vfs::VmoFile` to compensate for in-tree callers requiring `ReadAt()` functionality - Remove `Node::IsDirectory()` and `Node::IsRemote()` from public interface (these were being incorrectly used to verify the concrete type of a node) Original-Bug: b/293936429 Test: vfs_cpp_tests vfs_cpp_new_tests Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/986272 Original-Revision: d66a8596007fdab277287777b6ade57828a0eb40 GitOrigin-RevId: 5421165af4c3dc42d96411bb39e7f37bb00b6ca2 Change-Id: I22d99f2b58b5ba2f29e5f3c6462ee3fa110db5c2
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.