| commit | 5f8562fdbfbafdfb57ab33d4634d4f4bcfb785e6 | [log] [tgz] |
|---|---|---|
| author | Miguel Flores Ruiz de Eguino <miguelfrde@fuchsia.infra.roller.google.com> | Fri Feb 28 12:20:34 2025 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Feb 28 12:22:19 2025 -0800 |
| tree | 14b9d281c475ac682ad11ee6717fe78a86a59c85 | |
| parent | 8f18960aff126fae4222dcb0b362956d15d771c0 [diff] |
[roll] Roll fuchsia [power][broker] Remove "unset" values when adding elements
The way the code was structured was leading to emitting unnecessary
events when adding a new element to the topology. When we add a new
element we always know its initial and required level, so we can omit
initializing the element with "unset" and exexcuting two updates to its
metadata fields in inspect.
I think there's likely additional opportunities for improvement and
simplification of these codepaths.
With this CL we now get:
```
{
event: "add_vertex",
vertex_id: ${element_id},
@time: ${time_seconds},
meta: {
current_level: "${initial_level}",
required_level: "${min_level}",
}
}
```
Before we got:
```
{
event: "add_vertex",
vertex_id: ${element_id},
@time: ${time_seconds},
meta: {
current_level: "unset",
required_level: "unset",
}
}
{
event: "update_key",
vertex_id: ${element_id},
key: "current_level",
update: ${initial_level},
@time: ${time_seconds}
}
{
event: "update_key",
vertex_id: ${element_id},
key: "required_level",
update: ${initial_level},
@time: ${time_seconds}
}
```
Original-Fixed: 398008841
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1215304
Original-Revision: 230cfa012b58a28d766fe801047982d5ad255521
GitOrigin-RevId: 49b34510dd737aeaf030c5c132084b62ea940302
Change-Id: Ide8a3da797740457b25c5a3003295fe7f39185c7
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance in one of the communication channels documented at get involved.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.