[roll] Roll fuchsia Revert "[sys] Bring cm_fidl_validator validations into cmc"

This reverts commit 0c96e453523ac8f048119e32458de946184e73f8.

Reason for revert: Reverting in order to revert commit
48b8a1b5d04d64d0fefb1bf846b9ed65522b6509 which is causing issues
on the tricium bots.

Original change's description:
> [sys] Bring cm_fidl_validator validations into cmc
>
> This way we:
>
> - Can share validation logic between compile time and run time.
> - Can catch errors earlier during the `cmc` run.
> - Have a place to write validation rules which need to operate on the
>   FIDL `Component` type. For example, a validation rule may need to look
>   at all the `ExposeDecl`s after expanding out the source/target cross
>   product in case of aggregation.
>
> Doing so surfaced two classes of errors:
>
> - stop_timeout_ms's doc says it's optional, but our impl requires it iff
>   the environment extends `none`. I updated the doc and tests.
> - cmc does not fill in `source_instance_filter` in OfferService, yet our
>   backend validator checks that that table field is always present. I'm
>   not sure what should be the right behavior here. The FIDL
>   documentation says `source_instance_filter` is optional, so I removed
>   the always-present check from cm_fidl_validator.
>
> A bigger/open question is whether we should move more and more
> validation from `cml` into `cm_fidl_validator`, deduplicating them in
> the process. Reducing LOCs is attractive but we need to ensure:
>
> - The `cm_fidl_validator` can be converted into a `cmc` error and
>   rendered in a way that is meaningful and helpful to the users.
> - We need to have a path to track line numbers late into the FIDL
>   translation phase.
>
> Run-All-Tests: True
> Cq-Include-Trybots: luci.turquoise.global.try:run-postsubmit-tryjobs
>
> Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/857616

Cq-Include-Trybots: luci.turquoise.global.try:run-postsubmit-tryjobs
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/859045
Original-Revision: ab319f4fab78f5cb3402cb395ec032627a82140d
GitOrigin-RevId: 1fd951b3484826d0fa2938c4100ea130545873ed
Change-Id: I032d880cb88292076c064f08a9de02e8dcfad63c
1 file changed
tree: 1563a08ef4ad3208600d243dfbb3a291780ae057
  1. git-hooks/
  2. infra/
  3. third_party/
  4. cts
  5. firmware
  6. flower
  7. jiri.lock
  8. MILESTONE
  9. minimal
  10. prebuilts
  11. README.md
  12. stem
  13. test_durations
  14. toolchain
README.md

Integration

This repository contains Fuchsia's Global Integration manifest files.

Making changes

All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.

Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.

Obtaining the source

First install Jiri.

Next run:

$ jiri init
$ jiri import minimal https://fuchsia.googlesource.com/integration
$ jiri update

Third party

Third party projects should have their own subdirectory in ./third_party.