[roll] Roll fuchsia [fidlc] Use ASSERT_NO_FAILURES instead of ASSERT_NO_FATAL_FAILURE

This CL changes fidlc tests to use ASSERT_NO_FAILURES instead of
ASSERT_NO_FATAL_FAILURES. The latter failed to give accurate line
numbers when the body used EXPECT instead of ASSERT.

Background: we prefer writing complex custom assertions as functions
rather than macros (which are error-prone and cause code bloat).
However, this leads to failures reporting line numbers inside the
function, not the call site. To fix this, we define a macro that wraps
the call in ASSERT_NO_*. The ASSERT_NO_FATAL_FAILURE macro only catches
ASSERT failures, while ASSERT_NO_FAILURES also catches EXPECT. We could
try to remember never to use EXPECT in a helper function, but it's
simpler to just use ASSERT_NO_FAILURES.

(Note: currently the zxtest ASSERT_NO_* macros are incorrectly scoped to
the entire test rather than the provided expression: fxbug.dev/100674.)

Test: fx test fidl-compiler
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/683131
Original-Revision: cb11bf86f40852d926ba0906deb1ecdd67857512
GitOrigin-RevId: 4f7fc11966cc2d41cfe4513f2414088e26fbb95b
Change-Id: If6a799b26ceb962ec214db4f7cd65c6bd4ccacdd
1 file changed
tree: 27e63a05071daa9cc5d71cf84f3b3e93671fc03f
  1. infra/
  2. third_party/
  3. cts
  4. firmware
  5. flower
  6. jiri.lock
  7. minimal
  8. prebuilts
  9. README.md
  10. stem
  11. test_durations
  12. toolchain
README.md

Integration

This repository contains Fuchsia's Global Integration manifest files.

Making changes

All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.

Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.

Obtaining the source

First install Jiri.

Next run:

$ jiri init
$ jiri import minimal https://fuchsia.googlesource.com/integration
$ jiri update

Third party

Third party projects should have their own subdirectory in ./third_party.