| commit | 358bf489bd131a4ddf99c0a346c5f93c91b151d2 | [log] [tgz] |
|---|---|---|
| author | Victor Costan <costan@fuchsia.infra.roller.google.com> | Tue Feb 25 17:44:20 2025 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Feb 25 17:47:24 2025 -0800 |
| tree | 6d4aff489f43d11833ef82a7e3b0c9b411ca6717 | |
| parent | 599a31877dbdc8aadbf474541293fb7585ea4dd9 [diff] |
[roll] Roll fuchsia [display][coordinator] Make IdMappable ID immutable and private. We hope to remove IdMappable in the long term. However, for the short-to-medium term, we'll probably have to live with it. This CL addresses the biggest issues in IdMappable -- the data member that serves as the map key is both public and mutable. 1. Public data members go against the C++ style guide. 2. Most map implementations (including the ones in fbl) assume that an object's key remains immutable while the object is inserted in the map. Making the map key immutable is a straightforward way to ensure that the assumption above is true. Having an immutable data member makes the IdMappable class non-copyable and non-movable. The C++ style guide requires stating these aspects explicitly. Original-Bug: 336394440 Test: fx test //src/graphics/display Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1211122 Original-Revision: 37f444decd03c1c931efa719f41971d7a72d53c8 GitOrigin-RevId: 7a92ba6e7e09e24bd40158a261eaae78b290bfed Change-Id: Ic2a19e240e8cff97a8edd533232274670420193d
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance in one of the communication channels documented at get involved.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.