| commit | 3045631d6450cb90ecea384ea20d03bb532779a2 | [log] [tgz] |
|---|---|---|
| author | Mukesh Agrawal <quiche@fuchsia.infra.roller.google.com> | Fri May 10 22:14:35 2024 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri May 10 15:15:30 2024 -0700 |
| tree | 6481e7f70bbddad5fda493fa88717716a8ad68a6 | |
| parent | e00d24a4a6a4b7abbce70f79aafd3f2a6c08faa4 [diff] |
[roll] Roll fuchsia [sdk][fidl] add comment to fuchsia.hardware.power.SagElement When searching for a list of SAG elements, I was confused by the `SagElement` enum. I thought the enum specified all of the SAG elements. That turns out not to be the purpose of the `SagElement` enum. Rather, the enum is meant to be used by clients of the power support library. (In retrospect, `fuchsia.hardware.power` does suggest something driver-specific.) To help my future self, add a comment explaining the purpose of `SagElement`. Alternatively: we could add the currently missing element to the enum. But that has a couple of problems: 1. It invites driver authors to use the enum value, although that value isn't supported by the power support library. 2. It creates a maintenance burden, if/when we add additional elements to SAG. Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1046092 Original-Revision: 616382c1ac3bedb1665c9f778d4bb087d220ead7 GitOrigin-RevId: 21832843e6e2926a90c322743d6530d9b7a1b763 Change-Id: I0a936f11077d236cfe822f608476f6d45f43268a
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.