| commit | 26974d029bffac4eac48ddbad5931b3966aa32aa | [log] [tgz] |
|---|---|---|
| author | Mitchell Kember <mkember@fuchsia.infra.roller.google.com> | Wed Apr 17 16:58:47 2024 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Apr 17 10:00:26 2024 -0700 |
| tree | f698daae238ac69f8af667bc59f4b875f01241b4 | |
| parent | c266c8f827a6f5e7da975462aad93ddce9b970f1 [diff] |
[roll] Roll fuchsia [fidlc] Parameterize versioning tests
This changes versioning_{basic,overlap,replacement}_tests.cc to
parameterize tests by target version using GoogleTest's TEST_P feature:
https://google.github.io/googletest/advanced.html#value-parameterized-tests
This makes tests a lot shorter and easier to read/write. Previously
tests either used loops, repeated the setup code for every version, or
(mostly "Bad" tests) only tested with one target version.
I also added helpers HasStruct etc. corresponding to LookupStruct etc.
to make the EXPECT_EQ assertions easier to read.
This is a follow up to I970a0978ccfd9b00a5b8036b81afdc13c1c8536a which
broke versioning_tests.cc into smaller files.
Test: fx test fidlc-test
Test: manually made test fail and observed version param in test output
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1029972
Original-Revision: 9e67162bba2fbbad5fabc5d4adba2562cf74c729
GitOrigin-RevId: 602f1f883ed5c8fc78129e9d06e00fd51cc46fb4
Change-Id: I04d06f60ef2e14098b0499b0d40f1a0a4edd965e
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.