| commit | 1fcf93c6e732f22c1d39479c8d5672a5e1311d72 | [log] [tgz] |
|---|---|---|
| author | Peter Johnston <peterjohnston@fuchsia.infra.roller.google.com> | Thu May 09 18:25:39 2024 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu May 09 11:27:03 2024 -0700 |
| tree | 09e15d0e7fb86fc587eae8b175560a97c8d87bb9 | |
| parent | b056d1d91ebaa87360de25b52a3a52179a59a2aa [diff] |
[roll] Roll fuchsia [netstack3] Use raw parsing for transport header
Currently, when dealing with an incoming packet, the filtering crate
fully parses the transport header in order to extract source and
destination ports for inspection. This ends up doing a lot of
unnecessary work, in particular to verify the transport layer checksum,
which can be very expensive when done repeatedly on all packets (as
happens if there are any ingress filtering rules that match on
transport-layer fields).
Instead of doing full parsing, use the "raw parsing" facilities from
packet-formats to only parse the fixed portion of the transport header,
which is enough to extract the ports, and is much cheaper.
In the future, we could consider caching the result of this parsing (for
example, by storing it as a field on `RxPacket` and introducing a
wrapper type for `Ipv{4,6}Packet` that similarly stores it) so that raw
parsing is not repeated for every call to IpPacket::transport_packet.
Test: netstack3-filter-test
netstack-filter-fidl-tests
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1044977
Original-Revision: 9638431f2d00c5eee3701671bc298d89e4781cf3
GitOrigin-RevId: 8a079627a5738f4582cc98ff9be7a469af85208b
Change-Id: I1d3c4f06805a3c5147a828e7d2fa1441ecf05098
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.