| commit | 172d9dbfefdbb3f3999c0ee9b5b9c81c2fbf0d7f | [log] [tgz] |
|---|---|---|
| author | Bruno Dal Bo <brunodalbo@fuchsia.infra.roller.google.com> | Wed Aug 23 15:30:38 2023 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Aug 23 08:32:17 2023 -0700 |
| tree | dc063f15c97f761cecf3f2c944ee028d6eec7a3d | |
| parent | e8209516ac4f1d4cba9f9414006146e9c6bc34ae [diff] |
[roll] Roll fuchsia [netstack3] Simplify ifaces admin task spawning Interfaces admin request stream handler was a stream that yielded tasks to be polled on by the main netstack services loop. This complex dance allowed subtasks created from a fuchsia.net.interfaces.admin/Installer handler to live beyond the future that polled the Installer request stream. Lifting that possibility and joining the Installer future on all its spawned subtasks substantially simplifies the code with the small drawback of slightly increased memory utilization related to that future. The future itself at this commit is only 152 bytes. Any overhead associated with ForEachConcurrent from the outer loop and interfaces_admin::serve itself is likely to be even smaller than that. This simplification also reduces complexity for the goal of clean shutdown in tests and follows the pattern used in the socket provider stream handlers. This also removes the last dependency on anyhow from the Netstack3 binary target, cleanup the last test usage as well and get rid of the dep while I'm here. Original-Bug: 132457 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/905949 Original-Revision: d88eb78d57bb5c44e65f0be6d35e09b8afcb88a3 GitOrigin-RevId: 576580dec46af3798a0cf09773a12f908055327e Change-Id: If5036db04dba9fd6538adaba368642c1638d4cd6
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.