| commit | 11e7e9c4216572730de9dcd7df51644b78024258 | [log] [tgz] |
|---|---|---|
| author | Oliver Newman <olivernewman@fuchsia.infra.roller.google.com> | Tue Jun 03 14:47:10 2025 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jun 03 14:48:10 2025 -0700 |
| tree | 6da82bda3dcd155fabad1e2fc7e0e1cad3ce5fae | |
| parent | 2de6068d928b7acf15e42d93645fed13d289d027 [diff] |
[roll] Roll infra/recipes [cherry_pick] Fix Gerrit URL
Fixes a bug in commit 8c5000bcd94d0ecb23dbcc3f028811a865d556c0.
Bug mechanism:
1. `api.gerrit.host_from_remote_url()` returns a scheme-less hostname.
2. `urlparse()` assumes that passed-in URLs have schemes, and returns
a `netloc` of None if the URL doesn't have a scheme.
3. Passing `gerrit_host=None` into the gerrit recipe module causes it to
fall back to the default Gerrit host for the build (computed based on
the triggering commit), which for cherry-pick builder runs is always
turquoise-internal-review.googlesource.com, which is incorrect when
cherry-picking a fuchsia CL.
To fix this, we just stop doing a `urlparse` when passing in the Gerrit
host, since the gerrit recipe module internally normalizes the host
already.
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/1291484
Original-Revision: 3ac00c9649317378e679dedc8091f9b814b7e150
GitOrigin-RevId: 0619c9b652581ed3dbd83af6cd2e3e2528087d57
Change-Id: If321b7f99fb575b4fdd9fa5e8d6049b7d223adbf
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance in one of the communication channels documented at get involved.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.