[roll] Roll fuchsia Reland "[fs-management] Remove overly broad data_deps" This reverts commit 18c411d112365e17fa9455ac0ae16a97a69f9180. Reason for revert: added missing data_deps to flaky test to fix the issue Original change's description: > Revert "[fs-management] Remove overly broad data_deps" > > This reverts commit 42d77e42f2a36b767bdb4653033d1e4422b47e91. > > Reason for revert: Failures in large-fs-tests on core.arm64-asan-slow and core.x64-asan-slow in CI. > > Original change's description: > > [fs-management] Remove overly broad data_deps > > > > This will unblock relanding fxr/501360 > > > > The fs-management lib can be used to call the following tools: > > * blobfs > > * minfs > > * fsck-msdosfs > > * mkfs-msdosfs > > * factoryfs > > * fatfs > > > > Previously this lib would add data_deps on the first four of the > > tools above, but not on the latter two (bug?). > > However most users of this lib only need just blobfs, or just > > minfs, or both. A small minority also need the msdosfs tools. > > Not sure which ones need factoryfs or fatfs, but they dep on those > > directly rather than take them through the library target. > > > > The upside of removing these transitive deps and adding them as > > direct deps where they're used is that fewer unused binaries end > > up in system assemblies. > > The downside is that using this library now requires some extra > > care. Although admittedly this was already the case. > > > > A potential improvement could be to break up this library into > > smaller targets that are oriented around each one of the tools that > > may be invoked, then give each such target the data_deps on the > > underlying tool. > > > > FWIW the Rust equivalent of this lib, at > > //src/lib/storage/fs_management/rust, doesn't have any such data > > deps at all. /shrug > > > > Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/507699 > > TBR=abdulla@google.com,shayba@google.com,auradkar@google.com,sdemos@google.com,csuter@google.com > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/509381 # Not skipping CQ checks because this is a reland. Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/509803 Original-Revision: 3476b7b253786f6fef7413ed4d41f46fc71cebb6 GitOrigin-RevId: 3abf79b3aead8ca2841541b6565a971d05682d58 Change-Id: I0dcb962854b97d2d5a97f7709e003d3557e01a73
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.