| commit | 0e26cf239ad5aa13efeb23f7cb2bc6d2235de58a | [log] [tgz] |
|---|---|---|
| author | Adam Barth <abarth@fuchsia.infra.roller.google.com> | Thu Feb 22 19:08:45 2024 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Feb 22 11:09:56 2024 -0800 |
| tree | c5f69497bee5ae49566ab4956f11517da89ee22b | |
| parent | ad49b7204cc4e7b02a5478d0e7862e948de8e191 [diff] |
[roll] Roll fuchsia [starnix][OWNERS] Remove input_pipeline OWNERS There have been a number of incorrectly reviewed CLs to these files from the input_pipeline OWNERS. It's important the Starnix kernel code is reviewed accurately because of the large impact that subtle bugs in this code can have on the entire system. Examples: (1) https://fuchsia-review.googlesource.com/c/fuchsia/+/944836 We should not test user address for null in order to return EFAULT. It's the memory manager's job to return EFAULT in these situations. (2) https://fuchsia-review.googlesource.com/c/fuchsia/+/945376 We should not use `expect` to handle incorrect arguments from userspace because that would let userspace crash the entire Starnix kernel. Instead, we should return the appropriate errno. In this case, the memory manager already generates the appropriate errno. This code should just use the `?` operator to forward it to userspace. Issue (1) caused a flaky test. Issue (2) was caught by a syscall fuzzer. These are both very expensive ways to catch these errors. Instead, we should catch these kinds of errors during code review. Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/994957 Original-Revision: e6f1d2349f787f4ca1cd40c831e442ba709551ea GitOrigin-RevId: e41082b0d198cf7f829a260f2e03f0d965c03d26 Change-Id: If95a34ca2118240f58f71c117a394e9878d2fd1a
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.