[roll] Roll fuchsia [fidlc] Migrate remaining tests to ASSERT_COMPILER_DIAGNOSTICS

This is a continuation of I4fabf94e8b2550d67b176fab42d5e12a9f361062,
migrating all remaining fidlc tests to use ExpectFail and
ASSERT_COMPILER_DIAGNOSTICS.

The motivation is that I'm refactoring some error reporting for the
implementation of RFC-0231, and this is much easier with the ExpectFail
system because it asserts errors based on their final sorted order, not
based on the order they were encountered during compilation.

Some other changes:

* Made tests with loops use SCOPED_TRACE to include the library in error
  messages rather than passing it to each assertion.

* Added assertion in TestLibrary destructor to ensure that tests don't
  forget to make an assertion on the library. This caught a few tests
  that weren't doing anything.

Test: fx test fidlc-test
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/950759
Original-Revision: 0d2133ed5b822a6ebc8a2ecd082d3b279a1753d6
GitOrigin-RevId: ae5e415baf6e07a839fb46ac95b018671dc89e77
Change-Id: I62488699289fcd5dcb6e794a41e68fb1a44b5e1b
1 file changed
tree: ba8cece27aacf7aa0cf7407565d1cf3ab72f3a04
  1. git-hooks/
  2. infra/
  3. third_party/
  4. cts
  5. firmware
  6. flower
  7. jiri.lock
  8. MILESTONE
  9. minimal
  10. prebuilts
  11. README.md
  12. stem
  13. test_durations
  14. toolchain
README.md

Integration

This repository contains Fuchsia's Global Integration manifest files.

Making changes

All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.

Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.

Obtaining the source

First install Jiri.

Next run:

$ jiri init
$ jiri import minimal https://fuchsia.googlesource.com/integration
$ jiri update

Third party

Third party projects should have their own subdirectory in ./third_party.