| commit | 035d0c8edde9dd3109d6c090c26afe30b65da77d | [log] [tgz] |
|---|---|---|
| author | Megan Batty <mgnb@fuchsia.infra.roller.google.com> | Thu Jun 23 19:01:15 2022 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Jun 23 12:04:25 2022 -0700 |
| tree | 6aaf19b3be8a0105a5c1cb5067514267a487e5e4 | |
| parent | 5a151cc3f971215aa0b8aab59811551cc1de9f11 [diff] |
[roll] Roll fuchsia [ffx][config] Separate nested ops from value maps This breaks up the logic around doing nested gets/sets/removes from the logic that does mapping and string interpolation on leaf Value files. In the process, it removes the currying and cons-ish recursion of the mapping functions, in favour of a more rust-y helper trait nested_map that you can call on either an Option<Value> or a ConfigValue, and then call with another mapping function. I think it's really nice that this puts the order of the value mapping operations in linear instead of reverse order to how they actually run. I think it makes the code much less confusing. The various nested_* things get moved again, this time to their own module, as they no longer perform mapping operations (other than NestedMap::nested_map, but I think it belongs with the other nested functions). Some of this restructuring may be useful to create a better starting point for resolving fxb/101249, but this CL is not intended to fix that on its own. Another minor inclusion is adding a file processing argument to the ffx-config-get arguments, which proved useful in finding the last problems with this CL. Original-Bug: 101249 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/690544 Original-Revision: 92935392aa828972a3d4f5bcd6aba261ed768907 GitOrigin-RevId: 72ae4d88b8a4b0a28d87f36519369b89823427f2 Change-Id: Ia8ccd9fbd6f635325cf907833b7ef2ba86a02877
This repository contains Fuchsia's Global Integration manifest files.
All changes should be made to the internal version of this repository. Our infrastructure automatically updates this version when the internal one changes.
Currently all changes must be made by a Google employee. Non-Google employees wishing to make a change can ask for assistance via the IRC channel #fuchsia on Freenode.
First install Jiri.
Next run:
$ jiri init $ jiri import minimal https://fuchsia.googlesource.com/integration $ jiri update
Third party projects should have their own subdirectory in ./third_party.