| commit | c49ef4fb99d78cd1cd2eda8999778d25d40ed1d6 | [log] [tgz] |
|---|---|---|
| author | Oliver Newman <olivernewman@google.com> | Wed Oct 26 21:44:27 2022 +0000 |
| committer | releases-try-builder <releases-try-builder@fuchsia-infra.iam.gserviceaccount.com> | Thu Oct 27 08:46:13 2022 +0000 |
| tree | dc81c817e9464e030b8eb70f70e6992976a0e688 | |
| parent | cb1b45beb82b0a9fda89e39d0dfdb5adc727fcd6 [diff] |
[ctf_artifacts] Avoid passing sdk_id="None"
Cherry Pick Reason: The same bug is blocking cherry picks to Fuchsia's releases/f9 branch.
The resolved `release_version` might be None if the build was not
triggered by an integration.git commit, e.g. when triggered in
fuchsia.git CQ. Previously we would still convert it to a string
("None") and pass it into GN as the `sdk_id` arg, for which "None" is an
invalid value that would break the build, e.g.
https://ci.chromium.org/b/8799756477028251905
Now we'll skip the release version resolution process entirely if the
build is not triggered by an integration.git commit. I also added an
extra defensive check to not convert release_version to a string if it's
None.
Change-Id: I5bdbd7524e8f63265f3e786c4cb82a5594fa2e32
Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/745242
Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com>
Reviewed-by: Kendal Harland <kjharland@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
(cherry picked from commit 70efff5e0a6be0953e9d009823947c8a5d178da3)
This repository contains recipes for Fuchsia.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Fuchsia in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Fuchsia in your local environment.
See go/fuchsia-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with jiri. A recipe will not run without vpython and cipd, and using these recommended jiri manifests will ensure that you have these tools.
You can use the fuchsia infra Jiri manifest or the internal version (Googlers-only). Once that manifest is imported in your local jiri manifest, jiri update should download vpython and cipd into <JIRI ROOT>/fuchsia-infra/prebuilt/tools/. If you add that directory to your PATH, you should be good to go.
If you're just trying to make a single small change to in this repository and already have your local environment set up for recipe development (e.g. because you work with another recipes repository) you can simply clone this repository with git:
git clone https://fuchsia.googlesource.com/infra/recipes
Then it will be up to you to ensure that vpython and cipd are available in your PATH.
We format python code using Black, an open-source Python autoformatter. It should be in your PATH if you followed the instructions for setting up your environment.
After committing recipe changes, you can format the files in your commit by running black . in your project root.
Many editors also have a setting to run Black automatically whenever you save a Python file (or on a keyboard shortcut). For VS Code, add the following to your workspace settings.json to make your editor compatible with Black and turn on auto-formatting on save:
{ "python.formatting.provider": "black", "python.formatting.blackPath": "<absolute path to the black executable>", "[python]": { "editor.formatOnSave": true, "editor.rulers": [88], // Black enforces a line length of 88 characters. }, ... }