commit | a5e10bc98322feaddc29265c18d009c5dace9c9c | [log] [tgz] |
---|---|---|
author | Oliver Newman <olivernewman@google.com> | Wed Mar 26 14:52:51 2025 -0700 |
committer | releases-prod-builder <releases-prod-builder@fuchsia-infra.iam.gserviceaccount.com> | Wed Mar 26 22:05:22 2025 +0000 |
tree | 5a1521367402208947ca9b8e37c877f6b58a887b | |
parent | 599c13c68056b3d5529f0ec2af37a2a9f8843640 [diff] |
[sdk] Skip nonexistent branches when resolving CIPD refs We intentionally include a nonexistent branch corresopnding to the next milestone in the `ref_settings` for canary SDK builds so that the settings will be correct once the branch is created with no need for cherry-picks. This was fine up until now because the only builds that triggered with nonexistent branches in `ref_settings` were on the canary branch, and the canary branch just happened to be listed first in `ref_settings`. However, now we've added another branch at the end of `ref_settings` that triggers builds, so when passing over the next milestone branch we would fail to process it, for example: https://ci.chromium.org/b/8719311835597979057 So make sure not to fail if the branch doesn't exist, and instead proceed to check other branches. Bug: 406038575 Change-Id: Iba047a4277229f639187ac551c525fa209405035 Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/1236209 Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com> Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com> Reviewed-by: Ina Huh <ihuh@google.com> (cherry picked from commit 8dd189ddad76e150d25e228adb4b96983aaeba02)
This repository contains recipes for Fuchsia.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Fuchsia in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Fuchsia in your local environment.
See go/fuchsia-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with jiri. A recipe will not run without vpython
and cipd
, and using these recommended jiri manifests will ensure that you have these tools.
You can use the fuchsia infra Jiri manifest or the internal version (Googlers-only). Once that manifest is imported in your local jiri manifest, jiri update
should download vpython
and cipd
into <JIRI ROOT>/fuchsia-infra/prebuilt/tools/
. If you add that directory to your PATH, you should be good to go.
If you're just trying to make a single small change to in this repository and already have your local environment set up for recipe development (e.g. because you work with another recipes repository) you can simply clone this repository with git:
git clone https://fuchsia.googlesource.com/infra/recipes
Then it will be up to you to ensure that vpython
and cipd
are available in your PATH.
We format python code using Black, an open-source Python autoformatter. It should be in your PATH if you followed the instructions for setting up your environment.
After committing recipe changes, you can format the files in your commit by running black .
in your project root.
Many editors also have a setting to run Black automatically whenever you save a Python file (or on a keyboard shortcut). For VS Code, add the following to your workspace settings.json
to make your editor compatible with Black and turn on auto-formatting on save:
{ "python.formatting.provider": "black", "python.formatting.blackPath": "<absolute path to the black executable>", "[python]": { "editor.formatOnSave": true, "editor.rulers": [88], // Black enforces a line length of 88 characters. }, ... }