commit | f84059610b3a9c738f2ea6cf26beb38da39073b6 | [log] [tgz] |
---|---|---|
author | Rob Mohr <mohrr@google.com> | Tue May 14 19:18:57 2024 +0000 |
committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue May 14 19:18:57 2024 +0000 |
tree | 683aa021ac3287682a63e069a326698180ebcc67 | |
parent | 90e3ab68be17bc2496e7e5d39a7e269acc4aed39 [diff] |
[gerrit_auto_submit] Ignore autogenerated comments Auto-submit won't retrigger CQ on changes that haven't been recently touched by a human. It did this by looking for comments that weren't by the auto-submit service account or didn't have the specific tags used by CQ/CV. Change that so auto-submit now ignores all autogenerated tags, not just those set by CQ/CV. (Auto-submit itself and other builders have been updated to include these tags already.) Then, instead of giving up when the most recent x messages are by auto-submit, give up when no human has interacted with the change in 36 hours. Bug: b/339023785 Change-Id: Ie1ce7942acd71c265130f59472cddd4a4d347f8c Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/1047394 Fuchsia-Auto-Submit: Rob Mohr <mohrr@google.com> Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com> Reviewed-by: Oliver Newman <olivernewman@google.com>
This repository contains recipes for Fuchsia.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Fuchsia in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Fuchsia in your local environment.
See go/fuchsia-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with jiri. A recipe will not run without vpython
and cipd
, and using these recommended jiri manifests will ensure that you have these tools.
You can use the fuchsia infra Jiri manifest or the internal version (Googlers-only). Once that manifest is imported in your local jiri manifest, jiri update
should download vpython
and cipd
into <JIRI ROOT>/fuchsia-infra/prebuilt/tools/
. If you add that directory to your PATH, you should be good to go.
If you're just trying to make a single small change to in this repository and already have your local environment set up for recipe development (e.g. because you work with another recipes repository) you can simply clone this repository with git:
git clone https://fuchsia.googlesource.com/infra/recipes
Then it will be up to you to ensure that vpython
and cipd
are available in your PATH.
We format python code using Black, an open-source Python autoformatter. It should be in your PATH if you followed the instructions for setting up your environment.
After committing recipe changes, you can format the files in your commit by running black .
in your project root.
Many editors also have a setting to run Black automatically whenever you save a Python file (or on a keyboard shortcut). For VS Code, add the following to your workspace settings.json
to make your editor compatible with Black and turn on auto-formatting on save:
{ "python.formatting.provider": "black", "python.formatting.blackPath": "<absolute path to the black executable>", "[python]": { "editor.formatOnSave": true, "editor.rulers": [88], // Black enforces a line length of 88 characters. }, ... }