tree c3c78c7b789387c1fc91c4d8edb87644fca5e147
parent 2a09cc3b093c1c3a53e7c102bbeeebf6186c8613
author Oliver Newman <olivernewman@google.com> 1604086348 +0000
committer CQ Bot <commit-bot@chromium.org> 1604086348 +0000

[sdk] Improve log for missing subbuild output property

Theoretically, if an SDK subbuild fails to finish, and thus doesn't set
the isolated output hash property for the orchestrator to read, the
subbuild's status should not be successful, which would cause the
orchestrator to fail before trying to read any output properties.
However, crbug.com/1116249 is a bbagent bug that causes a step to fail
and end the build early, even while the overall build turns green.

To better handle this (and the general case where there's a bug in the
subbuild recipe and it doesn't set the output property), raise an
explicit message about the missing output property instead of failing
with an unclear ValueError (e.g. ci.chromium.org/b/8865062909937848576),
and apply the same message to similar failures in the fuchsia recipe.

Also start using status_check in all sdk recipe unit tests to make
assertions about the build status.

Fixed: 63233
Change-Id: I9ff1606b24d97c47496e553a946b18ad39316ae6
Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/445476
Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Reviewed-by: Anthony Fandrianto <atyfto@google.com>