| commit | c40309ff53bf0c7903b2b304d1a4fae9f7f4bdba | [log] [tgz] |
|---|---|---|
| author | Rob Mohr <mohrr@google.com> | Wed Dec 01 23:11:35 2021 +0000 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Dec 01 23:11:35 2021 +0000 |
| tree | 7ea2a5dc10c6702cd0b703e38d551fc1555b54cd | |
| parent | c2472b3480e4d3bb7bdeabfc7228341c7efa1150 [diff] |
[gerrit_auto_submit] Stop if limit hit, regardless of builder state There's already code to stop retrying auto-submit after the maximum number of attempts is met, using builder state. However, the builder state for individual commit hashes is periodically cleared, effectively resetting the number of attempts and letting auto-submit run all over again. Leave that logic in place, but also skip CLs where there hasn't been other activity recently. Specifically, if max_attempts is 4, and the most recent 4 messages are auto-submit triggering CQ+2, do not set CQ+2 again. This will keep auto-submit from trying a CL many times beyond max_attempts for weeks until somebody notices. Do this by grabbing all recent messages on the CL, filtering out the CQ service account, and then looking at whether the last message was posted by the auto-submit service account. If that message was part of a string of messages by the same SA with length max_attempts or greater, don't trigger CQ. Change-Id: Ic24049a4b7be5de842743c32cda8b9859970516c Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/612577 Reviewed-by: Oliver Newman <olivernewman@google.com> Commit-Queue: Rob Mohr <mohrr@google.com>
This repository contains recipes for Fuchsia.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Fuchsia in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Fuchsia in your local environment.
See go/fuchsia-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with jiri. A recipe will not run without vpython and cipd, and using these recommended jiri manifests will ensure that you have these tools.
You can use the fuchsia infra Jiri manifest or the internal version (Googlers-only). Once that manifest is imported in your local jiri manifest, jiri update should download vpython and cipd into <JIRI ROOT>/fuchsia-infra/prebuilt/tools/. If you add that directory to your PATH, you should be good to go.
If you're just trying to make a single small change to in this repository and already have your local environment set up for recipe development (e.g. because you work with another recipes repository) you can simply clone this repository with git:
git clone https://fuchsia.googlesource.com/infra/recipes
Then it will be up to you to ensure that vpython and cipd are available in your PATH.
We format python code using Black, an open-source Python autoformatter. It should be in your PATH if you followed the instructions for setting up your environment.
After committing recipe changes, you can format the files in your commit by running black . in your project root.
Many editors also have a setting to run Black automatically whenever you save a Python file (or on a keyboard shortcut). For VS Code, add the following to your workspace settings.json to make your editor compatible with Black and turn on auto-formatting on save:
{ "python.formatting.provider": "black", "python.formatting.blackPath": "<absolute path to the black executable>", "[python]": { "editor.formatOnSave": true, "editor.rulers": [88], // Black enforces a line length of 88 characters. }, ... }