| commit | 94d6dcd48fd9b4629bca498b3c76947292cba939 | [log] [tgz] |
|---|---|---|
| author | Anthony Fandrianto <atyfto@google.com> | Mon Dec 06 21:03:22 2021 +0000 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Dec 06 21:03:22 2021 +0000 |
| tree | 40f7e48f45d8198a7c1bab71229b9027fb11b045 | |
| parent | 5b2b94df5fc3aaca8dec79e78cc12d3c44a7c4f3 [diff] |
[fuchsia/build] Add ability to enforce size creep review If spec.build.size_creep_label is set, the recipe will now enforce size creep. The recipe returns a failure if: 1) One or more size creep budgets are exceeded, according to the size_diff tool 2) The review label spec.build.size_creep_label does not have approval (a +1 vote) The Gerrit comment will also indicate the review label which needs to be set in order to unblock. If spec.build.size_creep_label is not set, there is no behavioral change here i.e. size creep budgets remain non-blocking. Bug: 85953 Change-Id: I24774ab2d0c6a46b7e3b7abb8b8aed404c4f4ca1 Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/614321 Reviewed-by: Oliver Newman <olivernewman@google.com> Commit-Queue: Anthony Fandrianto <atyfto@google.com> Fuchsia-Auto-Submit: Anthony Fandrianto <atyfto@google.com>
This repository contains recipes for Fuchsia.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Fuchsia in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Fuchsia in your local environment.
See go/fuchsia-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with jiri. A recipe will not run without vpython and cipd, and using these recommended jiri manifests will ensure that you have these tools.
You can use the fuchsia infra Jiri manifest or the internal version (Googlers-only). Once that manifest is imported in your local jiri manifest, jiri update should download vpython and cipd into <JIRI ROOT>/fuchsia-infra/prebuilt/tools/. If you add that directory to your PATH, you should be good to go.
If you're just trying to make a single small change to in this repository and already have your local environment set up for recipe development (e.g. because you work with another recipes repository) you can simply clone this repository with git:
git clone https://fuchsia.googlesource.com/infra/recipes
Then it will be up to you to ensure that vpython and cipd are available in your PATH.
We format python code using Black, an open-source Python autoformatter. It should be in your PATH if you followed the instructions for setting up your environment.
After committing recipe changes, you can format the files in your commit by running black . in your project root.
Many editors also have a setting to run Black automatically whenever you save a Python file (or on a keyboard shortcut). For VS Code, add the following to your workspace settings.json to make your editor compatible with Black and turn on auto-formatting on save:
{ "python.formatting.provider": "black", "python.formatting.blackPath": "<absolute path to the black executable>", "[python]": { "editor.formatOnSave": true, "editor.rulers": [88], // Black enforces a line length of 88 characters. }, ... }