| commit | 6bfb20e89763fa305957866216e0657c85856083 | [log] [tgz] |
|---|---|---|
| author | Oliver Newman <olivernewman@google.com> | Tue May 17 22:00:42 2022 +0000 |
| committer | Fuchsia Internal LUCI <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue May 17 22:00:42 2022 +0000 |
| tree | 6decf7cf85ea442508d188419bdb277279613060 | |
| parent | 2f17c5285c6609ffe9a77d32bce6d8128a878894 [diff] |
Revert "[build] Run all tests on recipe+integration changes" This reverts commit cd25399af28a943e0c3ca69b9c2796d49ebe7659. Reason for revert: missing a DEP, breaking builds: ci.chromium.org/b/8813883016510793089 Original change's description: > [build] Run all tests on recipe+integration changes > > We shouldn't skip affected tests (or shard them differently) on > integration.git or recipe changes, since the affected tests analysis > will generally not be correct on those changes. > > For recipes, this is because recipes are not part of the build system > and can affect the behavior of any part of a CI/CQ build. For > integration, this is because affected test analysis doesn't look at the > contents of Jiri project or package rolls. > > Change-Id: I0cf5e60c1bd31dbd20d720f98ab6d2513d6bb7f7 > Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/679361 > Reviewed-by: Ina Huh <ihuh@google.com> > Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com> > Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com> > Reviewed-by: Anirudh Mathukumilli <rudymathu@google.com> Change-Id: I5dc6f4589162db49c3759bd24039e027acf56c8e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/680546 Reviewed-by: RubberStamper 🤖 <android-build-ayeaye@system.gserviceaccount.com> Commit-Queue: Oliver Newman <olivernewman@google.com>
This repository contains recipes for Fuchsia.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Fuchsia in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Fuchsia in your local environment.
See go/fuchsia-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with jiri. A recipe will not run without vpython and cipd, and using these recommended jiri manifests will ensure that you have these tools.
You can use the fuchsia infra Jiri manifest or the internal version (Googlers-only). Once that manifest is imported in your local jiri manifest, jiri update should download vpython and cipd into <JIRI ROOT>/fuchsia-infra/prebuilt/tools/. If you add that directory to your PATH, you should be good to go.
If you're just trying to make a single small change to in this repository and already have your local environment set up for recipe development (e.g. because you work with another recipes repository) you can simply clone this repository with git:
git clone https://fuchsia.googlesource.com/infra/recipes
Then it will be up to you to ensure that vpython and cipd are available in your PATH.
We format python code using Black, an open-source Python autoformatter. It should be in your PATH if you followed the instructions for setting up your environment.
After committing recipe changes, you can format the files in your commit by running black . in your project root.
Many editors also have a setting to run Black automatically whenever you save a Python file (or on a keyboard shortcut). For VS Code, add the following to your workspace settings.json to make your editor compatible with Black and turn on auto-formatting on save:
{ "python.formatting.provider": "black", "python.formatting.blackPath": "<absolute path to the black executable>", "[python]": { "editor.formatOnSave": true, "editor.rulers": [88], // Black enforces a line length of 88 characters. }, ... }