| commit | 4c8dd8e2fb88824e4f87e61d9c1bef47245eb12a | [log] [tgz] |
|---|---|---|
| author | Oliver Newman <olivernewman@google.com> | Tue Jan 04 19:23:27 2022 +0000 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 04 19:23:27 2022 +0000 |
| tree | 47e615e3469adbaabc1c95385c118b656c540deb | |
| parent | 51df6dfc1db7fe563a933bbd676e502b71a0caa0 [diff] |
[git] Make get_changed_files return empty list if no files are changed Previously it would return a single-element list containing an empty string. This was rare but could happen if the function was called with `ignore_submodules=True` on a commit that only touched a submodule, leading to failures such as ci.chromium.org/b/8826578963573649841 where a build tries to treat an empty string as a file path. Also emit a JSON log instead of a newline-separated log to make it easier to distinguish between an empty list and a list that only contains empty strings. Change-Id: I1d0e100c26750a92b57c52d64b528237bfd177ad Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/626341 Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com> Reviewed-by: Anthony Fandrianto <atyfto@google.com> Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
This repository contains recipes for Fuchsia.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Fuchsia in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Fuchsia in your local environment.
See go/fuchsia-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with jiri. A recipe will not run without vpython and cipd, and using these recommended jiri manifests will ensure that you have these tools.
You can use the fuchsia infra Jiri manifest or the internal version (Googlers-only). Once that manifest is imported in your local jiri manifest, jiri update should download vpython and cipd into <JIRI ROOT>/fuchsia-infra/prebuilt/tools/. If you add that directory to your PATH, you should be good to go.
If you're just trying to make a single small change to in this repository and already have your local environment set up for recipe development (e.g. because you work with another recipes repository) you can simply clone this repository with git:
git clone https://fuchsia.googlesource.com/infra/recipes
Then it will be up to you to ensure that vpython and cipd are available in your PATH.
We format python code using Black, an open-source Python autoformatter. It should be in your PATH if you followed the instructions for setting up your environment.
After committing recipe changes, you can format the files in your commit by running black . in your project root.
Many editors also have a setting to run Black automatically whenever you save a Python file (or on a keyboard shortcut). For VS Code, add the following to your workspace settings.json to make your editor compatible with Black and turn on auto-formatting on save:
{ "python.formatting.provider": "black", "python.formatting.blackPath": "<absolute path to the black executable>", "[python]": { "editor.formatOnSave": true, "editor.rulers": [88], // Black enforces a line length of 88 characters. }, ... }