commit | 11bf566ef422611f599c26ade0552792d8e614b6 | [log] [tgz] |
---|---|---|
author | Anirudh Mathukumilli <rudymathu@google.com> | Thu Sep 22 18:27:26 2022 +0000 |
committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 22 18:27:26 2022 +0000 |
tree | ad1bd2d6e46b0b9b51698d8292a234a31d9eaf9e | |
parent | ca19f59bb1bd2d28abe31ee01e1fa1349dcfd14c [diff] |
Reland "Reland "[recipes] Enable build sandboxing"" This reverts commit f92d8841c1774bcc776c9247797e639a7283b213. Reason for revert: The issues caused by this CL were fixed by: 1. Removing usage of system python in the rust rbe determinism checker: https://fxrev.dev/728163 2. Correctly propagating exit codes from fint in dumb_init 3. Using shutil.which() to find the path of each necessary linux tool instead of hardcoding paths. Original change's description: > Revert "Reland "[recipes] Enable build sandboxing"" > > This reverts commit ff64f187b089e79ed11b1fb8bb4797b711d64da6. > > Reason for revert: consistent fint exits 0 but emits failure summary, which recipes dislike, on core.x64-asan-rust_determinism e.g. go/bbid/8802459357972934657 > > Original change's description: > > Reland "[recipes] Enable build sandboxing" > > > > This reverts commit 55f452f2f565e84192c1cf79729ca33543f6b37c. > > > > Reason for revert: We will mount the checkout read-write until we find a way to accommodate affected test analysis. > > > > Original change's description: > > > Revert "[recipes] Enable build sandboxing" > > > > > > This reverts commit 7f561dba7de9abad18aa8de9ab6e8144de395ed9. > > > > > > Reason for revert: Fint failures across all builders: https://chat.google.com/room/AAAABFiUm4o/CRZvOCF4T84 > > > > > > Original change's description: > > > > [recipes] Enable build sandboxing > > > > > > > > Starts running all fint commands (which invoke fuchsia builds) inside of > > > > an nsjail sandbox. > > > > > > > > Bug: b/243608142 > > > > Change-Id: I44a84dd21af0a5753315031569960a2999bbce71 > > > > Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/726050 > > > > Fuchsia-Auto-Submit: Anirudh Mathukumilli <rudymathu@google.com> > > > > Reviewed-by: Oliver Newman <olivernewman@google.com> > > > > Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com> > > > > > > Bug: b/243608142 > > > Change-Id: I5a35b9ef180568c2890886bb62c3761cbb0abebc > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/727642 > > > Reviewed-by: RubberStamper 🤖 <android-build-ayeaye@system.gserviceaccount.com> > > > Commit-Queue: Vinicius Felizardo <felizardo@google.com> > > > > Bug: b/243608142 > > Change-Id: I4bb59f7dfe6884276e5dea9d2c1a3ad1deda6087 > > Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/727680 > > Reviewed-by: Oliver Newman <olivernewman@google.com> > > Commit-Queue: Anirudh Mathukumilli <rudymathu@google.com> > > Fuchsia-Auto-Submit: Anirudh Mathukumilli <rudymathu@google.com> > > Bug: b/243608142 > Change-Id: Ic4c650ba30fefbf41c92b0d9b57a1774dd59f18c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/727157 > Commit-Queue: Drew Fisher <zarvox@google.com> > Reviewed-by: RubberStamper 🤖 <android-build-ayeaye@system.gserviceaccount.com> Bug: b/243608142 Change-Id: Ica83f722a7ca2887ca8738dd9e600b856a429416 Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/728202 Reviewed-by: Oliver Newman <olivernewman@google.com> Commit-Queue: Anirudh Mathukumilli <rudymathu@google.com> Fuchsia-Auto-Submit: Anirudh Mathukumilli <rudymathu@google.com>
This repository contains recipes for Fuchsia.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Fuchsia in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Fuchsia in your local environment.
See go/fuchsia-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with jiri. A recipe will not run without vpython
and cipd
, and using these recommended jiri manifests will ensure that you have these tools.
You can use the fuchsia infra Jiri manifest or the internal version (Googlers-only). Once that manifest is imported in your local jiri manifest, jiri update
should download vpython
and cipd
into <JIRI ROOT>/fuchsia-infra/prebuilt/tools/
. If you add that directory to your PATH, you should be good to go.
If you're just trying to make a single small change to in this repository and already have your local environment set up for recipe development (e.g. because you work with another recipes repository) you can simply clone this repository with git:
git clone https://fuchsia.googlesource.com/infra/recipes
Then it will be up to you to ensure that vpython
and cipd
are available in your PATH.
We format python code using Black, an open-source Python autoformatter. It should be in your PATH if you followed the instructions for setting up your environment.
After committing recipe changes, you can format the files in your commit by running black .
in your project root.
Many editors also have a setting to run Black automatically whenever you save a Python file (or on a keyboard shortcut). For VS Code, add the following to your workspace settings.json
to make your editor compatible with Black and turn on auto-formatting on save:
{ "python.formatting.provider": "black", "python.formatting.blackPath": "<absolute path to the black executable>", "[python]": { "editor.formatOnSave": true, "editor.rulers": [88], // Black enforces a line length of 88 characters. }, ... }