[sdk] Move SDK upload back to after companion images and not before

In an effort to modularize the core and Bazel SDK steps, I'd mistakenly
moved the uploads ahead of the companion image uploads, which breaks the
expectation of downstream users that the companion images are ready by
the time the core and/or Bazel SDK is uploaded and tagged in CIPD.

This change restores the uploads back to their ~original phase in
execution.

This change doesn't affect the GN SDK upload because it is effectively
unused aside from a script in fuchsia.googlesource.com/samples that does
not rely on companion images (see https://fxbug.dev/130260).

Bug: 49542
Change-Id: I1d4fc4ee891ce8afaf3ac1a74793e8caef4e10cd
Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/894138
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Anthony Fandrianto <atyfto@google.com>
Reviewed-by: Oliver Newman <olivernewman@google.com>
Reviewed-by: Michael Brase <mbrase@google.com>
7 files changed
tree: 6cc02a44c1cefae47fbe278626e6d6cbc0ad793d
  1. git-hooks/
  2. infra/
  3. manifest/
  4. recipe_modules/
  5. recipe_proto/
  6. recipes/
  7. scripts/
  8. .editorconfig
  9. .git-blame-ignore-revs
  10. .gitignore
  11. AUTHORS
  12. black.ensure
  13. LICENSE
  14. OWNERS
  15. PATENTS
  16. pyproject.toml
  17. README.md
  18. recipes.py
  19. shac.ensure
  20. shac.star
  21. shac.textproto
  22. TOOLCHAIN_OWNERS
README.md

Fuchsia Recipes

This repository contains recipes for Fuchsia.

A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Fuchsia in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Fuchsia in your local environment.

See go/fuchsia-recipe-docs for complete documentation and a guide for getting started with writing recipes.

Getting the code and setting up your environment

For everyday development

The recommended way to get the source code is with jiri. A recipe will not run without vpython and cipd, and using these recommended jiri manifests will ensure that you have these tools.

You can use the fuchsia infra Jiri manifest or the internal version (Googlers-only). Once that manifest is imported in your local jiri manifest, jiri update should download vpython and cipd into <JIRI ROOT>/fuchsia-infra/prebuilt/tools/. If you add that directory to your PATH, you should be good to go.

Quick changes

If you're just trying to make a single small change to in this repository and already have your local environment set up for recipe development (e.g. because you work with another recipes repository) you can simply clone this repository with git:

git clone https://fuchsia.googlesource.com/infra/recipes

Then it will be up to you to ensure that vpython and cipd are available in your PATH.

Code formatting

We format python code using Black, an open-source Python autoformatter. It should be in your PATH if you followed the instructions for setting up your environment.

After committing recipe changes, you can format the files in your commit by running black . in your project root.

Many editors also have a setting to run Black automatically whenever you save a Python file (or on a keyboard shortcut). For VS Code, add the following to your workspace settings.json to make your editor compatible with Black and turn on auto-formatting on save:

{
    "python.formatting.provider": "black",
    "python.formatting.blackPath": "<absolute path to the black executable>",
    "[python]": {
        "editor.formatOnSave": true,
        "editor.rulers": [88], // Black enforces a line length of 88 characters.
    },
    ...
}