| commit | 5dce2907007b3bbee580b3c9f55ce9aa2dc1ed80 | [log] [tgz] |
|---|---|---|
| author | Mark Seaborn <mseaborn@google.com> | Fri Jun 14 18:39:56 2024 +0000 |
| committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 14 18:39:56 2024 +0000 |
| tree | 83c9528443c25be2e29e23ac191ca124f468b3ab | |
| parent | c7b186c7433c111e10c9c9b75f308599ff337cac [diff] |
Revert "[fuchsia] Pass "--expected_sample_size" to perfcompare.py as consistency check" This reverts commit 52aa1eee9d52942f9182bc6a1526c5ab6fd51c9a. Reason for revert: This introduced failures on a couple of internal builders. Apparently the CQ did not test those builders for this recipes change. Original change's description: > [fuchsia] Pass "--expected_sample_size" to perfcompare.py as consistency check > > This will apply when displaying the table of performance results for > perfcompare and non-perfcompare builds. This tells perfcompare.py to > check that the number of results for each metric (the sample size) > matches the recipe's runs_per_shard parameter. > > This is intended to catch cases where tests improperly get run more > than once. > > Bug: 343997506 > Run-All-Tests: True > Change-Id: Id4c97c2a82680270a7d81075def8c53c804a1725 > Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/1058660 > Reviewed-by: Oliver Newman <olivernewman@google.com> > Reviewed-by: Gwen Mittertreiner <gmtr@google.com> > Commit-Queue: Mark Seaborn <mseaborn@google.com> Bug: 343997506 Change-Id: Icbb692095f6c881435121f6b83fe4518660e162a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/1066411 Reviewed-by: Gwen Mittertreiner <gmtr@google.com> Reviewed-by: Oliver Newman <olivernewman@google.com> Commit-Queue: Mark Seaborn <mseaborn@google.com>
This repository contains recipes for Fuchsia.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Fuchsia in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Fuchsia in your local environment.
See go/fuchsia-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with jiri. A recipe will not run without vpython and cipd, and using these recommended jiri manifests will ensure that you have these tools.
You can use the fuchsia infra Jiri manifest or the internal version (Googlers-only). Once that manifest is imported in your local jiri manifest, jiri update should download vpython and cipd into <JIRI ROOT>/fuchsia-infra/prebuilt/tools/. If you add that directory to your PATH, you should be good to go.
If you're just trying to make a single small change to in this repository and already have your local environment set up for recipe development (e.g. because you work with another recipes repository) you can simply clone this repository with git:
git clone https://fuchsia.googlesource.com/infra/recipes
Then it will be up to you to ensure that vpython and cipd are available in your PATH.
We format python code using Black, an open-source Python autoformatter. It should be in your PATH if you followed the instructions for setting up your environment.
After committing recipe changes, you can format the files in your commit by running black . in your project root.
Many editors also have a setting to run Black automatically whenever you save a Python file (or on a keyboard shortcut). For VS Code, add the following to your workspace settings.json to make your editor compatible with Black and turn on auto-formatting on save:
{ "python.formatting.provider": "black", "python.formatting.blackPath": "<absolute path to the black executable>", "[python]": { "editor.formatOnSave": true, "editor.rulers": [88], // Black enforces a line length of 88 characters. }, ... }