tree ad1bd2d6e46b0b9b51698d8292a234a31d9eaf9e
parent ca19f59bb1bd2d28abe31ee01e1fa1349dcfd14c
author Anirudh Mathukumilli <rudymathu@google.com> 1663871246 +0000
committer CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> 1663871246 +0000

Reland "Reland "[recipes] Enable build sandboxing""

This reverts commit f92d8841c1774bcc776c9247797e639a7283b213.

Reason for revert: The issues caused by this CL were fixed by:
1. Removing usage of system python in the rust rbe determinism checker: https://fxrev.dev/728163
2. Correctly propagating exit codes from fint in dumb_init
3. Using shutil.which() to find the path of each necessary linux tool
   instead of hardcoding paths.

Original change's description:
> Revert "Reland "[recipes] Enable build sandboxing""
>
> This reverts commit ff64f187b089e79ed11b1fb8bb4797b711d64da6.
>
> Reason for revert: consistent fint exits 0 but emits failure summary, which recipes dislike, on core.x64-asan-rust_determinism e.g. go/bbid/8802459357972934657
>
> Original change's description:
> > Reland "[recipes] Enable build sandboxing"
> >
> > This reverts commit 55f452f2f565e84192c1cf79729ca33543f6b37c.
> >
> > Reason for revert: We will mount the checkout read-write until we find a way to accommodate affected test analysis.
> >
> > Original change's description:
> > > Revert "[recipes] Enable build sandboxing"
> > >
> > > This reverts commit 7f561dba7de9abad18aa8de9ab6e8144de395ed9.
> > >
> > > Reason for revert: Fint failures across all builders: https://chat.google.com/room/AAAABFiUm4o/CRZvOCF4T84
> > >
> > > Original change's description:
> > > > [recipes] Enable build sandboxing
> > > >
> > > > Starts running all fint commands (which invoke fuchsia builds) inside of
> > > > an nsjail sandbox.
> > > >
> > > > Bug: b/243608142
> > > > Change-Id: I44a84dd21af0a5753315031569960a2999bbce71
> > > > Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/726050
> > > > Fuchsia-Auto-Submit: Anirudh Mathukumilli <rudymathu@google.com>
> > > > Reviewed-by: Oliver Newman <olivernewman@google.com>
> > > > Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
> > >
> > > Bug: b/243608142
> > > Change-Id: I5a35b9ef180568c2890886bb62c3761cbb0abebc
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/727642
> > > Reviewed-by: RubberStamper 🤖 <android-build-ayeaye@system.gserviceaccount.com>
> > > Commit-Queue: Vinicius Felizardo <felizardo@google.com>
> >
> > Bug: b/243608142
> > Change-Id: I4bb59f7dfe6884276e5dea9d2c1a3ad1deda6087
> > Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/727680
> > Reviewed-by: Oliver Newman <olivernewman@google.com>
> > Commit-Queue: Anirudh Mathukumilli <rudymathu@google.com>
> > Fuchsia-Auto-Submit: Anirudh Mathukumilli <rudymathu@google.com>
>
> Bug: b/243608142
> Change-Id: Ic4c650ba30fefbf41c92b0d9b57a1774dd59f18c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/727157
> Commit-Queue: Drew Fisher <zarvox@google.com>
> Reviewed-by: RubberStamper 🤖 <android-build-ayeaye@system.gserviceaccount.com>

Bug: b/243608142
Change-Id: Ica83f722a7ca2887ca8738dd9e600b856a429416
Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/728202
Reviewed-by: Oliver Newman <olivernewman@google.com>
Commit-Queue: Anirudh Mathukumilli <rudymathu@google.com>
Fuchsia-Auto-Submit: Anirudh Mathukumilli <rudymathu@google.com>