| commit | 00865b56165ff7aa065b97663cddda0f412ffc55 | [log] [tgz] |
|---|---|---|
| author | Oliver Newman <olivernewman@google.com> | Thu Jun 13 18:09:18 2024 +0000 |
| committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 13 18:09:18 2024 +0000 |
| tree | c650b737dff19b780e9365020cb4befdbf7ac368 | |
| parent | 87f2af38c464203abf4462fa495c00706c3cf3a9 [diff] |
[git] Only check last paragraph of commit msg footers Previously we would consider any line in a commit message as a candidate to contain a footer like `Change-Id`. However, this differs from the officially documented meaning of a footer in git, which is a footer that appears in the last paragraph of the commit message. This was causing roll-comment to mistakenly skip commenting on some CLs because a footer before the last paragraph matched one of the footers for which it skips commenting. For example, http://tqr/852048 was a roll of a fuchsia CL (https://fxrev.dev/1065552) and so the fuchsia CL should have had a roll comment added to it, but it didn't because the integration CL contained a `GitOrigin-RevId` footer, but *before* the last paragraph. The roll commenter skips commits with this footer because it indicates Copybara commits that won't have a corresponding Gerrit CL to comment on, but that's only the case of the footer appears in the last paragraph. This should cause the roll-commenter to start commenting on these types of changes. Change-Id: I588adf2e3d2b85f8c7f0f7458e7219cf34dcbc41 Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/1065812 Fuchsia-Auto-Submit: Oliver Newman <olivernewman@google.com> Reviewed-by: Danielle Kay <danikay@google.com> Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
This repository contains recipes for Fuchsia.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Fuchsia in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Fuchsia in your local environment.
See go/fuchsia-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with jiri. A recipe will not run without vpython and cipd, and using these recommended jiri manifests will ensure that you have these tools.
You can use the fuchsia infra Jiri manifest or the internal version (Googlers-only). Once that manifest is imported in your local jiri manifest, jiri update should download vpython and cipd into <JIRI ROOT>/fuchsia-infra/prebuilt/tools/. If you add that directory to your PATH, you should be good to go.
If you're just trying to make a single small change to in this repository and already have your local environment set up for recipe development (e.g. because you work with another recipes repository) you can simply clone this repository with git:
git clone https://fuchsia.googlesource.com/infra/recipes
Then it will be up to you to ensure that vpython and cipd are available in your PATH.
We format python code using Black, an open-source Python autoformatter. It should be in your PATH if you followed the instructions for setting up your environment.
After committing recipe changes, you can format the files in your commit by running black . in your project root.
Many editors also have a setting to run Black automatically whenever you save a Python file (or on a keyboard shortcut). For VS Code, add the following to your workspace settings.json to make your editor compatible with Black and turn on auto-formatting on save:
{ "python.formatting.provider": "black", "python.formatting.blackPath": "<absolute path to the black executable>", "[python]": { "editor.formatOnSave": true, "editor.rulers": [88], // Black enforces a line length of 88 characters. }, ... }