/*
 * Copyright (c) 2005-2011 Atheros Communications Inc.
 * Copyright (c) 2011-2014 Qualcomm Atheros, Inc.
 *
 * Permission to use, copy, modify, and/or distribute this software for any
 * purpose with or without fee is hereby granted, provided that the above
 * copyright notice and this permission notice appear in all copies.
 *
 * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
 * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
 * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
 * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
 * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
 * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

// The way how macros in wmi.h and wmi-tlv.h are working (read carefully how MSG() is defined before
// ath10k_msg_type and how ATH10K_MSG_TYPE_WMI is *referred* in wmi.h) is that the .c code must
// include the msg_buf.h. Then the msg_buf.h will include wmi.h and wmi-tlv.h to expand the macros
// properly. TODO(NET-1237): Cleanup ath10k msg_buf
#include "msg_buf.h"

#include <inttypes.h>

#include <zircon/status.h>

#include "core.h"
#include "debug.h"
#include "hw.h"
#include "mac.h"
#include "p2p.h"
#include "testmode.h"
#include "wmi-ops.h"

/***************/
/* TLV helpers */
/**************/

struct wmi_tlv_policy {
    size_t min_len;
};

static const struct wmi_tlv_policy wmi_tlv_policies[] = {
    // clang-format off
    [WMI_TLV_TAG_ARRAY_BYTE]
    = { .min_len = 0 },
    [WMI_TLV_TAG_ARRAY_UINT32]
    = { .min_len = 0 },
    [WMI_TLV_TAG_STRUCT_SCAN_EVENT]
    = { .min_len = sizeof(struct wmi_scan_event) },
    [WMI_TLV_TAG_STRUCT_MGMT_RX_HDR]
    = { .min_len = sizeof(struct wmi_tlv_mgmt_rx_ev) },
    [WMI_TLV_TAG_STRUCT_CHAN_INFO_EVENT]
    = { .min_len = sizeof(struct wmi_chan_info_event) },
    [WMI_TLV_TAG_STRUCT_VDEV_START_RESPONSE_EVENT]
    = { .min_len = sizeof(struct wmi_vdev_start_response_event) },
    [WMI_TLV_TAG_STRUCT_PEER_STA_KICKOUT_EVENT]
    = { .min_len = sizeof(struct wmi_peer_sta_kickout_event) },
    [WMI_TLV_TAG_STRUCT_HOST_SWBA_EVENT]
    = { .min_len = sizeof(struct wmi_host_swba_event) },
    [WMI_TLV_TAG_STRUCT_TIM_INFO]
    = { .min_len = sizeof(struct wmi_tim_info) },
    [WMI_TLV_TAG_STRUCT_P2P_NOA_INFO]
    = { .min_len = sizeof(struct wmi_p2p_noa_info) },
    [WMI_TLV_TAG_STRUCT_SERVICE_READY_EVENT]
    = { .min_len = sizeof(struct wmi_tlv_svc_rdy_ev) },
    [WMI_TLV_TAG_STRUCT_HAL_REG_CAPABILITIES]
    = { .min_len = sizeof(struct hal_reg_capabilities) },
    [WMI_TLV_TAG_STRUCT_WLAN_HOST_MEM_REQ]
    = { .min_len = sizeof(struct wlan_host_mem_req) },
    [WMI_TLV_TAG_STRUCT_READY_EVENT]
    = { .min_len = sizeof(struct wmi_tlv_rdy_ev) },
    [WMI_TLV_TAG_STRUCT_OFFLOAD_BCN_TX_STATUS_EVENT]
    = { .min_len = sizeof(struct wmi_tlv_bcn_tx_status_ev) },
    [WMI_TLV_TAG_STRUCT_DIAG_DATA_CONTAINER_EVENT]
    = { .min_len = sizeof(struct wmi_tlv_diag_data_ev) },
    [WMI_TLV_TAG_STRUCT_P2P_NOA_EVENT]
    = { .min_len = sizeof(struct wmi_tlv_p2p_noa_ev) },
    [WMI_TLV_TAG_STRUCT_ROAM_EVENT]
    = { .min_len = sizeof(struct wmi_tlv_roam_ev) },
    [WMI_TLV_TAG_STRUCT_WOW_EVENT_INFO]
    = { .min_len = sizeof(struct wmi_tlv_wow_event_info) },
    [WMI_TLV_TAG_STRUCT_TX_PAUSE_EVENT]
    = { .min_len = sizeof(struct wmi_tlv_tx_pause_ev) },
    // clang-format on
};

static zx_status_t ath10k_wmi_tlv_iter(struct ath10k* ar, const void* ptr, size_t len,
                                       int (*iter)(struct ath10k* ar, uint16_t tag, uint16_t len,
                                                   const void* ptr, void* data),
                                       void* data) {
    const void* begin = ptr;
    const struct wmi_tlv* tlv;
    uint16_t tlv_tag, tlv_len;
    zx_status_t ret;

    while (len > 0) {
        if (len < sizeof(*tlv)) {
            ath10k_dbg(ar, ATH10K_DBG_WMI,
                       "wmi tlv parse failure at byte %zd (%zu bytes left, %zu expected)\n",
                       ptr - begin, len, sizeof(*tlv));
            return ZX_ERR_OUT_OF_RANGE;
        }

        tlv = ptr;
        tlv_tag = tlv->tag;
        tlv_len = tlv->len;
        ptr += sizeof(*tlv);
        len -= sizeof(*tlv);

        if (tlv_len > len) {
            ath10k_dbg(
                ar, ATH10K_DBG_WMI,
                "wmi tlv parse failure of tag %hhu at byte %zd (%zu bytes left, %hhu expected)\n",
                tlv_tag, ptr - begin, len, tlv_len);
            return ZX_ERR_OUT_OF_RANGE;
        }

        if (tlv_tag < countof(wmi_tlv_policies) && wmi_tlv_policies[tlv_tag].min_len &&
            wmi_tlv_policies[tlv_tag].min_len > tlv_len) {
            ath10k_dbg(ar, ATH10K_DBG_WMI,
                       "wmi tlv parse failure of tag %hhu at byte %zd (%hhu bytes is less than min "
                       "length %zu)\n",
                       tlv_tag, ptr - begin, tlv_len, wmi_tlv_policies[tlv_tag].min_len);
            return ZX_ERR_OUT_OF_RANGE;
        }

        ret = iter(ar, tlv_tag, tlv_len, ptr, data);
        if (ret != ZX_OK) { return ret; }

        ptr += tlv_len;
        len -= tlv_len;
    }

    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_iter_parse(struct ath10k* ar, uint16_t tag, uint16_t len,
                                             const void* ptr, void* data) {
    const void** tb = data;

    if (tag < WMI_TLV_TAG_MAX) { tb[tag] = ptr; }

    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_parse(struct ath10k* ar, const void** tb, const void* ptr,
                                        size_t len) {
    return ath10k_wmi_tlv_iter(ar, ptr, len, ath10k_wmi_tlv_iter_parse, (void*)tb);
}

zx_status_t ath10k_wmi_tlv_parse_alloc(struct ath10k* ar, const void* ptr, size_t len,
                                       const void*** ptb) {
    const void** tb;
    int ret;

    tb = calloc(1, sizeof(*tb) * WMI_TLV_TAG_MAX);
    if (!tb) { return ZX_ERR_NO_MEMORY; }

    ret = ath10k_wmi_tlv_parse(ar, tb, ptr, len);
    if (ret != ZX_OK) {
        free(tb);
        return ret;
    }

    *ptb = tb;
    return ZX_OK;
}

static uint16_t ath10k_wmi_tlv_len(const void* ptr) {
    return (((const struct wmi_tlv*)ptr) - 1)->len;
}

#if 0   // NEEDS PORTING
/**************/
/* TLV events */
/**************/
static int ath10k_wmi_tlv_event_bcn_tx_status(struct ath10k* ar,
        struct sk_buff* skb) {
    const void** tb;
    const struct wmi_tlv_bcn_tx_status_ev* ev;
    struct ath10k_vif* arvif;
    uint32_t vdev_id, tx_status;
    int ret;

    tb = ath10k_wmi_tlv_parse_alloc(ar, skb->data, skb->len, GFP_ATOMIC);
    if (IS_ERR(tb)) {
        ret = PTR_ERR(tb);
        ath10k_warn("failed to parse tlv: %d\n", ret);
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_OFFLOAD_BCN_TX_STATUS_EVENT];
    if (!ev) {
        kfree(tb);
        return -EPROTO;
    }

    tx_status = ev->tx_status;
    vdev_id = ev->vdev_id;

    switch (tx_status) {
    case WMI_TLV_BCN_TX_STATUS_OK:
        break;
    case WMI_TLV_BCN_TX_STATUS_XRETRY:
    case WMI_TLV_BCN_TX_STATUS_DROP:
    case WMI_TLV_BCN_TX_STATUS_FILTERED:
        /* FIXME: It's probably worth telling mac80211 to stop the
         * interface as it is crippled.
         */
        ath10k_warn("received bcn tmpl tx status on vdev %i: %d",
                    vdev_id, tx_status);
        break;
    }

    arvif = ath10k_get_arvif(ar, vdev_id);
    if (arvif && arvif->is_up && arvif->vif->csa_active) {
        ieee80211_queue_work(ar->hw, &arvif->ap_csa_work);
    }

    kfree(tb);
    return 0;
}

static int ath10k_wmi_tlv_event_diag_data(struct ath10k* ar,
        struct sk_buff* skb) {
    const void** tb;
    const struct wmi_tlv_diag_data_ev* ev;
    const struct wmi_tlv_diag_item* item;
    const void* data;
    int ret, num_items, len;

    tb = ath10k_wmi_tlv_parse_alloc(ar, skb->data, skb->len, GFP_ATOMIC);
    if (IS_ERR(tb)) {
        ret = PTR_ERR(tb);
        ath10k_warn("failed to parse tlv: %d\n", ret);
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_DIAG_DATA_CONTAINER_EVENT];
    data = tb[WMI_TLV_TAG_ARRAY_BYTE];
    if (!ev || !data) {
        kfree(tb);
        return -EPROTO;
    }

    num_items = ev->num_items;
    len = ath10k_wmi_tlv_len(data);

    while (num_items--) {
        if (len == 0) {
            break;
        }
        if (len < sizeof(*item)) {
            ath10k_warn("failed to parse diag data: can't fit item header\n");
            break;
        }

        item = data;

        if (len < sizeof(*item) + item->len) {
            ath10k_warn("failed to parse diag data: item is too long\n");
            break;
        }

        trace_ath10k_wmi_diag_container(ar,
                                        item->type,
                                        item->timestamp,
                                        item->code,
                                        item->len,
                                        item->payload);

        len -= sizeof(*item);
        len -= ROUNDUP(item->len, 4);

        data += sizeof(*item);
        data += ROUNDUP(item->len, 4);
    }

    if (num_items != -1 || len != 0)
        ath10k_warn("failed to parse diag data event: num_items %d len %d\n",
                    num_items, len);

    kfree(tb);
    return 0;
}
#endif  // NEEDS PORTING

static zx_status_t ath10k_wmi_tlv_event_diag(struct ath10k* ar, struct ath10k_msg_buf* msg_buf) {
    const void** tb;
    const void* data;
    zx_status_t ret;
    int len;

    data = ath10k_msg_buf_get_payload(msg_buf);
    size_t msg_len = ath10k_msg_buf_get_payload_len(msg_buf, ATH10K_MSG_TYPE_WMI);
    ret = ath10k_wmi_tlv_parse_alloc(ar, data, msg_len, &tb);
    if (ret != ZX_OK) {
        ath10k_warn("failed to parse tlv: %s\n", zx_status_get_string(ret));
        return ret;
    }

    data = tb[WMI_TLV_TAG_ARRAY_BYTE];
    if (!data) {
        free(tb);
        return ZX_ERR_INVALID_ARGS;
    }
    len = ath10k_wmi_tlv_len(data);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv diag event len %d\n", len);

    free(tb);
    return ZX_OK;
}

#if 0   // NEEDS PORTING
static int ath10k_wmi_tlv_event_p2p_noa(struct ath10k* ar,
                                        struct sk_buff* skb) {
    const void** tb;
    const struct wmi_tlv_p2p_noa_ev* ev;
    const struct wmi_p2p_noa_info* noa;
    int ret, vdev_id;

    tb = ath10k_wmi_tlv_parse_alloc(ar, skb->data, skb->len, GFP_ATOMIC);
    if (IS_ERR(tb)) {
        ret = PTR_ERR(tb);
        ath10k_warn("failed to parse tlv: %d\n", ret);
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_P2P_NOA_EVENT];
    noa = tb[WMI_TLV_TAG_STRUCT_P2P_NOA_INFO];

    if (!ev || !noa) {
        kfree(tb);
        return -EPROTO;
    }

    vdev_id = ev->vdev_id;

    ath10k_dbg(ar, ATH10K_DBG_WMI,
               "wmi tlv p2p noa vdev_id %i descriptors %hhu\n",
               vdev_id, noa->num_descriptors);

    ath10k_p2p_noa_update_by_vdev_id(ar, vdev_id, noa);
    kfree(tb);
    return 0;
}
#endif  // NEEDS PORTING

static zx_status_t ath10k_wmi_tlv_event_tx_pause(struct ath10k* ar,
                                                 struct ath10k_msg_buf* msg_buf) {
    const void** tb;
    const struct wmi_tlv_tx_pause_ev* ev;
    zx_status_t ret;
    uint32_t pause_id, action, vdev_map, peer_id, tid_map;

    void* data = ath10k_msg_buf_get_payload(msg_buf);
    size_t len = ath10k_msg_buf_get_payload_len(msg_buf, ATH10K_MSG_TYPE_WMI);
    ret = ath10k_wmi_tlv_parse_alloc(ar, data, len, &tb);
    if (ret != ZX_OK) {
        ath10k_warn("failed to parse tlv: %s\n", zx_status_get_string(ret));
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_TX_PAUSE_EVENT];
    if (!ev) {
        free(tb);
        return ZX_ERR_INVALID_ARGS;
    }

    pause_id = ev->pause_id;
    action = ev->action;
    vdev_map = ev->vdev_map;
    peer_id = ev->peer_id;
    tid_map = ev->tid_map;

    ath10k_dbg(ar, ATH10K_DBG_WMI,
               "wmi tlv tx pause pause_id %u action %u vdev_map 0x%08x peer_id %u tid_map 0x%08x\n",
               pause_id, action, vdev_map, peer_id, tid_map);

#if 0   // NEEDS PORTING
    switch (pause_id) {
    case WMI_TLV_TX_PAUSE_ID_MCC:
    case WMI_TLV_TX_PAUSE_ID_P2P_CLI_NOA:
    case WMI_TLV_TX_PAUSE_ID_P2P_GO_PS:
    case WMI_TLV_TX_PAUSE_ID_AP_PS:
    case WMI_TLV_TX_PAUSE_ID_IBSS_PS:
        for (vdev_id = 0; vdev_map; vdev_id++) {
            if (!(vdev_map & BIT(vdev_id))) {
                continue;
            }

            vdev_map &= ~BIT(vdev_id);
            ath10k_mac_handle_tx_pause_vdev(ar, vdev_id, pause_id,
                                            action);
        }
        break;
    case WMI_TLV_TX_PAUSE_ID_AP_PEER_PS:
    case WMI_TLV_TX_PAUSE_ID_AP_PEER_UAPSD:
    case WMI_TLV_TX_PAUSE_ID_STA_ADD_BA:
    case WMI_TLV_TX_PAUSE_ID_HOST:
        ath10k_dbg(ar, ATH10K_DBG_MAC,
                   "mac ignoring unsupported tx pause id %d\n",
                   pause_id);
        break;
    default:
        ath10k_dbg(ar, ATH10K_DBG_MAC,
                   "mac ignoring unknown tx pause vdev %d\n",
                   pause_id);
        break;
    }
#endif  // NEEDS PORTING

    free(tb);
    return ZX_OK;
}

/***********/
/* TLV ops */
/***********/

static void ath10k_wmi_tlv_op_rx(struct ath10k* ar, struct ath10k_msg_buf* msg_buf) {
    struct wmi_cmd_hdr* cmd_hdr;
    enum wmi_tlv_event_id id;
    bool consumed;

    if (ath10k_msg_buf_get_payload_offset(ATH10K_MSG_TYPE_WMI) > msg_buf->used) { goto out; }

    msg_buf->type = ATH10K_MSG_TYPE_WMI;
    cmd_hdr = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI);
    id = MS(cmd_hdr->cmd_id, WMI_CMD_HDR_CMD_ID);

    consumed = ath10k_tm_event_wmi(ar, id, msg_buf);

    /* Ready event must be handled normally also in UTF mode so that we
     * know the UTF firmware has booted, others we are just bypass WMI
     * events to testmode.
     */
    if (consumed && id != WMI_TLV_READY_EVENTID) {
        ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv testmode consumed 0x%x\n", id);
        goto out;
    }

    switch (id) {
    case WMI_TLV_MGMT_RX_EVENTID:
        ath10k_wmi_event_mgmt_rx(ar, msg_buf);
        /* mgmt_rx() owns msg_buf now! */
        return;
    case WMI_TLV_SCAN_EVENTID:
        ath10k_wmi_event_scan(ar, msg_buf);
        break;
    case WMI_TLV_CHAN_INFO_EVENTID:
        ath10k_wmi_event_chan_info(ar, msg_buf);
        break;
    case WMI_TLV_ECHO_EVENTID:
        ath10k_wmi_event_echo(ar, msg_buf);
        break;
    case WMI_TLV_DEBUG_MESG_EVENTID:
        ath10k_err("WMI_TLV_DEBUG_MESG_EVENTID unimplemented\n");
        // ath10k_wmi_event_debug_mesg(ar, skb);
        break;
    case WMI_TLV_UPDATE_STATS_EVENTID:
        ath10k_err("WMI_TLV_UPDATE_STATS_EVENTID unimplemented\n");
        // ath10k_wmi_event_update_stats(ar, skb);
        break;
    case WMI_TLV_VDEV_START_RESP_EVENTID:
        ath10k_wmi_event_vdev_start_resp(ar, msg_buf);
        break;
    case WMI_TLV_VDEV_STOPPED_EVENTID:
        ath10k_wmi_event_vdev_stopped(ar, msg_buf);
        break;
    case WMI_TLV_PEER_STA_KICKOUT_EVENTID:
        ath10k_err("WMI_TLV_PEER_STA_KICKOUT_EVENTID unimplemented\n");
        // ath10k_wmi_event_peer_sta_kickout(ar, skb);
        break;
    case WMI_TLV_HOST_SWBA_EVENTID:
        ath10k_err("WMI_TLV_HOST_SWBA_EVENTID unimplemented\n");
        // ath10k_wmi_event_host_swba(ar, skb);
        break;
    case WMI_TLV_TBTTOFFSET_UPDATE_EVENTID:
        ath10k_err("WMI_TLV_TBTTOFFSET_UPDATE_EVENTID unimplemented\n");
        // ath10k_wmi_event_tbttoffset_update(ar, skb);
        break;
    case WMI_TLV_PHYERR_EVENTID:
        ath10k_err("WMI_TLV_PHYERR_EVENTID unimplemented\n");
        // ath10k_wmi_event_phyerr(ar, skb);
        break;
    case WMI_TLV_ROAM_EVENTID:
        ath10k_err("WMI_TLV_ROAM_EVENTID unimplemented\n");
        // ath10k_wmi_event_roam(ar, skb);
        break;
    case WMI_TLV_PROFILE_MATCH:
        ath10k_err("WMI_TLV_PROFILE_MATCH unimplemented\n");
        // ath10k_wmi_event_profile_match(ar, skb);
        break;
    case WMI_TLV_DEBUG_PRINT_EVENTID:
        ath10k_err("WMI_TLV_DEBUG_PRINT_EVENTID unimplemented\n");
        // ath10k_wmi_event_debug_print(ar, skb);
        break;
    case WMI_TLV_PDEV_QVIT_EVENTID:
        ath10k_err("WMI_TLV_PDEV_QVIT_EVENTID unimplemented\n");
        // ath10k_wmi_event_pdev_qvit(ar, skb);
        break;
    case WMI_TLV_WLAN_PROFILE_DATA_EVENTID:
        ath10k_err("WMI_TLV_WLAN_PROFILE_DATA_EVENTID unimplemented\n");
        // ath10k_wmi_event_wlan_profile_data(ar, skb);
        break;
    case WMI_TLV_RTT_MEASUREMENT_REPORT_EVENTID:
        ath10k_err("WMI_TLV_RTT_MEASUREMENT_REPORT_EVENTID unimplemented\n");
        // ath10k_wmi_event_rtt_measurement_report(ar, skb);
        break;
    case WMI_TLV_TSF_MEASUREMENT_REPORT_EVENTID:
        ath10k_err("WMI_TLV_TSF_MEASUREMENT_REPORT_EVENTID unimplemented\n");
        // ath10k_wmi_event_tsf_measurement_report(ar, skb);
        break;
    case WMI_TLV_RTT_ERROR_REPORT_EVENTID:
        ath10k_err("WMI_TLV_RTT_ERROR_REPORT_EVENTID unimplemented\n");
        // ath10k_wmi_event_rtt_error_report(ar, skb);
        break;
    case WMI_TLV_WOW_WAKEUP_HOST_EVENTID:
        ath10k_err("WMI_TLV_WOW_WAKEUP_HOST_EVENTID unimplemented\n");
        // ath10k_wmi_event_wow_wakeup_host(ar, skb);
        break;
    case WMI_TLV_DCS_INTERFERENCE_EVENTID:
        ath10k_err("WMI_TLV_DCS_INTERFERENCE_EVENTID unimplemented\n");
        // ath10k_wmi_event_dcs_interference(ar, skb);
        break;
    case WMI_TLV_PDEV_TPC_CONFIG_EVENTID:
        ath10k_err("WMI_TLV_PDEV_TPC_CONFIG_EVENTID unimplemented\n");
        // ath10k_wmi_event_pdev_tpc_config(ar, skb);
        break;
    case WMI_TLV_PDEV_FTM_INTG_EVENTID:
        ath10k_err("WMI_TLV_PDEV_FTM_INTG_EVENTID unimplemented\n");
        // ath10k_wmi_event_pdev_ftm_intg(ar, skb);
        break;
    case WMI_TLV_GTK_OFFLOAD_STATUS_EVENTID:
        ath10k_err("WMI_TLV_GTK_OFFLOAD_STATUS_EVENTID unimplemented\n");
        // ath10k_wmi_event_gtk_offload_status(ar, skb);
        break;
    case WMI_TLV_GTK_REKEY_FAIL_EVENTID:
        ath10k_err("WMI_TLV_GTK_REKEY_FAIL_EVENTID unimplemented\n");
        // ath10k_wmi_event_gtk_rekey_fail(ar, skb);
        break;
    case WMI_TLV_TX_DELBA_COMPLETE_EVENTID:
        ath10k_err("WMI_TLV_TX_DELBA_COMPLETE_EVENTID unimplemented\n");
        // ath10k_wmi_event_delba_complete(ar, skb);
        break;
    case WMI_TLV_TX_ADDBA_COMPLETE_EVENTID:
        ath10k_err("WMI_TLV_TX_ADDBA_COMPLETE_EVENTID unimplemented\n");
        // ath10k_wmi_event_addba_complete(ar, skb);
        break;
    case WMI_TLV_VDEV_INSTALL_KEY_COMPLETE_EVENTID:
        ath10k_wmi_event_vdev_install_key_complete(ar, msg_buf);
        break;
    case WMI_TLV_SERVICE_READY_EVENTID:
        ath10k_wmi_event_service_ready(ar, msg_buf);
        return;
    case WMI_TLV_READY_EVENTID:
        ath10k_wmi_event_ready(ar, msg_buf);
        break;
    case WMI_TLV_OFFLOAD_BCN_TX_STATUS_EVENTID:
        ath10k_err("WMI_TLV_OFFLOAD_BCN_TX_STATUS_EVENTID unimplemented\n");
        // ath10k_wmi_tlv_event_bcn_tx_status(ar, skb);
        break;
    case WMI_TLV_DIAG_DATA_CONTAINER_EVENTID:
        ath10k_err("WMI_TLV_DIAG_DATA_CONTAINER_EVENTID unimplemented\n");
        // ath10k_wmi_tlv_event_diag_data(ar, skb);
        break;
    case WMI_TLV_DIAG_EVENTID:
        ath10k_wmi_tlv_event_diag(ar, msg_buf);
        break;
    case WMI_TLV_P2P_NOA_EVENTID:
        ath10k_err("WMI_TLV_P2P_NOA_EVENTID unimplemented\n");
        // ath10k_wmi_tlv_event_p2p_noa(ar, skb);
        break;
    case WMI_TLV_TX_PAUSE_EVENTID:
        ath10k_wmi_tlv_event_tx_pause(ar, msg_buf);
        break;
    default:
        ath10k_warn("Unknown eventid: %#x\n", id);
        break;
    }

out:
    ath10k_msg_buf_free(msg_buf);
}

static zx_status_t ath10k_wmi_tlv_op_pull_scan_ev(struct ath10k* ar, struct ath10k_msg_buf* msg_buf,
                                                  struct wmi_scan_ev_arg* arg) {
    const void** tb;
    const struct wmi_scan_event* ev;
    zx_status_t ret;

    void* data = ath10k_msg_buf_get_payload(msg_buf);
    size_t len = ath10k_msg_buf_get_payload_len(msg_buf, ATH10K_MSG_TYPE_WMI);
    ret = ath10k_wmi_tlv_parse_alloc(ar, data, len, &tb);
    if (ret != ZX_OK) {
        ath10k_warn("failed to parse tlv: %s\n", zx_status_get_string(ret));
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_SCAN_EVENT];
    if (!ev) {
        free(tb);
        return ZX_ERR_INVALID_ARGS;
    }

    arg->event_type = ev->event_type;
    arg->reason = ev->reason;
    arg->channel_freq = ev->channel_freq;
    arg->scan_req_id = ev->scan_req_id;
    arg->scan_id = ev->scan_id;
    arg->vdev_id = ev->vdev_id;

    free(tb);
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_pull_mgmt_rx_ev(struct ath10k* ar,
                                                     struct ath10k_msg_buf* msg_buf,
                                                     struct wmi_mgmt_rx_ev_arg* arg) {
    const void** tb;
    const struct wmi_tlv_mgmt_rx_ev* ev;
    const uint8_t* frame;
    uint32_t msdu_len;

    void* data = ath10k_msg_buf_get_payload(msg_buf);
    size_t len = ath10k_msg_buf_get_payload_len(msg_buf, ATH10K_MSG_TYPE_WMI);
    zx_status_t ret = ath10k_wmi_tlv_parse_alloc(ar, data, len, &tb);
    if (ret != ZX_OK) {
        ath10k_warn("failed to parse tlv: %s\n", zx_status_get_string(ret));
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_MGMT_RX_HDR];
    frame = tb[WMI_TLV_TAG_ARRAY_BYTE];

    if (!ev || !frame) {
        free(tb);
        return ZX_ERR_INVALID_ARGS;
    }

    arg->channel = ev->channel;
    arg->buf_len = ev->buf_len;
    arg->status = ev->status;
    arg->snr = ev->snr;
    arg->phy_mode = ev->phy_mode;
    arg->rate = ev->rate;

    msdu_len = arg->buf_len;

    msg_buf->rx.frame_offset = frame - (uint8_t*)data;
    msg_buf->rx.frame_size = arg->buf_len;

    if (len < (msg_buf->rx.frame_offset + msdu_len)) {
        free(tb);
        return ZX_ERR_INVALID_ARGS;
    }

    free(tb);
    return ZX_OK;
}

#if 0   // NEEDS PORTING
static int ath10k_wmi_tlv_op_pull_ch_info_ev(struct ath10k* ar,
        struct sk_buff* skb,
        struct wmi_ch_info_ev_arg* arg) {
    const void** tb;
    const struct wmi_chan_info_event* ev;
    int ret;

    tb = ath10k_wmi_tlv_parse_alloc(ar, skb->data, skb->len, GFP_ATOMIC);
    if (IS_ERR(tb)) {
        ret = PTR_ERR(tb);
        ath10k_warn("failed to parse tlv: %d\n", ret);
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_CHAN_INFO_EVENT];
    if (!ev) {
        kfree(tb);
        return -EPROTO;
    }

    arg->err_code = ev->err_code;
    arg->freq = ev->freq;
    arg->cmd_flags = ev->cmd_flags;
    arg->noise_floor = ev->noise_floor;
    arg->rx_clear_count = ev->rx_clear_count;
    arg->cycle_count = ev->cycle_count;

    kfree(tb);
    return 0;
}
#endif  // NEEDS PORTING

static zx_status_t ath10k_wmi_tlv_op_pull_vdev_start_ev(struct ath10k* ar,
                                                        struct ath10k_msg_buf* msg_buf,
                                                        struct wmi_vdev_start_ev_arg* arg) {
    const void** tb;
    const struct wmi_vdev_start_response_event* ev;
    zx_status_t ret;

    void* data = ath10k_msg_buf_get_payload(msg_buf);
    size_t len = ath10k_msg_buf_get_payload_len(msg_buf, ATH10K_MSG_TYPE_WMI);
    ret = ath10k_wmi_tlv_parse_alloc(ar, data, len, &tb);
    if (ret != ZX_OK) {
        ath10k_warn("failed to parse tlv: %d\n", ret);
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_VDEV_START_RESPONSE_EVENT];
    if (!ev) {
        free(tb);
        return ZX_ERR_INVALID_ARGS;
    }

    arg->vdev_id = ev->vdev_id;
    arg->req_id = ev->req_id;
    arg->resp_type = ev->resp_type;
    arg->status = ev->status;

    free(tb);
    return ZX_OK;
}

#if 0   // NEEDS PORTING
static int ath10k_wmi_tlv_op_pull_peer_kick_ev(struct ath10k* ar,
        struct sk_buff* skb,
        struct wmi_peer_kick_ev_arg* arg) {
    const void** tb;
    const struct wmi_peer_sta_kickout_event* ev;
    int ret;

    tb = ath10k_wmi_tlv_parse_alloc(ar, skb->data, skb->len, GFP_ATOMIC);
    if (IS_ERR(tb)) {
        ret = PTR_ERR(tb);
        ath10k_warn("failed to parse tlv: %d\n", ret);
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_PEER_STA_KICKOUT_EVENT];
    if (!ev) {
        kfree(tb);
        return -EPROTO;
    }

    arg->mac_addr = ev->peer_macaddr.addr;

    kfree(tb);
    return 0;
}

struct wmi_tlv_swba_parse {
    const struct wmi_host_swba_event* ev;
    bool tim_done;
    bool noa_done;
    size_t n_tim;
    size_t n_noa;
    struct wmi_swba_ev_arg* arg;
};

static int ath10k_wmi_tlv_swba_tim_parse(struct ath10k* ar, uint16_t tag, uint16_t len,
        const void* ptr, void* data) {
    struct wmi_tlv_swba_parse* swba = data;
    struct wmi_tim_info_arg* tim_info_arg;
    const struct wmi_tim_info* tim_info_ev = ptr;

    if (tag != WMI_TLV_TAG_STRUCT_TIM_INFO) {
        return -EPROTO;
    }

    if (swba->n_tim >= countof(swba->arg->tim_info)) {
        return -ENOBUFS;
    }

    if (tim_info_ev->tim_len >
            sizeof(tim_info_ev->tim_bitmap)) {
        ath10k_warn("refusing to parse invalid swba structure\n");
        return -EPROTO;
    }

    tim_info_arg = &swba->arg->tim_info[swba->n_tim];
    tim_info_arg->tim_len = tim_info_ev->tim_len;
    tim_info_arg->tim_mcast = tim_info_ev->tim_mcast;
    tim_info_arg->tim_bitmap = tim_info_ev->tim_bitmap;
    tim_info_arg->tim_changed = tim_info_ev->tim_changed;
    tim_info_arg->tim_num_ps_pending = tim_info_ev->tim_num_ps_pending;

    swba->n_tim++;

    return 0;
}

static int ath10k_wmi_tlv_swba_noa_parse(struct ath10k* ar, uint16_t tag, uint16_t len,
        const void* ptr, void* data) {
    struct wmi_tlv_swba_parse* swba = data;

    if (tag != WMI_TLV_TAG_STRUCT_P2P_NOA_INFO) {
        return -EPROTO;
    }

    if (swba->n_noa >= countof(swba->arg->noa_info)) {
        return -ENOBUFS;
    }

    swba->arg->noa_info[swba->n_noa++] = ptr;
    return 0;
}

static int ath10k_wmi_tlv_swba_parse(struct ath10k* ar, uint16_t tag, uint16_t len,
                                     const void* ptr, void* data) {
    struct wmi_tlv_swba_parse* swba = data;
    int ret;

    switch (tag) {
    case WMI_TLV_TAG_STRUCT_HOST_SWBA_EVENT:
        swba->ev = ptr;
        break;
    case WMI_TLV_TAG_ARRAY_STRUCT:
        if (!swba->tim_done) {
            swba->tim_done = true;
            ret = ath10k_wmi_tlv_iter(ar, ptr, len,
                                      ath10k_wmi_tlv_swba_tim_parse,
                                      swba);
            if (ret) {
                return ret;
            }
        } else if (!swba->noa_done) {
            swba->noa_done = true;
            ret = ath10k_wmi_tlv_iter(ar, ptr, len,
                                      ath10k_wmi_tlv_swba_noa_parse,
                                      swba);
            if (ret) {
                return ret;
            }
        }
        break;
    default:
        break;
    }
    return 0;
}

static int ath10k_wmi_tlv_op_pull_swba_ev(struct ath10k* ar,
        struct sk_buff* skb,
        struct wmi_swba_ev_arg* arg) {
    struct wmi_tlv_swba_parse swba = { .arg = arg };
    uint32_t map;
    size_t n_vdevs;
    int ret;

    ret = ath10k_wmi_tlv_iter(ar, skb->data, skb->len,
                              ath10k_wmi_tlv_swba_parse, &swba);
    if (ret) {
        ath10k_warn("failed to parse tlv: %d\n", ret);
        return ret;
    }

    if (!swba.ev) {
        return -EPROTO;
    }

    arg->vdev_map = swba.ev->vdev_map;

    for (map = arg->vdev_map, n_vdevs = 0; map; map >>= 1)
        if (map & 0x1) {
            n_vdevs++;
        }

    if (n_vdevs != swba.n_tim ||
            n_vdevs != swba.n_noa) {
        return -EPROTO;
    }

    return 0;
}

static int ath10k_wmi_tlv_op_pull_phyerr_ev_hdr(struct ath10k* ar,
        struct sk_buff* skb,
        struct wmi_phyerr_hdr_arg* arg) {
    const void** tb;
    const struct wmi_tlv_phyerr_ev* ev;
    const void* phyerrs;
    int ret;

    tb = ath10k_wmi_tlv_parse_alloc(ar, skb->data, skb->len, GFP_ATOMIC);
    if (IS_ERR(tb)) {
        ret = PTR_ERR(tb);
        ath10k_warn("failed to parse tlv: %d\n", ret);
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_COMB_PHYERR_RX_HDR];
    phyerrs = tb[WMI_TLV_TAG_ARRAY_BYTE];

    if (!ev || !phyerrs) {
        kfree(tb);
        return -EPROTO;
    }

    arg->num_phyerrs  = ev->num_phyerrs;
    arg->tsf_l32 = ev->tsf_l32;
    arg->tsf_u32 = ev->tsf_u32;
    arg->buf_len = ev->buf_len;
    arg->phyerrs = phyerrs;

    kfree(tb);
    return 0;
}
#endif  // NEEDS PORTING

// clang-format off
#define WMI_TLV_ABI_VER_NS0 0x5F414351
#define WMI_TLV_ABI_VER_NS1 0x00004C4D
#define WMI_TLV_ABI_VER_NS2 0x00000000
#define WMI_TLV_ABI_VER_NS3 0x00000000

#define WMI_TLV_ABI_VER0_MAJOR 1
#define WMI_TLV_ABI_VER0_MINOR 0
#define WMI_TLV_ABI_VER0 ((((WMI_TLV_ABI_VER0_MAJOR) << 24) & 0xFF000000) | \
              (((WMI_TLV_ABI_VER0_MINOR) <<  0) & 0x00FFFFFF))
#define WMI_TLV_ABI_VER1 53
// clang-format on

static zx_status_t ath10k_wmi_tlv_parse_mem_reqs(struct ath10k* ar, uint16_t tag, uint16_t len,
                                                 const void* ptr, void* data) {
    struct wmi_svc_rdy_ev_arg* arg = data;
    unsigned int i;

    if (tag != WMI_TLV_TAG_STRUCT_WLAN_HOST_MEM_REQ) { return ZX_ERR_WRONG_TYPE; }

    for (i = 0; i < countof(arg->mem_reqs); i++) {
        if (!arg->mem_reqs[i]) {
            arg->mem_reqs[i] = ptr;
            return ZX_OK;
        }
    }

    return ZX_ERR_NO_MEMORY;
}

static zx_status_t ath10k_wmi_tlv_op_pull_svc_rdy_ev(struct ath10k* ar,
                                                     struct ath10k_msg_buf* msg_buf,
                                                     struct wmi_svc_rdy_ev_arg* arg) {
    const void** tb;
    const struct hal_reg_capabilities* reg;
    const struct wmi_tlv_svc_rdy_ev* ev;
    const uint32_t* svc_bmap;
    const struct wlan_host_mem_req* mem_reqs;
    zx_status_t ret;

    void* data = ath10k_msg_buf_get_payload(msg_buf);
    size_t len = ath10k_msg_buf_get_payload_len(msg_buf, ATH10K_MSG_TYPE_WMI);
    ret = ath10k_wmi_tlv_parse_alloc(ar, data, len, &tb);
    if (ret != ZX_OK) {
        ath10k_warn("failed to parse tlv: %s\n", zx_status_get_string(ret));
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_SERVICE_READY_EVENT];
    reg = tb[WMI_TLV_TAG_STRUCT_HAL_REG_CAPABILITIES];
    svc_bmap = tb[WMI_TLV_TAG_ARRAY_UINT32];
    mem_reqs = tb[WMI_TLV_TAG_ARRAY_STRUCT];

    if (!ev || !reg || !svc_bmap || !mem_reqs) {
        free(tb);
        return ZX_ERR_INVALID_ARGS;
    }

    /* This is an internal ABI compatibility check for WMI TLV so check it
     * here instead of the generic WMI code.
     */
    ath10k_dbg(ar, ATH10K_DBG_WMI,
               "wmi tlv abi 0x%08x ?= 0x%08x, 0x%08x ?= 0x%08x, 0x%08x ?= 0x%08x, 0x%08x ?= "
               "0x%08x, 0x%08x ?= 0x%08x\n",
               ev->abi.abi_ver0, WMI_TLV_ABI_VER0, ev->abi.abi_ver_ns0, WMI_TLV_ABI_VER_NS0,
               ev->abi.abi_ver_ns1, WMI_TLV_ABI_VER_NS1, ev->abi.abi_ver_ns2, WMI_TLV_ABI_VER_NS2,
               ev->abi.abi_ver_ns3, WMI_TLV_ABI_VER_NS3);

    if (ev->abi.abi_ver0 != WMI_TLV_ABI_VER0 || ev->abi.abi_ver_ns0 != WMI_TLV_ABI_VER_NS0 ||
        ev->abi.abi_ver_ns1 != WMI_TLV_ABI_VER_NS1 || ev->abi.abi_ver_ns2 != WMI_TLV_ABI_VER_NS2 ||
        ev->abi.abi_ver_ns3 != WMI_TLV_ABI_VER_NS3) {
        free(tb);
        return ZX_ERR_NOT_SUPPORTED;
    }

    arg->min_tx_power = ev->hw_min_tx_power;
    arg->max_tx_power = ev->hw_max_tx_power;
    arg->ht_cap = ev->ht_cap_info;
    arg->vht_cap = ev->vht_cap_info;
    arg->sw_ver0 = ev->abi.abi_ver0;
    arg->sw_ver1 = ev->abi.abi_ver1;
    arg->fw_build = ev->fw_build_vers;
    arg->phy_capab = ev->phy_capability;
    arg->num_rf_chains = ev->num_rf_chains;
    arg->eeprom_rd = reg->eeprom_rd;
    arg->num_mem_reqs = ev->num_mem_reqs;
    arg->service_map = svc_bmap;
    arg->service_map_len = ath10k_wmi_tlv_len(svc_bmap);

    ret = ath10k_wmi_tlv_iter(ar, mem_reqs, ath10k_wmi_tlv_len(mem_reqs),
                              ath10k_wmi_tlv_parse_mem_reqs, arg);
    if (ret != ZX_OK) {
        free(tb);
        ath10k_warn("failed to parse mem_reqs tlv: %s\n", zx_status_get_string(ret));
        return ret;
    }

    free(tb);
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_pull_rdy_ev(struct ath10k* ar, struct ath10k_msg_buf* msg_buf,
                                                 struct wmi_rdy_ev_arg* arg) {
    const void** tb;
    const struct wmi_tlv_rdy_ev* ev;
    zx_status_t ret;

    struct wmi_tlv* tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    size_t len = ath10k_msg_buf_get_payload_len(msg_buf, ATH10K_MSG_TYPE_WMI);
    ret = ath10k_wmi_tlv_parse_alloc(ar, tlv, len, &tb);
    if (ret != ZX_OK) {
        ath10k_warn("failed to parse tlv: %s\n", zx_status_get_string(ret));
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_READY_EVENT];
    if (!ev) {
        free(tb);
        return ZX_ERR_INVALID_ARGS;
    }

    arg->sw_version = ev->abi.abi_ver0;
    arg->abi_version = ev->abi.abi_ver1;
    arg->status = ev->status;
    arg->mac_addr = ev->mac_addr.addr;

    free(tb);
    return ZX_OK;
}

#if 0   // NEEDS PORTING
static void ath10k_wmi_tlv_pull_vdev_stats(const struct wmi_tlv_vdev_stats* src,
        struct ath10k_fw_stats_vdev* dst) {
    int i;

    dst->vdev_id = src->vdev_id;
    dst->beacon_snr = src->beacon_snr;
    dst->data_snr = src->data_snr;
    dst->num_rx_frames = src->num_rx_frames;
    dst->num_rts_fail = src->num_rts_fail;
    dst->num_rts_success = src->num_rts_success;
    dst->num_rx_err = src->num_rx_err;
    dst->num_rx_discard = src->num_rx_discard;
    dst->num_tx_not_acked = src->num_tx_not_acked;

    for (i = 0; i < countof(src->num_tx_frames); i++)
        dst->num_tx_frames[i] =
            src->num_tx_frames[i];

    for (i = 0; i < countof(src->num_tx_frames_retries); i++)
        dst->num_tx_frames_retries[i] =
            src->num_tx_frames_retries[i];

    for (i = 0; i < countof(src->num_tx_frames_failures); i++)
        dst->num_tx_frames_failures[i] =
            src->num_tx_frames_failures[i];

    for (i = 0; i < countof(src->tx_rate_history); i++)
        dst->tx_rate_history[i] =
            src->tx_rate_history[i];

    for (i = 0; i < countof(src->beacon_rssi_history); i++)
        dst->beacon_rssi_history[i] =
            src->beacon_rssi_history[i];
}

static int ath10k_wmi_tlv_op_pull_fw_stats(struct ath10k* ar,
        struct sk_buff* skb,
        struct ath10k_fw_stats* stats) {
    const void** tb;
    const struct wmi_tlv_stats_ev* ev;
    const void* data;
    uint32_t num_pdev_stats;
    uint32_t num_vdev_stats;
    uint32_t num_peer_stats;
    uint32_t num_bcnflt_stats;
    uint32_t num_chan_stats;
    size_t data_len;
    int ret;
    int i;

    tb = ath10k_wmi_tlv_parse_alloc(ar, skb->data, skb->len, GFP_ATOMIC);
    if (IS_ERR(tb)) {
        ret = PTR_ERR(tb);
        ath10k_warn("failed to parse tlv: %d\n", ret);
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_STATS_EVENT];
    data = tb[WMI_TLV_TAG_ARRAY_BYTE];

    if (!ev || !data) {
        kfree(tb);
        return -EPROTO;
    }

    data_len = ath10k_wmi_tlv_len(data);
    num_pdev_stats = ev->num_pdev_stats;
    num_vdev_stats = ev->num_vdev_stats;
    num_peer_stats = ev->num_peer_stats;
    num_bcnflt_stats = ev->num_bcnflt_stats;
    num_chan_stats = ev->num_chan_stats;

    ath10k_dbg(ar, ATH10K_DBG_WMI,
               "wmi tlv stats update pdev %i vdev %i peer %i bcnflt %i chan %i\n",
               num_pdev_stats, num_vdev_stats, num_peer_stats,
               num_bcnflt_stats, num_chan_stats);

    for (i = 0; i < num_pdev_stats; i++) {
        const struct wmi_pdev_stats* src;
        struct ath10k_fw_stats_pdev* dst;

        src = data;
        if (data_len < sizeof(*src)) {
            kfree(tb);
            return -EPROTO;
        }

        data += sizeof(*src);
        data_len -= sizeof(*src);

        dst = kzalloc(sizeof(*dst), GFP_ATOMIC);
        if (!dst) {
            continue;
        }

        ath10k_wmi_pull_pdev_stats_base(&src->base, dst);
        ath10k_wmi_pull_pdev_stats_tx(&src->tx, dst);
        ath10k_wmi_pull_pdev_stats_rx(&src->rx, dst);
        list_add_tail(&dst->list, &stats->pdevs);
    }

    for (i = 0; i < num_vdev_stats; i++) {
        const struct wmi_tlv_vdev_stats* src;
        struct ath10k_fw_stats_vdev* dst;

        src = data;
        if (data_len < sizeof(*src)) {
            kfree(tb);
            return -EPROTO;
        }

        data += sizeof(*src);
        data_len -= sizeof(*src);

        dst = kzalloc(sizeof(*dst), GFP_ATOMIC);
        if (!dst) {
            continue;
        }

        ath10k_wmi_tlv_pull_vdev_stats(src, dst);
        list_add_tail(&dst->list, &stats->vdevs);
    }

    for (i = 0; i < num_peer_stats; i++) {
        const struct wmi_10x_peer_stats* src;
        struct ath10k_fw_stats_peer* dst;

        src = data;
        if (data_len < sizeof(*src)) {
            kfree(tb);
            return -EPROTO;
        }

        data += sizeof(*src);
        data_len -= sizeof(*src);

        dst = kzalloc(sizeof(*dst), GFP_ATOMIC);
        if (!dst) {
            continue;
        }

        ath10k_wmi_pull_peer_stats(&src->old, dst);
        dst->peer_rx_rate = src->peer_rx_rate;
        list_add_tail(&dst->list, &stats->peers);
    }

    kfree(tb);
    return 0;
}

static int ath10k_wmi_tlv_op_pull_roam_ev(struct ath10k* ar,
        struct sk_buff* skb,
        struct wmi_roam_ev_arg* arg) {
    const void** tb;
    const struct wmi_tlv_roam_ev* ev;
    int ret;

    tb = ath10k_wmi_tlv_parse_alloc(ar, skb->data, skb->len, GFP_ATOMIC);
    if (IS_ERR(tb)) {
        ret = PTR_ERR(tb);
        ath10k_warn("failed to parse tlv: %d\n", ret);
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_ROAM_EVENT];
    if (!ev) {
        kfree(tb);
        return -EPROTO;
    }

    arg->vdev_id = ev->vdev_id;
    arg->reason = ev->reason;
    arg->rssi = ev->rssi;

    kfree(tb);
    return 0;
}

static int
ath10k_wmi_tlv_op_pull_wow_ev(struct ath10k* ar, struct sk_buff* skb,
                              struct wmi_wow_ev_arg* arg) {
    const void** tb;
    const struct wmi_tlv_wow_event_info* ev;
    int ret;

    tb = ath10k_wmi_tlv_parse_alloc(ar, skb->data, skb->len, GFP_ATOMIC);
    if (IS_ERR(tb)) {
        ret = PTR_ERR(tb);
        ath10k_warn("failed to parse tlv: %d\n", ret);
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_WOW_EVENT_INFO];
    if (!ev) {
        kfree(tb);
        return -EPROTO;
    }

    arg->vdev_id = ev->vdev_id;
    arg->flag = ev->flag;
    arg->wake_reason = ev->wake_reason;
    arg->data_len = ev->data_len;

    kfree(tb);
    return 0;
}
#endif  // NEEDS PORTING

static zx_status_t ath10k_wmi_tlv_op_pull_echo_ev(struct ath10k* ar, struct ath10k_msg_buf* msg_buf,
                                                  struct wmi_echo_ev_arg* arg) {
    const void** tb;
    const struct wmi_echo_event* ev;
    zx_status_t ret;

    const void* data = ath10k_msg_buf_get_payload(msg_buf);
    size_t msg_len = ath10k_msg_buf_get_payload_len(msg_buf, ATH10K_MSG_TYPE_WMI);
    ret = ath10k_wmi_tlv_parse_alloc(ar, data, msg_len, &tb);
    if (ret != ZX_OK) {
        ath10k_warn("failed to parse tlv: %s\n", zx_status_get_string(ret));
        return ret;
    }

    ev = tb[WMI_TLV_TAG_STRUCT_ECHO_EVENT];
    if (!ev) {
        free(tb);
        return ZX_ERR_INVALID_ARGS;
    }

    arg->value = ev->value;

    free(tb);
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_pdev_suspend(struct ath10k* ar,
                                                      struct ath10k_msg_buf** bufptr,
                                                      uint32_t opt) {
    zx_status_t status;
    struct ath10k_msg_buf* msg_buf;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PDEV_SUSPEND, 0);
    if (status != ZX_OK) { return status; }

    struct wmi_tlv* tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_PDEV_SUSPEND_CMD;
    tlv->len = sizeof(struct wmi_tlv_pdev_suspend);

    struct wmi_tlv_pdev_suspend* cmd;
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PDEV_SUSPEND);
    cmd->opt = opt;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv pdev suspend\n");
    *bufptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_pdev_resume(struct ath10k* ar,
                                                     struct ath10k_msg_buf** msg_buf_ptr) {
    struct wmi_tlv_resume_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PDEV_RESUME, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_PDEV_RESUME_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PDEV_RESUME);
    cmd->reserved = 0;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv pdev resume\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_pdev_set_rd(struct ath10k* ar,
                                                     struct ath10k_msg_buf** msg_buf_ptr,
                                                     uint16_t rd, uint16_t rd2g, uint16_t rd5g,
                                                     uint16_t ctl2g, uint16_t ctl5g,
                                                     enum wmi_dfs_region dfs_reg) {
    struct wmi_tlv_pdev_set_rd_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PDEV_SET_REGDOMAIN, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_PDEV_SET_REGDOMAIN_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PDEV_SET_REGDOMAIN);
    cmd->regd = rd;
    cmd->regd_2ghz = rd2g;
    cmd->regd_5ghz = rd5g;
    cmd->conform_limit_2ghz = ctl2g;
    cmd->conform_limit_5ghz = ctl5g;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv pdev set rd\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static enum wmi_txbf_conf ath10k_wmi_tlv_txbf_conf_scheme(struct ath10k* ar) {
    return WMI_TXBF_CONF_AFTER_ASSOC;
}

static zx_status_t ath10k_wmi_tlv_op_gen_pdev_set_param(struct ath10k* ar,
                                                        struct ath10k_msg_buf** msg_buf_ptr,
                                                        uint32_t param_id, uint32_t param_value) {
    struct wmi_tlv_pdev_set_param_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PDEV_SET_PARAM, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_PDEV_SET_PARAM_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PDEV_SET_PARAM);
    cmd->param_id = param_id;
    cmd->param_value = param_value;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv pdev set param\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_init(struct ath10k* ar,
                                              struct ath10k_msg_buf** msg_buf_ptr) {
    struct ath10k_msg_buf* msg_buf;
    struct wmi_tlv* tlv;
    struct wmi_tlv_init_cmd* cmd;
    struct wmi_tlv_resource_config* cfg;
    struct wmi_host_mem_chunks* chunks;
    size_t extra_len, chunks_len;
    void* ptr;
    zx_status_t status;

    chunks_len = ar->wmi.num_mem_chunks * sizeof(struct host_memory_chunk);
    extra_len = (sizeof(*tlv) + sizeof(*cfg)) + (sizeof(*tlv) + chunks_len);

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_INIT_CMD, extra_len);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_INIT_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_INIT_CMD);

    ptr = ath10k_msg_buf_get_payload(msg_buf);
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_RESOURCE_CONFIG;
    tlv->len = sizeof(*cfg);
    cfg = (void*)tlv->value;
    ptr += sizeof(*tlv);
    ptr += sizeof(*cfg);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_STRUCT;
    tlv->len = chunks_len;
    chunks = (void*)tlv->value;

    ptr += sizeof(*tlv);
    ptr += chunks_len;

    cmd->abi.abi_ver0 = WMI_TLV_ABI_VER0;
    cmd->abi.abi_ver1 = WMI_TLV_ABI_VER1;
    cmd->abi.abi_ver_ns0 = WMI_TLV_ABI_VER_NS0;
    cmd->abi.abi_ver_ns1 = WMI_TLV_ABI_VER_NS1;
    cmd->abi.abi_ver_ns2 = WMI_TLV_ABI_VER_NS2;
    cmd->abi.abi_ver_ns3 = WMI_TLV_ABI_VER_NS3;
    cmd->num_host_mem_chunks = ar->wmi.num_mem_chunks;

    cfg->num_vdevs = TARGET_TLV_NUM_VDEVS;
    cfg->num_peers = TARGET_TLV_NUM_PEERS;

    if (BITARR_TEST(ar->wmi.svc_map, WMI_SERVICE_RX_FULL_REORDER)) {
        cfg->num_offload_peers = TARGET_TLV_NUM_VDEVS;
        cfg->num_offload_reorder_bufs = TARGET_TLV_NUM_VDEVS;
    } else {
        cfg->num_offload_peers = 0;
        cfg->num_offload_reorder_bufs = 0;
    }

    cfg->num_peer_keys = 2;
    cfg->num_tids = TARGET_TLV_NUM_TIDS;
    cfg->ast_skid_limit = 0x10;
    cfg->tx_chain_mask = 0x7;
    cfg->rx_chain_mask = 0x7;
    cfg->rx_timeout_pri[0] = 0x64;
    cfg->rx_timeout_pri[1] = 0x64;
    cfg->rx_timeout_pri[2] = 0x64;
    cfg->rx_timeout_pri[3] = 0x28;
    cfg->rx_decap_mode = ar->wmi.rx_decap_mode;
    cfg->scan_max_pending_reqs = 4;
    cfg->bmiss_offload_max_vdev = TARGET_TLV_NUM_VDEVS;
    cfg->roam_offload_max_vdev = TARGET_TLV_NUM_VDEVS;
    cfg->roam_offload_max_ap_profiles = 8;
    cfg->num_mcast_groups = 0;
    cfg->num_mcast_table_elems = 0;
    cfg->mcast2ucast_mode = 0;
    cfg->tx_dbg_log_size = 0x400;
    cfg->num_wds_entries = 0x20;
    cfg->dma_burst_size = 0;
    cfg->mac_aggr_delim = 0;
    cfg->rx_skip_defrag_timeout_dup_detection_check = 0;
    cfg->vow_config = 0;
    cfg->gtk_offload_max_vdev = 2;
    cfg->num_msdu_desc = TARGET_TLV_NUM_MSDU_DESC;
    cfg->max_frag_entries = 2;
    cfg->num_tdls_vdevs = TARGET_TLV_NUM_TDLS_VDEVS;
    cfg->num_tdls_conn_table_entries = 0x20;
    cfg->beacon_tx_offload_max_vdev = 2;
    cfg->num_multicast_filter_entries = 5;
    cfg->num_wow_filters = ar->wow.max_num_patterns;
    cfg->num_keep_alive_pattern = 6;
    cfg->keep_alive_pattern_size = 0;
    cfg->max_tdls_concurrent_sleep_sta = 1;
    cfg->max_tdls_concurrent_buffer_sta = 1;

    ath10k_wmi_put_host_mem_chunks(ar, chunks);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv init\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_start_scan(struct ath10k* ar,
                                                    struct ath10k_msg_buf** msg_buf_ptr,
                                                    const struct wmi_start_scan_arg* arg) {
    unsigned i;

    zx_status_t ret = ath10k_wmi_start_scan_verify(arg);
    if (ret != ZX_OK) { return ret; }

    size_t chan_len = arg->n_channels * sizeof(uint32_t);
    size_t ssid_len = arg->n_ssids * sizeof(struct wmi_ssid);
    size_t bssid_len = arg->n_bssids * sizeof(struct wmi_mac_addr);
    size_t ie_len = ROUNDUP(arg->ie_len, 4);
    size_t extra = sizeof(struct wmi_tlv) + chan_len + sizeof(struct wmi_tlv) + ssid_len +
                   sizeof(struct wmi_tlv) + bssid_len + sizeof(struct wmi_tlv) + ie_len;

    struct ath10k_msg_buf* msg_buf;
    ret = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_START_SCAN, extra);
    if (ret != ZX_OK) { return ret; }

    struct wmi_tlv* tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_START_SCAN_CMD;
    tlv->len = sizeof(struct wmi_tlv_start_scan_cmd);

    struct wmi_tlv_start_scan_cmd* cmd;
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_START_SCAN);

    ath10k_wmi_put_start_scan_common(&cmd->common, arg);
    cmd->burst_duration_ms = arg->burst_duration_ms;
    cmd->num_channels = arg->n_channels;
    cmd->num_ssids = arg->n_ssids;
    cmd->num_bssids = arg->n_bssids;
    cmd->ie_len = arg->ie_len;
    cmd->num_probes = 3;

    /* FIXME: There are some scan flag inconsistencies across firmwares,
     * e.g. WMI-TLV inverts the logic behind the following flag.
     */
    cmd->common.scan_ctrl_flags ^= WMI_SCAN_FILTER_PROBE_REQ;

    void* ptr = ath10k_msg_buf_get_payload(msg_buf);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_UINT32;
    tlv->len = chan_len;
    uint32_t* chans = (void*)tlv->value;
    for (i = 0; i < arg->n_channels; i++) {
        chans[i] = arg->channels[i];
    }

    ptr += sizeof(*tlv);
    ptr += chan_len;

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_FIXED_STRUCT;
    tlv->len = ssid_len;
    struct wmi_ssid* ssids = (void*)tlv->value;
    for (i = 0; i < arg->n_ssids; i++) {
        ssids[i].ssid_len = arg->ssids[i].len;
        memcpy(ssids[i].ssid, arg->ssids[i].ssid, arg->ssids[i].len);
    }

    ptr += sizeof(*tlv);
    ptr += ssid_len;

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_FIXED_STRUCT;
    tlv->len = bssid_len;
    struct wmi_mac_addr* addrs = (void*)tlv->value;
    for (i = 0; i < arg->n_bssids; i++) {
        memcpy(addrs[i].addr, arg->bssids[i].bssid, ETH_ALEN);
    }

    ptr += sizeof(*tlv);
    ptr += bssid_len;

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_BYTE;
    tlv->len = ie_len;
    memcpy(tlv->value, arg->ie, arg->ie_len);

    ptr += sizeof(*tlv);
    ptr += ie_len;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv start scan\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_stop_scan(struct ath10k* ar,
                                                   struct ath10k_msg_buf** msg_buf_ptr,
                                                   const struct wmi_stop_scan_arg* arg) {
    if (arg->req_id > 0xFFF) { return ZX_ERR_INVALID_ARGS; }
    if (arg->req_type == WMI_SCAN_STOP_ONE && arg->u.scan_id > 0xFFF) {
        return ZX_ERR_INVALID_ARGS;
    }

    struct ath10k_msg_buf* msg_buf;
    zx_status_t ret = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_STOP_SCAN, 0);
    if (ret != ZX_OK) { return ret; }

    uint32_t scan_id = arg->u.scan_id;
    scan_id |= WMI_HOST_SCAN_REQ_ID_PREFIX;

    uint32_t req_id = arg->req_id;
    req_id |= WMI_HOST_SCAN_REQUESTOR_ID_PREFIX;

    struct wmi_tlv* tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_STOP_SCAN_CMD;
    tlv->len = sizeof(struct wmi_stop_scan_cmd);

    struct wmi_stop_scan_cmd* cmd =
        ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_STOP_SCAN);
    cmd->req_type = arg->req_type;
    cmd->vdev_id = arg->u.vdev_id;
    cmd->scan_id = scan_id;
    cmd->scan_req_id = req_id;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv stop scan\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_vdev_create(struct ath10k* ar,
                                                     struct ath10k_msg_buf** msg_buf_ptr,
                                                     uint32_t vdev_id, enum wmi_vdev_type vdev_type,
                                                     enum wmi_vdev_subtype vdev_subtype,
                                                     const uint8_t mac_addr[ETH_ALEN]) {
    struct wmi_vdev_create_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_CREATE, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_VDEV_CREATE_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_CREATE);
    cmd->vdev_id = vdev_id;
    cmd->vdev_type = vdev_type;
    cmd->vdev_subtype = vdev_subtype;
    memcpy(cmd->vdev_macaddr.addr, mac_addr, ETH_ALEN);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv vdev create\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_vdev_delete(struct ath10k* ar,
                                                     struct ath10k_msg_buf** msg_buf_ptr,
                                                     uint32_t vdev_id) {
    struct wmi_vdev_delete_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_DELETE, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_VDEV_DELETE_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_DELETE);
    cmd->vdev_id = vdev_id;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv vdev delete\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k* ar,
                                                    struct ath10k_msg_buf** msg_buf_ptr,
                                                    const struct wmi_vdev_start_request_arg* arg,
                                                    bool restart) {
    struct wmi_tlv_vdev_start_cmd* cmd;
    zx_status_t status;
    uint32_t flags = 0;

    if (COND_WARN(arg->hidden_ssid && !arg->ssid)) { return ZX_ERR_INVALID_ARGS; }
    if (COND_WARN(arg->ssid_len > sizeof(cmd->ssid.ssid))) { return ZX_ERR_INVALID_ARGS; }

    size_t extra = sizeof(struct wmi_tlv) + sizeof(struct wmi_channel) + sizeof(struct wmi_tlv) + 0;
    struct ath10k_msg_buf* msg_buf;
    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_START, extra);
    if (status != ZX_OK) { return status; }

    if (arg->hidden_ssid) { flags |= WMI_VDEV_START_HIDDEN_SSID; }
    if (arg->pmf_enabled) { flags |= WMI_VDEV_START_PMF_ENABLED; }

    struct wmi_tlv* tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_VDEV_START_REQUEST_CMD;
    tlv->len = sizeof(struct wmi_tlv_vdev_start_cmd);

    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_START);
    cmd->vdev_id = arg->vdev_id;
    cmd->bcn_intval = arg->bcn_intval;
    cmd->dtim_period = arg->dtim_period;
    cmd->flags = flags;
    cmd->bcn_tx_rate = arg->bcn_tx_rate;
    cmd->bcn_tx_power = arg->bcn_tx_power;
    cmd->disable_hw_ack = arg->disable_hw_ack;

    if (arg->ssid) {
        cmd->ssid.ssid_len = arg->ssid_len;
        memcpy(cmd->ssid.ssid, arg->ssid, arg->ssid_len);
    }

    void* ptr = ath10k_msg_buf_get_payload(msg_buf);
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_CHANNEL;
    tlv->len = sizeof(struct wmi_channel);
    ptr += sizeof(struct wmi_tlv);

    struct wmi_channel* ch = ptr;
    ath10k_wmi_put_wmi_channel(ch, &arg->channel);
    ptr += sizeof(struct wmi_channel);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_STRUCT;
    tlv->len = 0;

    /* Note: This is a nested TLV containing:
     * [wmi_tlv][wmi_p2p_noa_descriptor][wmi_tlv]..
     */

    *msg_buf_ptr = msg_buf;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv vdev start\n");
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_vdev_stop(struct ath10k* ar,
                                                   struct ath10k_msg_buf** msg_buf_ptr,
                                                   uint32_t vdev_id) {
    struct wmi_vdev_stop_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_STOP, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_VDEV_STOP_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_STOP);
    cmd->vdev_id = vdev_id;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv vdev stop\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_vdev_up(struct ath10k* ar,
                                                 struct ath10k_msg_buf** msg_buf_ptr,
                                                 uint32_t vdev_id, uint32_t aid,
                                                 const uint8_t* bssid)

{
    struct wmi_vdev_up_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_UP, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_VDEV_UP_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_UP);
    cmd->vdev_id = vdev_id;
    cmd->vdev_assoc_id = aid;
    memcpy(cmd->vdev_bssid.addr, bssid, ETH_ALEN);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv vdev up\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_vdev_down(struct ath10k* ar,
                                                   struct ath10k_msg_buf** msg_buf_ptr,
                                                   uint32_t vdev_id) {
    struct wmi_vdev_down_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_DOWN, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_VDEV_DOWN_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_DOWN);
    cmd->vdev_id = vdev_id;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv vdev down\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_vdev_set_param(struct ath10k* ar,
                                                        struct ath10k_msg_buf** msg_buf_ptr,
                                                        uint32_t vdev_id, uint32_t param_id,
                                                        uint32_t param_value) {
    struct wmi_vdev_set_param_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_SET_PARAM, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_VDEV_SET_PARAM_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_SET_PARAM);
    cmd->vdev_id = vdev_id;
    cmd->param_id = param_id;
    cmd->param_value = param_value;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv vdev set param\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_vdev_install_key(
    struct ath10k* ar, struct ath10k_msg_buf** msg_buf_ptr,
    const struct wmi_vdev_install_key_arg* arg) {
    struct wmi_vdev_install_key_cmd* cmd;
    struct wmi_tlv* tlv;
    zx_status_t status;
    struct ath10k_msg_buf* msg_buf;
    void* ptr;

    if (arg->key_cipher == WMI_CIPHER_NONE && arg->key_data != NULL) { return ZX_ERR_INVALID_ARGS; }
    if (arg->key_cipher != WMI_CIPHER_NONE && arg->key_data == NULL) { return ZX_ERR_INVALID_ARGS; }

    size_t len = sizeof(*tlv) + ROUNDUP(arg->key_len, sizeof(uint32_t));
    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_INSTALL_KEY, len);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_VDEV_INSTALL_KEY_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_INSTALL_KEY);
    cmd->vdev_id = arg->vdev_id;
    cmd->key_idx = arg->key_idx;
    cmd->key_flags = arg->key_flags;
    cmd->key_cipher = arg->key_cipher;
    cmd->key_len = arg->key_len;
    cmd->key_txmic_len = arg->key_txmic_len;
    cmd->key_rxmic_len = arg->key_rxmic_len;

    if (arg->macaddr) { memcpy(cmd->peer_macaddr.addr, arg->macaddr, ETH_ALEN); }

    ptr = ath10k_msg_buf_get_payload(msg_buf);
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_BYTE;
    tlv->len = ROUNDUP(arg->key_len, sizeof(uint32_t));
    if (arg->key_data) { memcpy(tlv->value, arg->key_data, arg->key_len); }

    ptr += sizeof(*tlv);
    ptr += ROUNDUP(arg->key_len, sizeof(uint32_t));

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv vdev install key\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

#if 0   // NEEDS PORTING
static void* ath10k_wmi_tlv_put_uapsd_ac(struct ath10k* ar, void* ptr,
        const struct wmi_sta_uapsd_auto_trig_arg* arg) {
    struct wmi_sta_uapsd_auto_trig_param* ac;
    struct wmi_tlv* tlv;

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_STA_UAPSD_AUTO_TRIG_PARAM;
    tlv->len = sizeof(*ac);
    ac = (void*)tlv->value;

    ac->wmm_ac = arg->wmm_ac;
    ac->user_priority = arg->user_priority;
    ac->service_interval = arg->service_interval;
    ac->suspend_interval = arg->suspend_interval;
    ac->delay_interval = arg->delay_interval;

    ath10k_dbg(ar, ATH10K_DBG_WMI,
               "wmi tlv vdev sta uapsd auto trigger ac %d prio %d svc int %d susp int %d delay int %d\n",
               ac->wmm_ac, ac->user_priority, ac->service_interval,
               ac->suspend_interval, ac->delay_interval);

    return ptr + sizeof(*tlv) + sizeof(*ac);
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_vdev_sta_uapsd(struct ath10k* ar, uint32_t vdev_id,
                                     const uint8_t peer_addr[ETH_ALEN],
                                     const struct wmi_sta_uapsd_auto_trig_arg* args,
                                     uint32_t num_ac) {
    struct wmi_sta_uapsd_auto_trig_cmd_fixed_param* cmd;
    struct wmi_sta_uapsd_auto_trig_param* ac;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    size_t len;
    size_t ac_tlv_len;
    void* ptr;
    int i;

    ac_tlv_len = num_ac * (sizeof(*tlv) + sizeof(*ac));
    len = sizeof(*tlv) + sizeof(*cmd) +
          sizeof(*tlv) + ac_tlv_len;
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    ptr = (void*)skb->data;
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_STA_UAPSD_AUTO_TRIG_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->vdev_id = vdev_id;
    cmd->num_ac = num_ac;
    memcpy(cmd->peer_macaddr.addr, peer_addr, ETH_ALEN);

    ptr += sizeof(*tlv);
    ptr += sizeof(*cmd);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_STRUCT;
    tlv->len = ac_tlv_len;
    ac = (void*)tlv->value;

    ptr += sizeof(*tlv);
    for (i = 0; i < num_ac; i++) {
        ptr = ath10k_wmi_tlv_put_uapsd_ac(ar, ptr, &args[i]);
    }

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv vdev sta uapsd auto trigger\n");
    return skb;
}

static void* ath10k_wmi_tlv_put_wmm(void* ptr,
                                    const struct wmi_wmm_params_arg* arg) {
    struct wmi_wmm_params* wmm;
    struct wmi_tlv* tlv;

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_WMM_PARAMS;
    tlv->len = sizeof(*wmm);
    wmm = (void*)tlv->value;
    ath10k_wmi_set_wmm_param(wmm, arg);

    return ptr + sizeof(*tlv) + sizeof(*wmm);
}
#endif  // NEEDS PORTING

static zx_status_t ath10k_wmi_tlv_op_gen_vdev_wmm_conf(struct ath10k* ar,
                                                       struct ath10k_msg_buf** msg_buf_ptr,
                                                       uint32_t vdev_id,
                                                       const struct wmi_wmm_params_all_arg* arg) {
    struct wmi_tlv_vdev_set_wmm_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_SET_WMM, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_VDEV_SET_WMM_PARAMS_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_VDEV_SET_WMM);
    cmd->vdev_id = vdev_id;

    ath10k_wmi_set_wmm_param(&cmd->vdev_wmm_params[0].params, &arg->ac_be);
    ath10k_wmi_set_wmm_param(&cmd->vdev_wmm_params[1].params, &arg->ac_bk);
    ath10k_wmi_set_wmm_param(&cmd->vdev_wmm_params[2].params, &arg->ac_vi);
    ath10k_wmi_set_wmm_param(&cmd->vdev_wmm_params[3].params, &arg->ac_vo);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv vdev wmm conf\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

#if 0   // NEEDS PORTING
static struct sk_buff*
ath10k_wmi_tlv_op_gen_sta_keepalive(struct ath10k* ar,
                                    const struct wmi_sta_keepalive_arg* arg) {
    struct wmi_tlv_sta_keepalive_cmd* cmd;
    struct wmi_sta_keepalive_arp_resp* arp;
    struct sk_buff* skb;
    struct wmi_tlv* tlv;
    void* ptr;
    size_t len;

    len = sizeof(*tlv) + sizeof(*cmd) +
          sizeof(*tlv) + sizeof(*arp);
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    ptr = (void*)skb->data;
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_STA_KEEPALIVE_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->vdev_id = arg->vdev_id;
    cmd->enabled = arg->enabled;
    cmd->method = arg->method;
    cmd->interval = arg->interval;

    ptr += sizeof(*tlv);
    ptr += sizeof(*cmd);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_STA_KEEPALVE_ARP_RESPONSE;
    tlv->len = sizeof(*arp);
    arp = (void*)tlv->value;

    arp->src_ip4_addr = arg->src_ip4_addr;
    arp->dest_ip4_addr = arg->dest_ip4_addr;
    memcpy(arp->dest_mac_addr.addr, arg->dest_mac_addr, ETH_ALEN);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv sta keepalive vdev %d enabled %d method %d interval %d\n",
               arg->vdev_id, arg->enabled, arg->method, arg->interval);
    return skb;
}
#endif  // NEEDS PORTING

static zx_status_t ath10k_wmi_tlv_op_gen_peer_create(struct ath10k* ar,
                                                     struct ath10k_msg_buf** msg_buf_ptr,
                                                     uint32_t vdev_id,
                                                     const uint8_t peer_addr[ETH_ALEN],
                                                     enum wmi_peer_type peer_type) {
    struct wmi_tlv_peer_create_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PEER_CREATE, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_PEER_CREATE_CMD;
    tlv->len = sizeof(*cmd);

    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PEER_CREATE);
    cmd->vdev_id = vdev_id;
    cmd->peer_type = peer_type;
    memcpy(cmd->peer_addr.addr, peer_addr, ETH_ALEN);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv peer create\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_peer_delete(struct ath10k* ar,
                                                     struct ath10k_msg_buf** msg_buf_ptr,
                                                     uint32_t vdev_id,
                                                     const uint8_t peer_addr[ETH_ALEN]) {
    struct wmi_peer_delete_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PEER_DELETE, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_PEER_DELETE_CMD;
    tlv->len = sizeof(*cmd);

    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PEER_DELETE);
    cmd = (void*)tlv->value;
    cmd->vdev_id = vdev_id;
    memcpy(cmd->peer_macaddr.addr, peer_addr, ETH_ALEN);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv peer delete\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_peer_flush(struct ath10k* ar,
                                                    struct ath10k_msg_buf** msg_buf_ptr,
                                                    uint32_t vdev_id,
                                                    const uint8_t peer_addr[ETH_ALEN],
                                                    uint32_t tid_bitmap) {
    struct wmi_peer_flush_tids_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PEER_FLUSH, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_PEER_FLUSH_TIDS_CMD;
    tlv->len = sizeof(*cmd);

    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PEER_FLUSH);
    cmd->vdev_id = vdev_id;
    cmd->peer_tid_bitmap = tid_bitmap;
    memcpy(cmd->peer_macaddr.addr, peer_addr, ETH_ALEN);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv peer flush\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_peer_set_param(struct ath10k* ar,
                                                        struct ath10k_msg_buf** msg_buf_ptr,
                                                        uint32_t vdev_id, const uint8_t* peer_addr,
                                                        enum wmi_peer_param param_id,
                                                        uint32_t param_value) {
    struct wmi_peer_set_param_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PEER_SET_PARAM, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_PEER_SET_PARAM_CMD;
    tlv->len = sizeof(*cmd);

    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PEER_SET_PARAM);
    cmd = (void*)tlv->value;
    cmd->vdev_id = vdev_id;
    cmd->param_id = param_id;
    cmd->param_value = param_value;
    memcpy(cmd->peer_macaddr.addr, peer_addr, ETH_ALEN);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv peer set param\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

static zx_status_t ath10k_wmi_tlv_op_gen_peer_assoc(struct ath10k* ar,
                                                    struct ath10k_msg_buf** msg_buf_ptr,
                                                    const struct wmi_peer_assoc_complete_arg* arg) {
    struct wmi_tlv_peer_assoc_cmd* cmd;
    struct wmi_vht_rate_set* vht_rate;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    size_t legacy_rate_len, ht_rate_len;
    size_t extra;
    zx_status_t status;
    void* ptr;

    if (arg->peer_mpdu_density > 16) { return ZX_ERR_INVALID_ARGS; }
    if (arg->peer_legacy_rates.num_rates > MAX_SUPPORTED_RATES) { return ZX_ERR_INVALID_ARGS; }
    if (arg->peer_ht_rates.num_rates > MAX_SUPPORTED_RATES) { return ZX_ERR_INVALID_ARGS; }

    legacy_rate_len = ROUNDUP(arg->peer_legacy_rates.num_rates, sizeof(uint32_t));
    ht_rate_len = ROUNDUP(arg->peer_ht_rates.num_rates, sizeof(uint32_t));
    extra = (sizeof(*tlv) + legacy_rate_len) + (sizeof(*tlv) + ht_rate_len) +
            (sizeof(*tlv) + sizeof(*vht_rate));
    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PEER_ASSOC, extra);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_PEER_ASSOC_COMPLETE_CMD;
    tlv->len = sizeof(*cmd);

    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PEER_ASSOC);
    ;
    cmd->vdev_id = arg->vdev_id;
    cmd->new_assoc = arg->peer_reassoc ? 0 : 1;
    cmd->assoc_id = arg->peer_aid;
    cmd->flags = arg->peer_flags;
    cmd->caps = arg->peer_caps;
    cmd->listen_intval = arg->peer_listen_intval;
    cmd->ht_caps = arg->peer_ht_caps;
    cmd->max_mpdu = arg->peer_max_mpdu;
    cmd->mpdu_density = arg->peer_mpdu_density;
    cmd->rate_caps = arg->peer_rate_caps;
    cmd->nss = arg->peer_num_spatial_streams;
    cmd->vht_caps = arg->peer_vht_caps;
    cmd->phy_mode = arg->peer_phymode;
    cmd->num_legacy_rates = arg->peer_legacy_rates.num_rates;
    cmd->num_ht_rates = arg->peer_ht_rates.num_rates;
    memcpy(cmd->mac_addr.addr, arg->addr, ETH_ALEN);

    ptr = ath10k_msg_buf_get_payload(msg_buf);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_BYTE;
    tlv->len = legacy_rate_len;
    memcpy(tlv->value, arg->peer_legacy_rates.rates, arg->peer_legacy_rates.num_rates);

    ptr += sizeof(*tlv);
    ptr += legacy_rate_len;

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_BYTE;
    tlv->len = ht_rate_len;
    memcpy(tlv->value, arg->peer_ht_rates.rates, arg->peer_ht_rates.num_rates);

    ptr += sizeof(*tlv);
    ptr += ht_rate_len;

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_VHT_RATE_SET;
    tlv->len = sizeof(*vht_rate);
    vht_rate = (void*)tlv->value;

    vht_rate->rx_max_rate = arg->peer_vht_rates.rx_max_rate;
    vht_rate->rx_mcs_set = arg->peer_vht_rates.rx_mcs_set;
    vht_rate->tx_max_rate = arg->peer_vht_rates.tx_max_rate;
    vht_rate->tx_mcs_set = arg->peer_vht_rates.tx_mcs_set;

    ptr += sizeof(*tlv);
    ptr += sizeof(*vht_rate);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv peer assoc\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

#if 0   // NEEDS PORTING
static struct sk_buff*
ath10k_wmi_tlv_op_gen_set_psmode(struct ath10k* ar, uint32_t vdev_id,
                                 enum wmi_sta_ps_mode psmode) {
    struct wmi_sta_powersave_mode_cmd* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;

    skb = ath10k_wmi_alloc_skb(ar, sizeof(*tlv) + sizeof(*cmd));
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    tlv = (void*)skb->data;
    tlv->tag = WMI_TLV_TAG_STRUCT_STA_POWERSAVE_MODE_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->vdev_id = vdev_id;
    cmd->sta_ps_mode = psmode;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv set psmode\n");
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_set_sta_ps(struct ath10k* ar, uint32_t vdev_id,
                                 enum wmi_sta_powersave_param param_id,
                                 uint32_t param_value) {
    struct wmi_sta_powersave_param_cmd* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;

    skb = ath10k_wmi_alloc_skb(ar, sizeof(*tlv) + sizeof(*cmd));
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    tlv = (void*)skb->data;
    tlv->tag = WMI_TLV_TAG_STRUCT_STA_POWERSAVE_PARAM_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->vdev_id = vdev_id;
    cmd->param_id = param_id;
    cmd->param_value = param_value;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv set sta ps\n");
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_set_ap_ps(struct ath10k* ar, uint32_t vdev_id, const uint8_t* mac,
                                enum wmi_ap_ps_peer_param param_id, uint32_t value) {
    struct wmi_ap_ps_peer_cmd* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;

    if (!mac) {
        return ERR_PTR(-EINVAL);
    }

    skb = ath10k_wmi_alloc_skb(ar, sizeof(*tlv) + sizeof(*cmd));
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    tlv = (void*)skb->data;
    tlv->tag = WMI_TLV_TAG_STRUCT_AP_PS_PEER_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->vdev_id = vdev_id;
    cmd->param_id = param_id;
    cmd->param_value = value;
    memcpy(cmd->peer_macaddr.addr, mac, ETH_ALEN);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv ap ps param\n");
    return skb;
}
#endif  // NEEDS PORTING

zx_status_t ath10k_wmi_tlv_op_gen_scan_chan_list(struct ath10k* ar,
                                                 struct ath10k_msg_buf** msg_buf_ptr,
                                                 const struct wmi_scan_chan_list_arg* arg) {
    size_t chans_len = arg->n_channels * (sizeof(struct wmi_tlv) + sizeof(struct wmi_channel));
    size_t extra = sizeof(struct wmi_tlv) + chans_len;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status =
        ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_SCAN_CHAN_LIST, extra);
    if (status != ZX_OK) { return status; }

    struct wmi_tlv* tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_SCAN_CHAN_LIST_CMD;
    tlv->len = sizeof(struct wmi_tlv_scan_chan_list_cmd);

    struct wmi_tlv_scan_chan_list_cmd* cmd;
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_SCAN_CHAN_LIST);
    cmd->num_scan_chans = arg->n_channels;

    tlv = ath10k_msg_buf_get_payload(msg_buf);
    tlv->tag = WMI_TLV_TAG_ARRAY_STRUCT;
    tlv->len = chans_len;
    void* chans = tlv->value;

    for (unsigned i = 0; i < arg->n_channels; i++) {
        struct wmi_channel_arg* ch = &arg->channels[i];

        tlv = chans;
        tlv->tag = WMI_TLV_TAG_STRUCT_CHANNEL;
        tlv->len = sizeof(struct wmi_channel);
        struct wmi_channel* ci = (void*)tlv->value;

        ath10k_wmi_put_wmi_channel(ci, ch);

        chans += sizeof(*tlv);
        chans += sizeof(*ci);
    }

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv scan chan list\n");
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

#if 0   // NEEDS PORTING
static struct sk_buff*
ath10k_wmi_tlv_op_gen_beacon_dma(struct ath10k* ar, uint32_t vdev_id,
                                 const void* bcn, size_t bcn_len,
                                 uint32_t bcn_paddr, bool dtim_zero,
                                 bool deliver_cab)

{
    struct wmi_bcn_tx_ref_cmd* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    struct ieee80211_hdr* hdr;
    uint16_t fc;

    skb = ath10k_wmi_alloc_skb(ar, sizeof(*tlv) + sizeof(*cmd));
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    hdr = (struct ieee80211_hdr*)bcn;
    fc = hdr->frame_control;

    tlv = (void*)skb->data;
    tlv->tag = WMI_TLV_TAG_STRUCT_BCN_SEND_FROM_HOST_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->vdev_id = vdev_id;
    cmd->data_len = bcn_len;
    cmd->data_ptr = bcn_paddr;
    cmd->msdu_id = 0;
    cmd->frame_control = fc;
    cmd->flags = 0;

    if (dtim_zero) {
        cmd->flags |= WMI_BCN_TX_REF_FLAG_DTIM_ZERO;
    }

    if (deliver_cab) {
        cmd->flags |= WMI_BCN_TX_REF_FLAG_DELIVER_CAB;
    }

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv beacon dma\n");
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_pdev_set_wmm(struct ath10k* ar,
                                   const struct wmi_wmm_params_all_arg* arg) {
    struct wmi_tlv_pdev_set_wmm_cmd* cmd;
    struct wmi_wmm_params* wmm;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    size_t len;
    void* ptr;

    len = (sizeof(*tlv) + sizeof(*cmd)) +
          (4 * (sizeof(*tlv) + sizeof(*wmm)));
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    ptr = (void*)skb->data;

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_PDEV_SET_WMM_PARAMS_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;

    /* nothing to set here */

    ptr += sizeof(*tlv);
    ptr += sizeof(*cmd);

    ptr = ath10k_wmi_tlv_put_wmm(ptr, &arg->ac_be);
    ptr = ath10k_wmi_tlv_put_wmm(ptr, &arg->ac_bk);
    ptr = ath10k_wmi_tlv_put_wmm(ptr, &arg->ac_vi);
    ptr = ath10k_wmi_tlv_put_wmm(ptr, &arg->ac_vo);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv pdev set wmm\n");
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_request_stats(struct ath10k* ar, uint32_t stats_mask) {
    struct wmi_request_stats_cmd* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;

    skb = ath10k_wmi_alloc_skb(ar, sizeof(*tlv) + sizeof(*cmd));
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    tlv = (void*)skb->data;
    tlv->tag = WMI_TLV_TAG_STRUCT_REQUEST_STATS_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->stats_id = stats_mask;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv request stats\n");
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_force_fw_hang(struct ath10k* ar,
                                    enum wmi_force_fw_hang_type type,
                                    uint32_t delay_ms) {
    struct wmi_force_fw_hang_cmd* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;

    skb = ath10k_wmi_alloc_skb(ar, sizeof(*tlv) + sizeof(*cmd));
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    tlv = (void*)skb->data;
    tlv->tag = WMI_TLV_TAG_STRUCT_FORCE_FW_HANG_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->type = type;
    cmd->delay_ms = delay_ms;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv force fw hang\n");
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_dbglog_cfg(struct ath10k* ar, uint64_t module_enable,
                                 uint32_t log_level) {
    struct wmi_tlv_dbglog_cmd* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    size_t len, bmap_len;
    uint32_t value;
    void* ptr;

    if (module_enable) {
        value = WMI_TLV_DBGLOG_LOG_LEVEL_VALUE(
                    module_enable,
                    WMI_TLV_DBGLOG_LOG_LEVEL_VERBOSE);
    } else {
        value = WMI_TLV_DBGLOG_LOG_LEVEL_VALUE(
                    WMI_TLV_DBGLOG_ALL_MODULES,
                    WMI_TLV_DBGLOG_LOG_LEVEL_WARN);
    }

    bmap_len = 0;
    len = sizeof(*tlv) + sizeof(*cmd) + sizeof(*tlv) + bmap_len;
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    ptr = (void*)skb->data;

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_DEBUG_LOG_CONFIG_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->param = WMI_TLV_DBGLOG_PARAM_LOG_LEVEL;
    cmd->value = value;

    ptr += sizeof(*tlv);
    ptr += sizeof(*cmd);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_UINT32;
    tlv->len = bmap_len;

    /* nothing to do here */

    ptr += sizeof(*tlv);
    ptr += sizeof(bmap_len);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv dbglog value 0x%08x\n", value);
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_pktlog_enable(struct ath10k* ar, uint32_t filter) {
    struct wmi_tlv_pktlog_enable* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    void* ptr;
    size_t len;

    len = sizeof(*tlv) + sizeof(*cmd);
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    ptr = (void*)skb->data;
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_PDEV_PKTLOG_ENABLE_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->filter = filter;

    ptr += sizeof(*tlv);
    ptr += sizeof(*cmd);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv pktlog enable filter 0x%08x\n",
               filter);
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_pktlog_disable(struct ath10k* ar) {
    struct wmi_tlv_pktlog_disable* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    void* ptr;
    size_t len;

    len = sizeof(*tlv) + sizeof(*cmd);
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    ptr = (void*)skb->data;
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_PDEV_PKTLOG_DISABLE_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;

    ptr += sizeof(*tlv);
    ptr += sizeof(*cmd);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv pktlog disable\n");
    return skb;
}
#endif // NEEDS PORTING

static zx_status_t
ath10k_wmi_tlv_op_gen_bcn_tmpl(struct ath10k* ar, struct ath10k_msg_buf** msg_buf_ptr,
                               uint32_t vdev_id, uint32_t tim_ie_offset, struct ath10k_msg_buf* bcn,
                               uint32_t prb_caps, uint32_t prb_erp, void* prb_ies,
                               size_t prb_ies_len) {

    struct wmi_tlv_bcn_tmpl_cmd* cmd;
    struct wmi_tlv_bcn_prb_info* info;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    void* ptr;
    size_t len;
    zx_status_t status;

    if (COND_WARN(prb_ies_len > 0 && !prb_ies)) {
        return ZX_ERR_INVALID_ARGS;
    }

    len = sizeof(*tlv) + sizeof(*info) + prb_ies_len +
          sizeof(*tlv) + ROUNDUP(bcn->used, 4);
    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_BCN_TMPL, len);
    if (status != ZX_OK) {
        return ZX_ERR_NO_MEMORY;
    }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_BCN_TMPL_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_BCN_TMPL);
    cmd->vdev_id = vdev_id;
    cmd->tim_ie_offset = tim_ie_offset;
    cmd->buf_len = bcn->used;

    ptr = ath10k_msg_buf_get_payload(msg_buf);

    /* FIXME: prb_ies_len should be probably aligned to 4byte boundary but
     * then it is then impossible to pass original ie len.
     * This chunk is not used yet so if setting probe resp template yields
     * problems with beaconing or crashes firmware look here.
     */
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_BCN_PRB_INFO_CMD;
    tlv->len = sizeof(*info) + prb_ies_len;
    info = (void*)tlv->value;
    info->caps = prb_caps;
    info->erp = prb_erp;
    memcpy(info->ies, prb_ies, prb_ies_len);

    // Move the pointer to the end of preb_ies.
    ptr += sizeof(*tlv);
    ptr += sizeof(*info);
    ptr += prb_ies_len;

    // Fill up the |bcn| passed to this function.
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_BYTE;
    tlv->len = ROUNDUP(bcn->used, 4);
    memcpy(tlv->value, bcn->vaddr, bcn->used);

    /* FIXME: Adjust TSF? */

    *msg_buf_ptr = msg_buf;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv bcn tmpl vdev_id %i\n",
               vdev_id);
    return ZX_OK;
}

static zx_status_t
ath10k_wmi_tlv_op_gen_prb_tmpl(struct ath10k* ar, struct ath10k_msg_buf** msg_buf_ptr,
                               uint32_t vdev_id,
                               struct ath10k_msg_buf* prb) {
    struct wmi_tlv_prb_tmpl_cmd* cmd;
    struct wmi_tlv_bcn_prb_info* info;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;
    void* ptr;
    size_t len;

    len = sizeof(*tlv) + sizeof(*info) +
          sizeof(*tlv) + ROUNDUP(prb->used, 4);
    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PRB_TMPL, len);
    if (status != ZX_OK) {
        return ZX_ERR_NO_MEMORY;
    }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_PRB_TMPL_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_PRB_TMPL);
    cmd->vdev_id = vdev_id;
    cmd->buf_len = prb->used;

    ptr = ath10k_msg_buf_get_payload(msg_buf);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_BCN_PRB_INFO_CMD;
    tlv->len = sizeof(*info);
    info = (void*)tlv->value;
    info->caps = 0;
    info->erp = 0;

    // Move the pointer to the end of PRB_INFO.
    ptr += sizeof(*tlv);
    ptr += sizeof(*info);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_BYTE;
    tlv->len = ROUNDUP(prb->used, 4);
    memcpy(tlv->value, prb->vaddr, prb->used);

    *msg_buf_ptr = msg_buf;
    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv prb tmpl vdev_id %i\n",
               vdev_id);
    return ZX_OK;
}

#if 0// NEEDS PORTING
// This function will compose a p2p go beacon and return in 'buf'.
static struct sk_buff*
ath10k_wmi_tlv_op_gen_p2p_go_bcn_ie(struct ath10k* ar, uint32_t vdev_id,
                                    const uint8_t* p2p_ie) {
    struct wmi_tlv_p2p_go_bcn_ie* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    void* ptr;
    size_t len;

    len = sizeof(*tlv) + sizeof(*cmd) +
          sizeof(*tlv) + ROUNDUP(p2p_ie[1] + 2, 4);
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    ptr = (void*)skb->data;
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_P2P_GO_SET_BEACON_IE;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->vdev_id = vdev_id;
    cmd->ie_len = p2p_ie[1] + 2;

    ptr += sizeof(*tlv);
    ptr += sizeof(*cmd);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_BYTE;
    tlv->len = ROUNDUP(p2p_ie[1] + 2, 4);
    memcpy(tlv->value, p2p_ie, p2p_ie[1] + 2);

    ptr += sizeof(*tlv);
    ptr += ROUNDUP(p2p_ie[1] + 2, 4);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv p2p go bcn ie for vdev %i\n",
               vdev_id);
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_update_fw_tdls_state(struct ath10k* ar, uint32_t vdev_id,
        enum wmi_tdls_state state) {
    struct wmi_tdls_set_state_cmd* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    void* ptr;
    size_t len;
    /* Set to options from wmi_tlv_tdls_options,
     * for now none of them are enabled.
     */
    uint32_t options = 0;

    len = sizeof(*tlv) + sizeof(*cmd);
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    ptr = (void*)skb->data;
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_TDLS_SET_STATE_CMD;
    tlv->len = sizeof(*cmd);

    cmd = (void*)tlv->value;
    cmd->vdev_id = vdev_id;
    cmd->state = state;
    cmd->notification_interval_ms = 5000;
    cmd->tx_discovery_threshold = 100;
    cmd->tx_teardown_threshold = 5;
    cmd->rssi_teardown_threshold = -75;
    cmd->rssi_delta = -20;
    cmd->tdls_options = options;
    cmd->tdls_peer_traffic_ind_window = 2;
    cmd->tdls_peer_traffic_response_timeout_ms = 5000;
    cmd->tdls_puapsd_mask = 0xf;
    cmd->tdls_puapsd_inactivity_time_ms = 0;
    cmd->tdls_puapsd_rx_frame_threshold = 10;

    ptr += sizeof(*tlv);
    ptr += sizeof(*cmd);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv update fw tdls state %d for vdev %i\n",
               state, vdev_id);
    return skb;
}

static uint32_t ath10k_wmi_tlv_prepare_peer_qos(uint8_t uapsd_queues, uint8_t sp) {
    uint32_t peer_qos = 0;

    if (uapsd_queues & IEEE80211_WMM_IE_STA_QOSINFO_AC_VO) {
        peer_qos |= WMI_TLV_TDLS_PEER_QOS_AC_VO;
    }
    if (uapsd_queues & IEEE80211_WMM_IE_STA_QOSINFO_AC_VI) {
        peer_qos |= WMI_TLV_TDLS_PEER_QOS_AC_VI;
    }
    if (uapsd_queues & IEEE80211_WMM_IE_STA_QOSINFO_AC_BK) {
        peer_qos |= WMI_TLV_TDLS_PEER_QOS_AC_BK;
    }
    if (uapsd_queues & IEEE80211_WMM_IE_STA_QOSINFO_AC_BE) {
        peer_qos |= WMI_TLV_TDLS_PEER_QOS_AC_BE;
    }

    peer_qos |= SM(sp, WMI_TLV_TDLS_PEER_SP);

    return peer_qos;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_tdls_peer_update(struct ath10k* ar,
                                       const struct wmi_tdls_peer_update_cmd_arg* arg,
                                       const struct wmi_tdls_peer_capab_arg* cap,
                                       const struct wmi_channel_arg* chan_arg) {
    struct wmi_tdls_peer_update_cmd* cmd;
    struct wmi_tdls_peer_capab* peer_cap;
    struct wmi_channel* chan;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    uint32_t peer_qos;
    void* ptr;
    int len;
    int i;

    len = sizeof(*tlv) + sizeof(*cmd) +
          sizeof(*tlv) + sizeof(*peer_cap) +
          sizeof(*tlv) + cap->peer_chan_len * sizeof(*chan);

    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    ptr = (void*)skb->data;
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_TDLS_PEER_UPDATE_CMD;
    tlv->len = sizeof(*cmd);

    cmd = (void*)tlv->value;
    cmd->vdev_id = arg->vdev_id;
    memcpy(cmd->peer_macaddr.addr, arg->addr, ETH_ALEN);
    cmd->peer_state = arg->peer_state;

    ptr += sizeof(*tlv);
    ptr += sizeof(*cmd);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_TDLS_PEER_CAPABILITIES;
    tlv->len = sizeof(*peer_cap);
    peer_cap = (void*)tlv->value;
    peer_qos = ath10k_wmi_tlv_prepare_peer_qos(cap->peer_uapsd_queues,
               cap->peer_max_sp);
    peer_cap->peer_qos = peer_qos;
    peer_cap->buff_sta_support = cap->buff_sta_support;
    peer_cap->off_chan_support = cap->off_chan_support;
    peer_cap->peer_curr_operclass = cap->peer_curr_operclass;
    peer_cap->self_curr_operclass = cap->self_curr_operclass;
    peer_cap->peer_chan_len = cap->peer_chan_len;
    peer_cap->peer_operclass_len = cap->peer_operclass_len;

    for (i = 0; i < WMI_TDLS_MAX_SUPP_OPER_CLASSES; i++) {
        peer_cap->peer_operclass[i] = cap->peer_operclass[i];
    }

    peer_cap->is_peer_responder = cap->is_peer_responder;
    peer_cap->pref_offchan_num = cap->pref_offchan_num;
    peer_cap->pref_offchan_bw = cap->pref_offchan_bw;

    ptr += sizeof(*tlv);
    ptr += sizeof(*peer_cap);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_STRUCT;
    tlv->len = cap->peer_chan_len * sizeof(*chan);

    ptr += sizeof(*tlv);

    for (i = 0; i < cap->peer_chan_len; i++) {
        tlv = ptr;
        tlv->tag = WMI_TLV_TAG_STRUCT_CHANNEL;
        tlv->len = sizeof(*chan);
        chan = (void*)tlv->value;
        ath10k_wmi_put_wmi_channel(chan, &chan_arg[i]);

        ptr += sizeof(*tlv);
        ptr += sizeof(*chan);
    }

    ath10k_dbg(ar, ATH10K_DBG_WMI,
               "wmi tlv tdls peer update vdev %i state %d n_chans %u\n",
               arg->vdev_id, arg->peer_state, cap->peer_chan_len);
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_wow_enable(struct ath10k* ar) {
    struct wmi_tlv_wow_enable_cmd* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    size_t len;

    len = sizeof(*tlv) + sizeof(*cmd);
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    tlv = (struct wmi_tlv*)skb->data;
    tlv->tag = WMI_TLV_TAG_STRUCT_WOW_ENABLE_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;

    cmd->enable = 1;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv wow enable\n");
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_wow_add_wakeup_event(struct ath10k* ar,
        uint32_t vdev_id,
        enum wmi_wow_wakeup_event event,
        uint32_t enable) {
    struct wmi_tlv_wow_add_del_event_cmd* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    size_t len;

    len = sizeof(*tlv) + sizeof(*cmd);
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    tlv = (struct wmi_tlv*)skb->data;
    tlv->tag = WMI_TLV_TAG_STRUCT_WOW_ADD_DEL_EVT_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;

    cmd->vdev_id = vdev_id;
    cmd->is_add = enable;
    cmd->event_bitmap = 1 << event;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv wow add wakeup event %s enable %d vdev_id %d\n",
               wow_wakeup_event(event), enable, vdev_id);
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_gen_wow_host_wakeup_ind(struct ath10k* ar) {
    struct wmi_tlv_wow_host_wakeup_ind* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    size_t len;

    len = sizeof(*tlv) + sizeof(*cmd);
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    tlv = (struct wmi_tlv*)skb->data;
    tlv->tag = WMI_TLV_TAG_STRUCT_WOW_HOSTWAKEUP_FROM_SLEEP_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv wow host wakeup ind\n");
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_wow_add_pattern(struct ath10k* ar, uint32_t vdev_id,
                                      uint32_t pattern_id, const uint8_t* pattern,
                                      const uint8_t* bitmask, int pattern_len,
                                      int pattern_offset) {
    struct wmi_tlv_wow_add_pattern_cmd* cmd;
    struct wmi_tlv_wow_bitmap_pattern* bitmap;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    void* ptr;
    size_t len;

    len = sizeof(*tlv) + sizeof(*cmd) +
          sizeof(*tlv) +                     /* array struct */
          sizeof(*tlv) + sizeof(*bitmap) +   /* bitmap */
          sizeof(*tlv) +                     /* empty ipv4 sync */
          sizeof(*tlv) +                     /* empty ipv6 sync */
          sizeof(*tlv) +                     /* empty magic */
          sizeof(*tlv) +                     /* empty info timeout */
          sizeof(*tlv) + sizeof(uint32_t);   /* ratelimit interval */

    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    /* cmd */
    ptr = (void*)skb->data;
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_WOW_ADD_PATTERN_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;

    cmd->vdev_id = vdev_id;
    cmd->pattern_id = pattern_id;
    cmd->pattern_type = WOW_BITMAP_PATTERN;

    ptr += sizeof(*tlv);
    ptr += sizeof(*cmd);

    /* bitmap */
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_STRUCT;
    tlv->len = sizeof(*tlv) + sizeof(*bitmap);

    ptr += sizeof(*tlv);

    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_WOW_BITMAP_PATTERN_T;
    tlv->len = sizeof(*bitmap);
    bitmap = (void*)tlv->value;

    memcpy(bitmap->patternbuf, pattern, pattern_len);
    memcpy(bitmap->bitmaskbuf, bitmask, pattern_len);
    bitmap->pattern_offset = pattern_offset;
    bitmap->pattern_len = pattern_len;
    bitmap->bitmask_len = pattern_len;
    bitmap->pattern_id = pattern_id;

    ptr += sizeof(*tlv);
    ptr += sizeof(*bitmap);

    /* ipv4 sync */
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_STRUCT;
    tlv->len = 0;

    ptr += sizeof(*tlv);

    /* ipv6 sync */
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_STRUCT;
    tlv->len = 0;

    ptr += sizeof(*tlv);

    /* magic */
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_STRUCT;
    tlv->len = 0;

    ptr += sizeof(*tlv);

    /* pattern info timeout */
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_UINT32;
    tlv->len = 0;

    ptr += sizeof(*tlv);

    /* ratelimit interval */
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_ARRAY_UINT32;
    tlv->len = sizeof(uint32_t);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv wow add pattern vdev_id %d pattern_id %d, pattern_offset %d\n",
               vdev_id, pattern_id, pattern_offset);
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_wow_del_pattern(struct ath10k* ar, uint32_t vdev_id,
                                      uint32_t pattern_id) {
    struct wmi_tlv_wow_del_pattern_cmd* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    size_t len;

    len = sizeof(*tlv) + sizeof(*cmd);
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    tlv = (struct wmi_tlv*)skb->data;
    tlv->tag = WMI_TLV_TAG_STRUCT_WOW_DEL_PATTERN_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;

    cmd->vdev_id = vdev_id;
    cmd->pattern_id = pattern_id;
    cmd->pattern_type = WOW_BITMAP_PATTERN;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv wow del pattern vdev_id %d pattern_id %d\n",
               vdev_id, pattern_id);
    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_adaptive_qcs(struct ath10k* ar, bool enable) {
    struct wmi_tlv_adaptive_qcs* cmd;
    struct wmi_tlv* tlv;
    struct sk_buff* skb;
    void* ptr;
    size_t len;

    len = sizeof(*tlv) + sizeof(*cmd);
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    ptr = (void*)skb->data;
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_RESMGR_ADAPTIVE_OCS_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->enable = enable ? 1 : 0;

    ptr += sizeof(*tlv);
    ptr += sizeof(*cmd);

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv adaptive qcs %d\n", enable);
    return skb;
}
#endif  // NEEDS PORTING

static zx_status_t ath10k_wmi_tlv_op_gen_echo(struct ath10k* ar,
                                              struct ath10k_msg_buf** msg_buf_ptr, uint32_t value) {
    struct wmi_echo_cmd* cmd;
    struct wmi_tlv* tlv;
    struct ath10k_msg_buf* msg_buf;
    zx_status_t status;

    status = ath10k_msg_buf_alloc(ar, &msg_buf, ATH10K_MSG_TYPE_WMI_TLV_ECHO_CMD, 0);
    if (status != ZX_OK) { return status; }

    tlv = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV);
    tlv->tag = WMI_TLV_TAG_STRUCT_ECHO_CMD;
    tlv->len = sizeof(*cmd);
    cmd = ath10k_msg_buf_get_header(msg_buf, ATH10K_MSG_TYPE_WMI_TLV_ECHO_CMD);
    cmd->value = value;

    ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv echo value 0x%08x\n", value);
    *msg_buf_ptr = msg_buf;
    return ZX_OK;
}

#if 0   // NEEDS PORTING
static struct sk_buff*
ath10k_wmi_tlv_op_gen_vdev_spectral_conf(struct ath10k* ar,
        const struct wmi_vdev_spectral_conf_arg* arg) {
    struct wmi_vdev_spectral_conf_cmd* cmd;
    struct sk_buff* skb;
    struct wmi_tlv* tlv;
    void* ptr;
    size_t len;

    len = sizeof(*tlv) + sizeof(*cmd);
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    ptr = (void*)skb->data;
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_VDEV_SPECTRAL_CONFIGURE_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->vdev_id = arg->vdev_id;
    cmd->scan_count = arg->scan_count;
    cmd->scan_period = arg->scan_period;
    cmd->scan_priority = arg->scan_priority;
    cmd->scan_fft_size = arg->scan_fft_size;
    cmd->scan_gc_ena = arg->scan_gc_ena;
    cmd->scan_restart_ena = arg->scan_restart_ena;
    cmd->scan_noise_floor_ref = arg->scan_noise_floor_ref;
    cmd->scan_init_delay = arg->scan_init_delay;
    cmd->scan_nb_tone_thr = arg->scan_nb_tone_thr;
    cmd->scan_str_bin_thr = arg->scan_str_bin_thr;
    cmd->scan_wb_rpt_mode = arg->scan_wb_rpt_mode;
    cmd->scan_rssi_rpt_mode = arg->scan_rssi_rpt_mode;
    cmd->scan_rssi_thr = arg->scan_rssi_thr;
    cmd->scan_pwr_format = arg->scan_pwr_format;
    cmd->scan_rpt_mode = arg->scan_rpt_mode;
    cmd->scan_bin_scale = arg->scan_bin_scale;
    cmd->scan_dbm_adj = arg->scan_dbm_adj;
    cmd->scan_chn_mask = arg->scan_chn_mask;

    return skb;
}

static struct sk_buff*
ath10k_wmi_tlv_op_gen_vdev_spectral_enable(struct ath10k* ar, uint32_t vdev_id,
                                           uint32_t trigger, uint32_t enable) {
    struct wmi_vdev_spectral_enable_cmd* cmd;
    struct sk_buff* skb;
    struct wmi_tlv* tlv;
    void* ptr;
    size_t len;

    len = sizeof(*tlv) + sizeof(*cmd);
    skb = ath10k_wmi_alloc_skb(ar, len);
    if (!skb) {
        return ERR_PTR(-ENOMEM);
    }

    ptr = (void*)skb->data;
    tlv = ptr;
    tlv->tag = WMI_TLV_TAG_STRUCT_VDEV_SPECTRAL_ENABLE_CMD;
    tlv->len = sizeof(*cmd);
    cmd = (void*)tlv->value;
    cmd->vdev_id = vdev_id;
    cmd->trigger_cmd = trigger;
    cmd->enable_cmd = enable;

    return skb;
}
#endif  // NEEDS PORTING

/****************/
/* TLV mappings */
/****************/

static struct wmi_cmd_map wmi_tlv_cmd_map = {
    .init_cmdid = WMI_TLV_INIT_CMDID,
    .start_scan_cmdid = WMI_TLV_START_SCAN_CMDID,
    .stop_scan_cmdid = WMI_TLV_STOP_SCAN_CMDID,
    .scan_chan_list_cmdid = WMI_TLV_SCAN_CHAN_LIST_CMDID,
    .scan_sch_prio_tbl_cmdid = WMI_TLV_SCAN_SCH_PRIO_TBL_CMDID,
    .pdev_set_regdomain_cmdid = WMI_TLV_PDEV_SET_REGDOMAIN_CMDID,
    .pdev_set_channel_cmdid = WMI_TLV_PDEV_SET_CHANNEL_CMDID,
    .pdev_set_param_cmdid = WMI_TLV_PDEV_SET_PARAM_CMDID,
    .pdev_pktlog_enable_cmdid = WMI_TLV_PDEV_PKTLOG_ENABLE_CMDID,
    .pdev_pktlog_disable_cmdid = WMI_TLV_PDEV_PKTLOG_DISABLE_CMDID,
    .pdev_set_wmm_params_cmdid = WMI_TLV_PDEV_SET_WMM_PARAMS_CMDID,
    .pdev_set_ht_cap_ie_cmdid = WMI_TLV_PDEV_SET_HT_CAP_IE_CMDID,
    .pdev_set_vht_cap_ie_cmdid = WMI_TLV_PDEV_SET_VHT_CAP_IE_CMDID,
    .pdev_set_dscp_tid_map_cmdid = WMI_TLV_PDEV_SET_DSCP_TID_MAP_CMDID,
    .pdev_set_quiet_mode_cmdid = WMI_TLV_PDEV_SET_QUIET_MODE_CMDID,
    .pdev_green_ap_ps_enable_cmdid = WMI_TLV_PDEV_GREEN_AP_PS_ENABLE_CMDID,
    .pdev_get_tpc_config_cmdid = WMI_TLV_PDEV_GET_TPC_CONFIG_CMDID,
    .pdev_set_base_macaddr_cmdid = WMI_TLV_PDEV_SET_BASE_MACADDR_CMDID,
    .vdev_create_cmdid = WMI_TLV_VDEV_CREATE_CMDID,
    .vdev_delete_cmdid = WMI_TLV_VDEV_DELETE_CMDID,
    .vdev_start_request_cmdid = WMI_TLV_VDEV_START_REQUEST_CMDID,
    .vdev_restart_request_cmdid = WMI_TLV_VDEV_RESTART_REQUEST_CMDID,
    .vdev_up_cmdid = WMI_TLV_VDEV_UP_CMDID,
    .vdev_stop_cmdid = WMI_TLV_VDEV_STOP_CMDID,
    .vdev_down_cmdid = WMI_TLV_VDEV_DOWN_CMDID,
    .vdev_set_param_cmdid = WMI_TLV_VDEV_SET_PARAM_CMDID,
    .vdev_install_key_cmdid = WMI_TLV_VDEV_INSTALL_KEY_CMDID,
    .peer_create_cmdid = WMI_TLV_PEER_CREATE_CMDID,
    .peer_delete_cmdid = WMI_TLV_PEER_DELETE_CMDID,
    .peer_flush_tids_cmdid = WMI_TLV_PEER_FLUSH_TIDS_CMDID,
    .peer_set_param_cmdid = WMI_TLV_PEER_SET_PARAM_CMDID,
    .peer_assoc_cmdid = WMI_TLV_PEER_ASSOC_CMDID,
    .peer_add_wds_entry_cmdid = WMI_TLV_PEER_ADD_WDS_ENTRY_CMDID,
    .peer_remove_wds_entry_cmdid = WMI_TLV_PEER_REMOVE_WDS_ENTRY_CMDID,
    .peer_mcast_group_cmdid = WMI_TLV_PEER_MCAST_GROUP_CMDID,
    .bcn_tx_cmdid = WMI_TLV_BCN_TX_CMDID,
    .pdev_send_bcn_cmdid = WMI_TLV_PDEV_SEND_BCN_CMDID,
    .bcn_tmpl_cmdid = WMI_TLV_BCN_TMPL_CMDID,
    .bcn_filter_rx_cmdid = WMI_TLV_BCN_FILTER_RX_CMDID,
    .prb_req_filter_rx_cmdid = WMI_TLV_PRB_REQ_FILTER_RX_CMDID,
    .mgmt_tx_cmdid = WMI_TLV_MGMT_TX_CMDID,
    .prb_tmpl_cmdid = WMI_TLV_PRB_TMPL_CMDID,
    .addba_clear_resp_cmdid = WMI_TLV_ADDBA_CLEAR_RESP_CMDID,
    .addba_send_cmdid = WMI_TLV_ADDBA_SEND_CMDID,
    .addba_status_cmdid = WMI_TLV_ADDBA_STATUS_CMDID,
    .delba_send_cmdid = WMI_TLV_DELBA_SEND_CMDID,
    .addba_set_resp_cmdid = WMI_TLV_ADDBA_SET_RESP_CMDID,
    .send_singleamsdu_cmdid = WMI_TLV_SEND_SINGLEAMSDU_CMDID,
    .sta_powersave_mode_cmdid = WMI_TLV_STA_POWERSAVE_MODE_CMDID,
    .sta_powersave_param_cmdid = WMI_TLV_STA_POWERSAVE_PARAM_CMDID,
    .sta_mimo_ps_mode_cmdid = WMI_TLV_STA_MIMO_PS_MODE_CMDID,
    .pdev_dfs_enable_cmdid = WMI_TLV_PDEV_DFS_ENABLE_CMDID,
    .pdev_dfs_disable_cmdid = WMI_TLV_PDEV_DFS_DISABLE_CMDID,
    .roam_scan_mode = WMI_TLV_ROAM_SCAN_MODE,
    .roam_scan_rssi_threshold = WMI_TLV_ROAM_SCAN_RSSI_THRESHOLD,
    .roam_scan_period = WMI_TLV_ROAM_SCAN_PERIOD,
    .roam_scan_rssi_change_threshold = WMI_TLV_ROAM_SCAN_RSSI_CHANGE_THRESHOLD,
    .roam_ap_profile = WMI_TLV_ROAM_AP_PROFILE,
    .ofl_scan_add_ap_profile = WMI_TLV_ROAM_AP_PROFILE,
    .ofl_scan_remove_ap_profile = WMI_TLV_OFL_SCAN_REMOVE_AP_PROFILE,
    .ofl_scan_period = WMI_TLV_OFL_SCAN_PERIOD,
    .p2p_dev_set_device_info = WMI_TLV_P2P_DEV_SET_DEVICE_INFO,
    .p2p_dev_set_discoverability = WMI_TLV_P2P_DEV_SET_DISCOVERABILITY,
    .p2p_go_set_beacon_ie = WMI_TLV_P2P_GO_SET_BEACON_IE_CMDID,
    .p2p_go_set_probe_resp_ie = WMI_TLV_P2P_GO_SET_PROBE_RESP_IE,
    .p2p_set_vendor_ie_data_cmdid = WMI_TLV_P2P_SET_VENDOR_IE_DATA_CMDID,
    .ap_ps_peer_param_cmdid = WMI_TLV_AP_PS_PEER_PARAM_CMDID,
    .ap_ps_peer_uapsd_coex_cmdid = WMI_TLV_AP_PS_PEER_UAPSD_COEX_CMDID,
    .peer_rate_retry_sched_cmdid = WMI_TLV_PEER_RATE_RETRY_SCHED_CMDID,
    .wlan_profile_trigger_cmdid = WMI_TLV_WLAN_PROFILE_TRIGGER_CMDID,
    .wlan_profile_set_hist_intvl_cmdid = WMI_TLV_WLAN_PROFILE_SET_HIST_INTVL_CMDID,
    .wlan_profile_get_profile_data_cmdid = WMI_TLV_WLAN_PROFILE_GET_PROFILE_DATA_CMDID,
    .wlan_profile_enable_profile_id_cmdid = WMI_TLV_WLAN_PROFILE_ENABLE_PROFILE_ID_CMDID,
    .wlan_profile_list_profile_id_cmdid = WMI_TLV_WLAN_PROFILE_LIST_PROFILE_ID_CMDID,
    .pdev_suspend_cmdid = WMI_TLV_PDEV_SUSPEND_CMDID,
    .pdev_resume_cmdid = WMI_TLV_PDEV_RESUME_CMDID,
    .add_bcn_filter_cmdid = WMI_TLV_ADD_BCN_FILTER_CMDID,
    .rmv_bcn_filter_cmdid = WMI_TLV_RMV_BCN_FILTER_CMDID,
    .wow_add_wake_pattern_cmdid = WMI_TLV_WOW_ADD_WAKE_PATTERN_CMDID,
    .wow_del_wake_pattern_cmdid = WMI_TLV_WOW_DEL_WAKE_PATTERN_CMDID,
    .wow_enable_disable_wake_event_cmdid = WMI_TLV_WOW_ENABLE_DISABLE_WAKE_EVENT_CMDID,
    .wow_enable_cmdid = WMI_TLV_WOW_ENABLE_CMDID,
    .wow_hostwakeup_from_sleep_cmdid = WMI_TLV_WOW_HOSTWAKEUP_FROM_SLEEP_CMDID,
    .rtt_measreq_cmdid = WMI_TLV_RTT_MEASREQ_CMDID,
    .rtt_tsf_cmdid = WMI_TLV_RTT_TSF_CMDID,
    .vdev_spectral_scan_configure_cmdid = WMI_TLV_SPECTRAL_SCAN_CONF_CMDID,
    .vdev_spectral_scan_enable_cmdid = WMI_TLV_SPECTRAL_SCAN_ENABLE_CMDID,
    .request_stats_cmdid = WMI_TLV_REQUEST_STATS_CMDID,
    .set_arp_ns_offload_cmdid = WMI_TLV_SET_ARP_NS_OFFLOAD_CMDID,
    .network_list_offload_config_cmdid = WMI_TLV_NETWORK_LIST_OFFLOAD_CONFIG_CMDID,
    .gtk_offload_cmdid = WMI_TLV_GTK_OFFLOAD_CMDID,
    .csa_offload_enable_cmdid = WMI_TLV_CSA_OFFLOAD_ENABLE_CMDID,
    .csa_offload_chanswitch_cmdid = WMI_TLV_CSA_OFFLOAD_CHANSWITCH_CMDID,
    .chatter_set_mode_cmdid = WMI_TLV_CHATTER_SET_MODE_CMDID,
    .peer_tid_addba_cmdid = WMI_TLV_PEER_TID_ADDBA_CMDID,
    .peer_tid_delba_cmdid = WMI_TLV_PEER_TID_DELBA_CMDID,
    .sta_dtim_ps_method_cmdid = WMI_TLV_STA_DTIM_PS_METHOD_CMDID,
    .sta_uapsd_auto_trig_cmdid = WMI_TLV_STA_UAPSD_AUTO_TRIG_CMDID,
    .sta_keepalive_cmd = WMI_TLV_STA_KEEPALIVE_CMDID,
    .echo_cmdid = WMI_TLV_ECHO_CMDID,
    .pdev_utf_cmdid = WMI_TLV_PDEV_UTF_CMDID,
    .dbglog_cfg_cmdid = WMI_TLV_DBGLOG_CFG_CMDID,
    .pdev_qvit_cmdid = WMI_TLV_PDEV_QVIT_CMDID,
    .pdev_ftm_intg_cmdid = WMI_TLV_PDEV_FTM_INTG_CMDID,
    .vdev_set_keepalive_cmdid = WMI_TLV_VDEV_SET_KEEPALIVE_CMDID,
    .vdev_get_keepalive_cmdid = WMI_TLV_VDEV_GET_KEEPALIVE_CMDID,
    .force_fw_hang_cmdid = WMI_TLV_FORCE_FW_HANG_CMDID,
    .gpio_config_cmdid = WMI_TLV_GPIO_CONFIG_CMDID,
    .gpio_output_cmdid = WMI_TLV_GPIO_OUTPUT_CMDID,
    .pdev_get_temperature_cmdid = WMI_TLV_CMD_UNSUPPORTED,
    .vdev_set_wmm_params_cmdid = WMI_TLV_VDEV_SET_WMM_PARAMS_CMDID,
    .tdls_set_state_cmdid = WMI_TLV_TDLS_SET_STATE_CMDID,
    .tdls_peer_update_cmdid = WMI_TLV_TDLS_PEER_UPDATE_CMDID,
    .adaptive_qcs_cmdid = WMI_TLV_RESMGR_ADAPTIVE_OCS_CMDID,
    .scan_update_request_cmdid = WMI_CMD_UNSUPPORTED,
    .vdev_standby_response_cmdid = WMI_CMD_UNSUPPORTED,
    .vdev_resume_response_cmdid = WMI_CMD_UNSUPPORTED,
    .wlan_peer_caching_add_peer_cmdid = WMI_CMD_UNSUPPORTED,
    .wlan_peer_caching_evict_peer_cmdid = WMI_CMD_UNSUPPORTED,
    .wlan_peer_caching_restore_peer_cmdid = WMI_CMD_UNSUPPORTED,
    .wlan_peer_caching_print_all_peers_info_cmdid = WMI_CMD_UNSUPPORTED,
    .peer_update_wds_entry_cmdid = WMI_CMD_UNSUPPORTED,
    .peer_add_proxy_sta_entry_cmdid = WMI_CMD_UNSUPPORTED,
    .rtt_keepalive_cmdid = WMI_CMD_UNSUPPORTED,
    .oem_req_cmdid = WMI_CMD_UNSUPPORTED,
    .nan_cmdid = WMI_CMD_UNSUPPORTED,
    .vdev_ratemask_cmdid = WMI_CMD_UNSUPPORTED,
    .qboost_cfg_cmdid = WMI_CMD_UNSUPPORTED,
    .pdev_smart_ant_enable_cmdid = WMI_CMD_UNSUPPORTED,
    .pdev_smart_ant_set_rx_antenna_cmdid = WMI_CMD_UNSUPPORTED,
    .peer_smart_ant_set_tx_antenna_cmdid = WMI_CMD_UNSUPPORTED,
    .peer_smart_ant_set_train_info_cmdid = WMI_CMD_UNSUPPORTED,
    .peer_smart_ant_set_node_config_ops_cmdid = WMI_CMD_UNSUPPORTED,
    .pdev_set_antenna_switch_table_cmdid = WMI_CMD_UNSUPPORTED,
    .pdev_set_ctl_table_cmdid = WMI_CMD_UNSUPPORTED,
    .pdev_set_mimogain_table_cmdid = WMI_CMD_UNSUPPORTED,
    .pdev_ratepwr_table_cmdid = WMI_CMD_UNSUPPORTED,
    .pdev_ratepwr_chainmsk_table_cmdid = WMI_CMD_UNSUPPORTED,
    .pdev_fips_cmdid = WMI_CMD_UNSUPPORTED,
    .tt_set_conf_cmdid = WMI_CMD_UNSUPPORTED,
    .fwtest_cmdid = WMI_CMD_UNSUPPORTED,
    .vdev_atf_request_cmdid = WMI_CMD_UNSUPPORTED,
    .peer_atf_request_cmdid = WMI_CMD_UNSUPPORTED,
    .pdev_get_ani_cck_config_cmdid = WMI_CMD_UNSUPPORTED,
    .pdev_get_ani_ofdm_config_cmdid = WMI_CMD_UNSUPPORTED,
    .pdev_reserve_ast_entry_cmdid = WMI_CMD_UNSUPPORTED,
};

static struct wmi_pdev_param_map wmi_tlv_pdev_param_map = {
    .tx_chain_mask = WMI_TLV_PDEV_PARAM_TX_CHAIN_MASK,
    .rx_chain_mask = WMI_TLV_PDEV_PARAM_RX_CHAIN_MASK,
    .txpower_limit2g = WMI_TLV_PDEV_PARAM_TXPOWER_LIMIT2G,
    .txpower_limit5g = WMI_TLV_PDEV_PARAM_TXPOWER_LIMIT5G,
    .txpower_scale = WMI_TLV_PDEV_PARAM_TXPOWER_SCALE,
    .beacon_gen_mode = WMI_TLV_PDEV_PARAM_BEACON_GEN_MODE,
    .beacon_tx_mode = WMI_TLV_PDEV_PARAM_BEACON_TX_MODE,
    .resmgr_offchan_mode = WMI_TLV_PDEV_PARAM_RESMGR_OFFCHAN_MODE,
    .protection_mode = WMI_TLV_PDEV_PARAM_PROTECTION_MODE,
    .dynamic_bw = WMI_TLV_PDEV_PARAM_DYNAMIC_BW,
    .non_agg_sw_retry_th = WMI_TLV_PDEV_PARAM_NON_AGG_SW_RETRY_TH,
    .agg_sw_retry_th = WMI_TLV_PDEV_PARAM_AGG_SW_RETRY_TH,
    .sta_kickout_th = WMI_TLV_PDEV_PARAM_STA_KICKOUT_TH,
    .ac_aggrsize_scaling = WMI_TLV_PDEV_PARAM_AC_AGGRSIZE_SCALING,
    .ltr_enable = WMI_TLV_PDEV_PARAM_LTR_ENABLE,
    .ltr_ac_latency_be = WMI_TLV_PDEV_PARAM_LTR_AC_LATENCY_BE,
    .ltr_ac_latency_bk = WMI_TLV_PDEV_PARAM_LTR_AC_LATENCY_BK,
    .ltr_ac_latency_vi = WMI_TLV_PDEV_PARAM_LTR_AC_LATENCY_VI,
    .ltr_ac_latency_vo = WMI_TLV_PDEV_PARAM_LTR_AC_LATENCY_VO,
    .ltr_ac_latency_timeout = WMI_TLV_PDEV_PARAM_LTR_AC_LATENCY_TIMEOUT,
    .ltr_sleep_override = WMI_TLV_PDEV_PARAM_LTR_SLEEP_OVERRIDE,
    .ltr_rx_override = WMI_TLV_PDEV_PARAM_LTR_RX_OVERRIDE,
    .ltr_tx_activity_timeout = WMI_TLV_PDEV_PARAM_LTR_TX_ACTIVITY_TIMEOUT,
    .l1ss_enable = WMI_TLV_PDEV_PARAM_L1SS_ENABLE,
    .dsleep_enable = WMI_TLV_PDEV_PARAM_DSLEEP_ENABLE,
    .pcielp_txbuf_flush = WMI_TLV_PDEV_PARAM_PCIELP_TXBUF_FLUSH,
    .pcielp_txbuf_watermark = WMI_TLV_PDEV_PARAM_PCIELP_TXBUF_TMO_EN,
    .pcielp_txbuf_tmo_en = WMI_TLV_PDEV_PARAM_PCIELP_TXBUF_TMO_EN,
    .pcielp_txbuf_tmo_value = WMI_TLV_PDEV_PARAM_PCIELP_TXBUF_TMO_VALUE,
    .pdev_stats_update_period = WMI_TLV_PDEV_PARAM_PDEV_STATS_UPDATE_PERIOD,
    .vdev_stats_update_period = WMI_TLV_PDEV_PARAM_VDEV_STATS_UPDATE_PERIOD,
    .peer_stats_update_period = WMI_TLV_PDEV_PARAM_PEER_STATS_UPDATE_PERIOD,
    .bcnflt_stats_update_period = WMI_TLV_PDEV_PARAM_BCNFLT_STATS_UPDATE_PERIOD,
    .pmf_qos = WMI_TLV_PDEV_PARAM_PMF_QOS,
    .arp_ac_override = WMI_TLV_PDEV_PARAM_ARP_AC_OVERRIDE,
    .dcs = WMI_TLV_PDEV_PARAM_DCS,
    .ani_enable = WMI_TLV_PDEV_PARAM_ANI_ENABLE,
    .ani_poll_period = WMI_TLV_PDEV_PARAM_ANI_POLL_PERIOD,
    .ani_listen_period = WMI_TLV_PDEV_PARAM_ANI_LISTEN_PERIOD,
    .ani_ofdm_level = WMI_TLV_PDEV_PARAM_ANI_OFDM_LEVEL,
    .ani_cck_level = WMI_TLV_PDEV_PARAM_ANI_CCK_LEVEL,
    .dyntxchain = WMI_TLV_PDEV_PARAM_DYNTXCHAIN,
    .proxy_sta = WMI_TLV_PDEV_PARAM_PROXY_STA,
    .idle_ps_config = WMI_TLV_PDEV_PARAM_IDLE_PS_CONFIG,
    .power_gating_sleep = WMI_TLV_PDEV_PARAM_POWER_GATING_SLEEP,
    .fast_channel_reset = WMI_TLV_PDEV_PARAM_UNSUPPORTED,
    .burst_dur = WMI_TLV_PDEV_PARAM_BURST_DUR,
    .burst_enable = WMI_TLV_PDEV_PARAM_BURST_ENABLE,
    .cal_period = WMI_PDEV_PARAM_UNSUPPORTED,
    .aggr_burst = WMI_PDEV_PARAM_UNSUPPORTED,
    .rx_decap_mode = WMI_PDEV_PARAM_UNSUPPORTED,
    .smart_antenna_default_antenna = WMI_PDEV_PARAM_UNSUPPORTED,
    .igmpmld_override = WMI_PDEV_PARAM_UNSUPPORTED,
    .igmpmld_tid = WMI_PDEV_PARAM_UNSUPPORTED,
    .antenna_gain = WMI_PDEV_PARAM_UNSUPPORTED,
    .rx_filter = WMI_PDEV_PARAM_UNSUPPORTED,
    .set_mcast_to_ucast_tid = WMI_PDEV_PARAM_UNSUPPORTED,
    .proxy_sta_mode = WMI_PDEV_PARAM_UNSUPPORTED,
    .set_mcast2ucast_mode = WMI_PDEV_PARAM_UNSUPPORTED,
    .set_mcast2ucast_buffer = WMI_PDEV_PARAM_UNSUPPORTED,
    .remove_mcast2ucast_buffer = WMI_PDEV_PARAM_UNSUPPORTED,
    .peer_sta_ps_statechg_enable = WMI_PDEV_PARAM_UNSUPPORTED,
    .igmpmld_ac_override = WMI_PDEV_PARAM_UNSUPPORTED,
    .block_interbss = WMI_PDEV_PARAM_UNSUPPORTED,
    .set_disable_reset_cmdid = WMI_PDEV_PARAM_UNSUPPORTED,
    .set_msdu_ttl_cmdid = WMI_PDEV_PARAM_UNSUPPORTED,
    .set_ppdu_duration_cmdid = WMI_PDEV_PARAM_UNSUPPORTED,
    .txbf_sound_period_cmdid = WMI_PDEV_PARAM_UNSUPPORTED,
    .set_promisc_mode_cmdid = WMI_PDEV_PARAM_UNSUPPORTED,
    .set_burst_mode_cmdid = WMI_PDEV_PARAM_UNSUPPORTED,
    .en_stats = WMI_PDEV_PARAM_UNSUPPORTED,
    .mu_group_policy = WMI_PDEV_PARAM_UNSUPPORTED,
    .noise_detection = WMI_PDEV_PARAM_UNSUPPORTED,
    .noise_threshold = WMI_PDEV_PARAM_UNSUPPORTED,
    .dpd_enable = WMI_PDEV_PARAM_UNSUPPORTED,
    .set_mcast_bcast_echo = WMI_PDEV_PARAM_UNSUPPORTED,
    .atf_strict_sch = WMI_PDEV_PARAM_UNSUPPORTED,
    .atf_sched_duration = WMI_PDEV_PARAM_UNSUPPORTED,
    .ant_plzn = WMI_PDEV_PARAM_UNSUPPORTED,
    .mgmt_retry_limit = WMI_PDEV_PARAM_UNSUPPORTED,
    .sensitivity_level = WMI_PDEV_PARAM_UNSUPPORTED,
    .signed_txpower_2g = WMI_PDEV_PARAM_UNSUPPORTED,
    .signed_txpower_5g = WMI_PDEV_PARAM_UNSUPPORTED,
    .enable_per_tid_amsdu = WMI_PDEV_PARAM_UNSUPPORTED,
    .enable_per_tid_ampdu = WMI_PDEV_PARAM_UNSUPPORTED,
    .cca_threshold = WMI_PDEV_PARAM_UNSUPPORTED,
    .rts_fixed_rate = WMI_PDEV_PARAM_UNSUPPORTED,
    .pdev_reset = WMI_PDEV_PARAM_UNSUPPORTED,
    .wapi_mbssid_offset = WMI_PDEV_PARAM_UNSUPPORTED,
    .arp_srcaddr = WMI_PDEV_PARAM_UNSUPPORTED,
    .arp_dstaddr = WMI_PDEV_PARAM_UNSUPPORTED,
};

static struct wmi_vdev_param_map wmi_tlv_vdev_param_map = {
    .rts_threshold = WMI_TLV_VDEV_PARAM_RTS_THRESHOLD,
    .fragmentation_threshold = WMI_TLV_VDEV_PARAM_FRAGMENTATION_THRESHOLD,
    .beacon_interval = WMI_TLV_VDEV_PARAM_BEACON_INTERVAL,
    .listen_interval = WMI_TLV_VDEV_PARAM_LISTEN_INTERVAL,
    .multicast_rate = WMI_TLV_VDEV_PARAM_MULTICAST_RATE,
    .mgmt_tx_rate = WMI_TLV_VDEV_PARAM_MGMT_TX_RATE,
    .slot_time = WMI_TLV_VDEV_PARAM_SLOT_TIME,
    .preamble = WMI_TLV_VDEV_PARAM_PREAMBLE,
    .swba_time = WMI_TLV_VDEV_PARAM_SWBA_TIME,
    .wmi_vdev_stats_update_period = WMI_TLV_VDEV_STATS_UPDATE_PERIOD,
    .wmi_vdev_pwrsave_ageout_time = WMI_TLV_VDEV_PWRSAVE_AGEOUT_TIME,
    .wmi_vdev_host_swba_interval = WMI_TLV_VDEV_HOST_SWBA_INTERVAL,
    .dtim_period = WMI_TLV_VDEV_PARAM_DTIM_PERIOD,
    .wmi_vdev_oc_scheduler_air_time_limit = WMI_TLV_VDEV_OC_SCHEDULER_AIR_TIME_LIMIT,
    .wds = WMI_TLV_VDEV_PARAM_WDS,
    .atim_window = WMI_TLV_VDEV_PARAM_ATIM_WINDOW,
    .bmiss_count_max = WMI_TLV_VDEV_PARAM_BMISS_COUNT_MAX,
    .bmiss_first_bcnt = WMI_TLV_VDEV_PARAM_BMISS_FIRST_BCNT,
    .bmiss_final_bcnt = WMI_TLV_VDEV_PARAM_BMISS_FINAL_BCNT,
    .feature_wmm = WMI_TLV_VDEV_PARAM_FEATURE_WMM,
    .chwidth = WMI_TLV_VDEV_PARAM_CHWIDTH,
    .chextoffset = WMI_TLV_VDEV_PARAM_CHEXTOFFSET,
    .disable_htprotection = WMI_TLV_VDEV_PARAM_DISABLE_HTPROTECTION,
    .sta_quickkickout = WMI_TLV_VDEV_PARAM_STA_QUICKKICKOUT,
    .mgmt_rate = WMI_TLV_VDEV_PARAM_MGMT_RATE,
    .protection_mode = WMI_TLV_VDEV_PARAM_PROTECTION_MODE,
    .fixed_rate = WMI_TLV_VDEV_PARAM_FIXED_RATE,
    .sgi = WMI_TLV_VDEV_PARAM_SGI,
    .ldpc = WMI_TLV_VDEV_PARAM_LDPC,
    .tx_stbc = WMI_TLV_VDEV_PARAM_TX_STBC,
    .rx_stbc = WMI_TLV_VDEV_PARAM_RX_STBC,
    .intra_bss_fwd = WMI_TLV_VDEV_PARAM_INTRA_BSS_FWD,
    .def_keyid = WMI_TLV_VDEV_PARAM_DEF_KEYID,
    .nss = WMI_TLV_VDEV_PARAM_NSS,
    .bcast_data_rate = WMI_TLV_VDEV_PARAM_BCAST_DATA_RATE,
    .mcast_data_rate = WMI_TLV_VDEV_PARAM_MCAST_DATA_RATE,
    .mcast_indicate = WMI_TLV_VDEV_PARAM_MCAST_INDICATE,
    .dhcp_indicate = WMI_TLV_VDEV_PARAM_DHCP_INDICATE,
    .unknown_dest_indicate = WMI_TLV_VDEV_PARAM_UNKNOWN_DEST_INDICATE,
    .ap_keepalive_min_idle_inactive_time_secs =
        WMI_TLV_VDEV_PARAM_AP_KEEPALIVE_MIN_IDLE_INACTIVE_TIME_SECS,
    .ap_keepalive_max_idle_inactive_time_secs =
        WMI_TLV_VDEV_PARAM_AP_KEEPALIVE_MAX_IDLE_INACTIVE_TIME_SECS,
    .ap_keepalive_max_unresponsive_time_secs =
        WMI_TLV_VDEV_PARAM_AP_KEEPALIVE_MAX_UNRESPONSIVE_TIME_SECS,
    .ap_enable_nawds = WMI_TLV_VDEV_PARAM_AP_ENABLE_NAWDS,
    .mcast2ucast_set = WMI_TLV_VDEV_PARAM_UNSUPPORTED,
    .enable_rtscts = WMI_TLV_VDEV_PARAM_ENABLE_RTSCTS,
    .txbf = WMI_TLV_VDEV_PARAM_TXBF,
    .packet_powersave = WMI_TLV_VDEV_PARAM_PACKET_POWERSAVE,
    .drop_unencry = WMI_TLV_VDEV_PARAM_DROP_UNENCRY,
    .tx_encap_type = WMI_TLV_VDEV_PARAM_TX_ENCAP_TYPE,
    .ap_detect_out_of_sync_sleeping_sta_time_secs = WMI_TLV_VDEV_PARAM_UNSUPPORTED,
    .rc_num_retries = WMI_VDEV_PARAM_UNSUPPORTED,
    .cabq_maxdur = WMI_VDEV_PARAM_UNSUPPORTED,
    .mfptest_set = WMI_VDEV_PARAM_UNSUPPORTED,
    .rts_fixed_rate = WMI_VDEV_PARAM_UNSUPPORTED,
    .vht_sgimask = WMI_VDEV_PARAM_UNSUPPORTED,
    .vht80_ratemask = WMI_VDEV_PARAM_UNSUPPORTED,
    .early_rx_adjust_enable = WMI_VDEV_PARAM_UNSUPPORTED,
    .early_rx_tgt_bmiss_num = WMI_VDEV_PARAM_UNSUPPORTED,
    .early_rx_bmiss_sample_cycle = WMI_VDEV_PARAM_UNSUPPORTED,
    .early_rx_slop_step = WMI_VDEV_PARAM_UNSUPPORTED,
    .early_rx_init_slop = WMI_VDEV_PARAM_UNSUPPORTED,
    .early_rx_adjust_pause = WMI_VDEV_PARAM_UNSUPPORTED,
    .proxy_sta = WMI_VDEV_PARAM_UNSUPPORTED,
    .meru_vc = WMI_VDEV_PARAM_UNSUPPORTED,
    .rx_decap_type = WMI_VDEV_PARAM_UNSUPPORTED,
    .bw_nss_ratemask = WMI_VDEV_PARAM_UNSUPPORTED,
};

static const struct wmi_ops wmi_tlv_ops = {
    .rx = ath10k_wmi_tlv_op_rx,
    .map_svc = wmi_tlv_svc_map,

    .pull_scan = ath10k_wmi_tlv_op_pull_scan_ev,
    .pull_mgmt_rx = ath10k_wmi_tlv_op_pull_mgmt_rx_ev,
#if 0   // NEEDS PORTING
    .pull_ch_info = ath10k_wmi_tlv_op_pull_ch_info_ev,
#endif  // NEEDS PORTING
    .pull_vdev_start = ath10k_wmi_tlv_op_pull_vdev_start_ev,
#if 0   // NEEDS PORTING
    .pull_peer_kick = ath10k_wmi_tlv_op_pull_peer_kick_ev,
    .pull_swba = ath10k_wmi_tlv_op_pull_swba_ev,
    .pull_phyerr_hdr = ath10k_wmi_tlv_op_pull_phyerr_ev_hdr,
    .pull_phyerr = ath10k_wmi_op_pull_phyerr_ev,
#endif  // NEEDS PORTING
    .pull_svc_rdy = ath10k_wmi_tlv_op_pull_svc_rdy_ev,
    .pull_rdy = ath10k_wmi_tlv_op_pull_rdy_ev,
#if 0   // NEEDS PORTING
    .pull_fw_stats = ath10k_wmi_tlv_op_pull_fw_stats,
    .pull_roam_ev = ath10k_wmi_tlv_op_pull_roam_ev,
    .pull_wow_event = ath10k_wmi_tlv_op_pull_wow_ev,
#endif  // NEEDS PORTING
    .pull_echo_ev = ath10k_wmi_tlv_op_pull_echo_ev,
    .get_txbf_conf_scheme = ath10k_wmi_tlv_txbf_conf_scheme,

    .gen_pdev_suspend = ath10k_wmi_tlv_op_gen_pdev_suspend,
    .gen_pdev_resume = ath10k_wmi_tlv_op_gen_pdev_resume,
    .gen_pdev_set_rd = ath10k_wmi_tlv_op_gen_pdev_set_rd,
    .gen_pdev_set_param = ath10k_wmi_tlv_op_gen_pdev_set_param,
    .gen_init = ath10k_wmi_tlv_op_gen_init,
    .gen_start_scan = ath10k_wmi_tlv_op_gen_start_scan,
    .gen_stop_scan = ath10k_wmi_tlv_op_gen_stop_scan,
    .gen_vdev_create = ath10k_wmi_tlv_op_gen_vdev_create,
    .gen_vdev_delete = ath10k_wmi_tlv_op_gen_vdev_delete,
    .gen_vdev_start = ath10k_wmi_tlv_op_gen_vdev_start,
    .gen_vdev_stop = ath10k_wmi_tlv_op_gen_vdev_stop,
    .gen_vdev_up = ath10k_wmi_tlv_op_gen_vdev_up,
    .gen_vdev_down = ath10k_wmi_tlv_op_gen_vdev_down,
    .gen_vdev_set_param = ath10k_wmi_tlv_op_gen_vdev_set_param,
    .gen_vdev_install_key = ath10k_wmi_tlv_op_gen_vdev_install_key,
    .gen_vdev_wmm_conf = ath10k_wmi_tlv_op_gen_vdev_wmm_conf,
    .gen_peer_create = ath10k_wmi_tlv_op_gen_peer_create,
    .gen_peer_delete = ath10k_wmi_tlv_op_gen_peer_delete,
    .gen_peer_flush = ath10k_wmi_tlv_op_gen_peer_flush,
    .gen_peer_set_param = ath10k_wmi_tlv_op_gen_peer_set_param,
    .gen_peer_assoc = ath10k_wmi_tlv_op_gen_peer_assoc,
#if 0   // NEEDS PORTING
    .gen_set_psmode = ath10k_wmi_tlv_op_gen_set_psmode,
    .gen_set_sta_ps = ath10k_wmi_tlv_op_gen_set_sta_ps,
    .gen_set_ap_ps = ath10k_wmi_tlv_op_gen_set_ap_ps,
#endif  // NEEDS PORTING
    .gen_scan_chan_list = ath10k_wmi_tlv_op_gen_scan_chan_list,
    .gen_bcn_tmpl = ath10k_wmi_tlv_op_gen_bcn_tmpl,
    .gen_prb_tmpl = ath10k_wmi_tlv_op_gen_prb_tmpl,
#if 0   // NEEDS PORTING
    .gen_beacon_dma = ath10k_wmi_tlv_op_gen_beacon_dma,
    .gen_pdev_set_wmm = ath10k_wmi_tlv_op_gen_pdev_set_wmm,
    .gen_request_stats = ath10k_wmi_tlv_op_gen_request_stats,
    .gen_force_fw_hang = ath10k_wmi_tlv_op_gen_force_fw_hang,
    /* .gen_mgmt_tx = not implemented; HTT is used */
    .gen_dbglog_cfg = ath10k_wmi_tlv_op_gen_dbglog_cfg,
    .gen_pktlog_enable = ath10k_wmi_tlv_op_gen_pktlog_enable,
    .gen_pktlog_disable = ath10k_wmi_tlv_op_gen_pktlog_disable,
    /* .gen_pdev_set_quiet_mode not implemented */
    /* .gen_pdev_get_temperature not implemented */
    /* .gen_addba_clear_resp not implemented */
    /* .gen_addba_send not implemented */
    /* .gen_addba_set_resp not implemented */
    /* .gen_delba_send not implemented */
    .gen_p2p_go_bcn_ie = ath10k_wmi_tlv_op_gen_p2p_go_bcn_ie,
    .gen_vdev_sta_uapsd = ath10k_wmi_tlv_op_gen_vdev_sta_uapsd,
    .gen_sta_keepalive = ath10k_wmi_tlv_op_gen_sta_keepalive,
    .gen_wow_enable = ath10k_wmi_tlv_op_gen_wow_enable,
    .gen_wow_add_wakeup_event = ath10k_wmi_tlv_op_gen_wow_add_wakeup_event,
    .gen_wow_host_wakeup_ind = ath10k_wmi_tlv_gen_wow_host_wakeup_ind,
    .gen_wow_add_pattern = ath10k_wmi_tlv_op_gen_wow_add_pattern,
    .gen_wow_del_pattern = ath10k_wmi_tlv_op_gen_wow_del_pattern,
    .gen_update_fw_tdls_state = ath10k_wmi_tlv_op_gen_update_fw_tdls_state,
    .gen_tdls_peer_update = ath10k_wmi_tlv_op_gen_tdls_peer_update,
    .gen_adaptive_qcs = ath10k_wmi_tlv_op_gen_adaptive_qcs,
    .fw_stats_fill = ath10k_wmi_main_op_fw_stats_fill,
#endif  // NEEDS PORTING
    .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
    .gen_echo = ath10k_wmi_tlv_op_gen_echo,
#if 0   // NEEDS PORTING
    .gen_vdev_spectral_conf = ath10k_wmi_tlv_op_gen_vdev_spectral_conf,
    .gen_vdev_spectral_enable = ath10k_wmi_tlv_op_gen_vdev_spectral_enable,
#endif  // NEEDS PORTING
};

static const struct wmi_peer_flags_map wmi_tlv_peer_flags_map = {
    .auth = WMI_TLV_PEER_AUTH,
    .qos = WMI_TLV_PEER_QOS,
    .need_ptk_4_way = WMI_TLV_PEER_NEED_PTK_4_WAY,
    .need_gtk_2_way = WMI_TLV_PEER_NEED_GTK_2_WAY,
    .apsd = WMI_TLV_PEER_APSD,
    .ht = WMI_TLV_PEER_HT,
    .bw40 = WMI_TLV_PEER_40MHZ,
    .stbc = WMI_TLV_PEER_STBC,
    .ldbc = WMI_TLV_PEER_LDPC,
    .dyn_mimops = WMI_TLV_PEER_DYN_MIMOPS,
    .static_mimops = WMI_TLV_PEER_STATIC_MIMOPS,
    .spatial_mux = WMI_TLV_PEER_SPATIAL_MUX,
    .vht = WMI_TLV_PEER_VHT,
    .bw80 = WMI_TLV_PEER_80MHZ,
    .pmf = WMI_TLV_PEER_PMF,
    .bw160 = WMI_TLV_PEER_160MHZ,
};

/************/
/* TLV init */
/************/

void ath10k_wmi_tlv_attach(struct ath10k* ar) {
    ar->wmi.cmd = &wmi_tlv_cmd_map;
    ar->wmi.vdev_param = &wmi_tlv_vdev_param_map;
    ar->wmi.pdev_param = &wmi_tlv_pdev_param_map;
    ar->wmi.ops = &wmi_tlv_ops;
    ar->wmi.peer_flags = &wmi_tlv_peer_flags_map;
}