| commit | 7c615c1ded1c6f05bb48ab8eafc6771454303c1c | [log] [tgz] |
|---|---|---|
| author | Vardhan Mudunuru <vardhan@google.com> | Thu Jun 20 05:00:34 2019 +0000 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Thu Jun 20 05:00:34 2019 +0000 |
| tree | 838eb6424a23a44a2418055e8fcba5ed39c72cd2 | |
| parent | c6a0f32b5f0124ea204ae35698101a8957cdf700 [diff] |
[modular][testing] Fix race: uninitialized access in TestHarnessLauncher Observed this race in flaky test: TestHarnessBuilderTest.AddServiceFromComponent. I suspect that the thread might be accessing an uninitialized std::mutex. This CL changes the initialization order to avoid this condition. Test: I'm no longer able to make the test hang using: fx run-test test_harness_fixture_test -t test_harness_fixture_test_bin -- --gtest_filter='TestHarnessBuilderTest.AddServiceFromComponent' --gtest_repeat=10000 Change-Id: I11824652f22b08a80a9e34533e5cdca2b9cc09e3
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
See Getting Started.
See the documentation.