tree c9e0b26df032f8e816b21776d66e47c4d6e917b1
parent daf2dfbd801a621746395bca8334ead3c3572c4a
author Joshua Liebow-Feeser <joshlf@google.com> 1565994906 +0000
committer Joshua Liebow-Feeser <joshlf@google.com> 1565994906 +0000

[netstack3][icmp] Factor out ICMP error message logic

All ICMP error messages are sent by calling `IcmpContext`'s
`send_icmp_error_message` method. Instead of calling
`should_send_icmpv4_error` and `should_send_icmpv6_error` from each
top-level function separately, move that logic into
`send_icmp_error_message`.

Test: Existing ICMP tests pass
Change-Id: I2b21b58d18cfadc7bb096be73116dd7733dab77d