tree 60e3cac62f7504971c4491a24b4d31d8db41ed4e
parent f400bc0295ab2d4ce8b281ba23d3b40fff1ce356
author Scott Graham <scottmg@google.com> 1585948567 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1585948567 +0000

Revert "[zircon][fidl][zx] Extract built-in zx library"

This reverts commit cf130f3909c3d0b88352754e44a5431fa1fbaf2e.

Reason for revert: internal bot failure, see 
https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=7802#c22

Original change's description:
> [zircon][fidl][zx] Extract built-in zx library
> 
> This moves the magically injected `library zx` out of fidlc, and into
> normal fidl files in //zircon/vdso. This allows the syscall definitions
> to share the definition with other fidl, and also to have the rest of
> the syscall definitions live in library zx (rather than the fake
> "library zz" that was internally mapped to zx by kazoo).
> 
> Rather than have every fidl library have to specify a public_deps on zx,
> the GN templates are modified to automatically include that dependency,
> so previous behaviour is maintained.
> 
> This is largely a reland of
> https://fuchsia-review.googlesource.com/c/fuchsia/+/343788 other than
> updates for various churn that has happened since then. The previous CL
> was reverted because of the details of how Chromium generated build
> rules (see fxbug.dev/44602), but does not appear to be an issue any more
> (based on doing a local Chromium build with tools/fuchsia/local-sdk.py
> in the Chromium repo.)
> 
> Bug: 7802
> Bug: 42717
> Bug: 44602
> Change-Id: I8c717d292974089491b6c304c7b95ee8266912f5
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/377821
> Reviewed-by: Pascal Perez <pascallouis@google.com>
> Reviewed-by: Adam Barth <abarth@google.com>
> API-Review: Pascal Perez <pascallouis@google.com>
> Testability-Review: Pascal Perez <pascallouis@google.com>
> Commit-Queue: Scott Graham <scottmg@google.com>

TBR=abarth@google.com,scottmg@google.com,pascallouis@google.com

Change-Id: I1eb63ac3f583d6dd52d1f8a82d3111a2f5dcd14e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 7802, 42717, 44602
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/378033
Reviewed-by: Scott Graham <scottmg@google.com>
Commit-Queue: Scott Graham <scottmg@google.com>