commit aaf80257f5b670d219042f2953c64689d4b5494c
author Matt Sandy <msandy@google.com> Sun Feb 06 00:25:22 2022 +0000
committer releases-try-builder <releases-try-builder@fuchsia-infra.iam.gserviceaccount.com> Tue Feb 08 10:43:11 2022 +0000
tree 2e0a3622f634b4894ab9c4d38bd92b2e1707e84c
parent 19f119f37814ea87a49f4d140d4abfa488bdf74c

[camera] Fix sherlock ISP IRQ mode setting

This change updates the sherlock board configuration to correct the ISP
IRQ mode to LEVEL_HIGH. This reflects its default (and current) setting
in the ISP. Prior to this change, if the ISP fell behind on processing,
the presence of buffered frame data would hold the GIC bit high despite
being reset by the ISR, preventing the interrupt from signaling. The
only reason this worked at all before is because when the ISP is gated
by the sensor speed, level-mode interrupts also act as pulses.

Bug: b/199321382
Test: Verified sherlock camera no longer stalls after heavy system load
Change-Id: Ie9e80a721a538fe7776d7537c98a7f9ab66c0398

src/devices/board/drivers/sherlock/sherlock-camera.cc

diff --git a/src/devices/board/drivers/sherlock/sherlock-camera.cc b/src/devices/board/drivers/sherlock/sherlock-camera.cc
index 2726888..3279014 100644
--- a/src/devices/board/drivers/sherlock/sherlock-camera.cc
+++ b/src/devices/board/drivers/sherlock/sherlock-camera.cc
@@ -147,7 +147,7 @@
 static const pbus_irq_t isp_irqs[] = {
     {
         .irq = T931_MALI_ISP_IRQ,
-        .mode = ZX_INTERRUPT_MODE_EDGE_HIGH,
+        .mode = ZX_INTERRUPT_MODE_LEVEL_HIGH,
     },
 };