tree 3c3a1d910d7167ea93dbee297f9194d15dabc052
parent d6e903e0368df3e7ea1852bc582efaea8a18b261
author Bert Muthalaly <stijlist@google.com> 1579399708 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1579399708 +0000

[netstack] don't eagerly log any Cobalt events

...obviating the need for package `schedule` and eliminating one
potential flake in netstack_cobalt_integration_test, where the call to
connect() would notify newSocketNotifications, logging events to cobalt
before the corresponding call to accept() was observed.

These eager calls to LogCobaltEvents were useful when they made the
difference between netstack_cobalt_integration_test running in 60s vs
1s, but are less useful now, when the test takes ~240 seconds
regardless.

As a further simplification, we can remove the newSocketNotifications
chan entirely (and inline socketMetadata's type Netstack pointer into
its containing structs) at the small cost of only observing the current
socket count to update socketCountMax every 60 seconds (vs on every
socket creation).

Bug: 44207
Change-Id: I968aa7707bc76cd6db677552f2765eb94f6dc069